Re: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012

Hi, David The patch works fine when using build.bat to build hotspot on Windows, there is one issue with create.bat, which will fail to create project file for VS2012. I tried to work this around to create a VS2010 project, see URL: http://javaweb.us.oracle.com/~yqi/webrev/vs2012build/

Re: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012

On 07/15/13 06:04 PM, David Holmes wrote: I will sponsor it for you. I'll use the existing patch and revert the jprt change. Thanks, David Thank you. I appreciate it. Tim

Re: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012

On 15/07/2013 10:29 PM, Tim Bell wrote: David, Anthony : Thank you for the review. David wrote: Only concern is that we may want to separate out the make/jprt.properties change, otherwise we can't push this until the switch to the new compilers has been officially approved. It may be easier t

Re: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012

David, Anthony : Thank you for the review. David wrote: Only concern is that we may want to separate out the make/jprt.properties change, otherwise we can't push this until the switch to the new compilers has been officially approved. It may be easier to put the vs2012 support in place first

Re: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012

Hi Tim, The fix looks good to me. -- best regards, Anthony On 07/13/13 15:51, Tim Bell wrote: Hello everyone- Many thanks for the early feedback on this JDK8 hotspot + VS2012 project. A revised webrev is here: http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.01/ These changes build