On 9/5/13 10:53 AM, Joe Darcy wrote:
On 9/5/2013 2:01 AM, Magnus Ihse Bursie wrote:
First of all, I think what you're doing is a great job, and I'm all in
favor of enabling more warnings!
Thanks; I'm all for more warnings too :-)
I think you meant, you're for *fewer* warnings. :-)
DISABL
Hi Magnus,
On 9/5/2013 2:01 AM, Magnus Ihse Bursie wrote:
Hi Joe,
First of all, I think what you're doing is a great job, and I'm all in
favor of enabling more warnings!
Thanks; I'm all for more warnings too :-)
DISABLE_WARNINGS:=-Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial
Hi Volker,
Most of the changes look good. Thank you for the general house-keeping
of shared code!
Some comments inlined:
common/autoconf/build-aux/config.guess
On AIX 'config.guess' may return 'powerpc' as architecture but 'powerpc' is
implicitly handled as 32-bit architecture in 'platform.
On 2013-09-02 17:38, Boaz Nahum wrote:
Many thanks.
Boaz
The fix for this will be in build b106.
/Magnus
Omair,
It might make sense to set
VAR_CPU to ESA_390
VAR_CPU_ARCH to ESA_390 or ever to ESA_3xx
for both s390 and s390x.
s370 diverged over time to a variety of more or less compatible series
and it's possible the same happens (if not already happened) with s390.
-Dmitry
On 2013-09-04 23:2
On 2013-09-04 21:26, Omair Majid wrote:
Over in Fedora-land, we are trying to build OpenJDK (using zero) on
s390(x) [1]. One of the changes needed is updating the platform.m4 file
to teach it about s390(x). The following webrev does that:
http://cr.openjdk.java.net/~omajid/webrevs/s390-platform/0
Looks good to me.
Created:
8024320: Add s390(x) detection to platform.m4
/Erik
On 2013-09-04 21:26, Omair Majid wrote:
Hi,
Over in Fedora-land, we are trying to build OpenJDK (using zero) on
s390(x) [1]. One of the changes needed is updating the platform.m4 file
to teach it about s390(x). Th
Hi Joe,
First of all, I think what you're doing is a great job, and I'm all in
favor of enabling more warnings!
DISABLE_WARNINGS:=-Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally
+JAVAC_WARNINGS:=-Xlint:-unchecked,-deprec
