Hi Kumar,
This is still dead code in
src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java
String os_arch = System.getProperty("os.arch");
Also:
test/java/nio/channels/spi/SelectorProvider/inheritedChannel/lib/solaris-amd64/libLauncher.so
I know this already exist but I thought bi
Hi David, Staffan, Alan,
I have addressed all the issues pointed and some more I found while jprt
testing.
The updated webrev for jdk is here:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk.1/
and the delta webrev since the last review webrev is here:
http://cr.openjdk.java.net/~ksrini
Hi Naoto,
On 7/09/2013 5:01 AM, Naoto Sato wrote:
Hello,
Please review the fix for the following bug. At the moment, it's not yet
reflected in the bug database, but the symptom is that
sun.util.resources.en package is split between rt.jar and
localedata.jar, which would make it problematic in J
Hi Kumar,
A few minor comments ...
src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java
Seems to me this is all dead now:
199 /*
200 * A wrinkle in the environment:
201 * 64-bit executables are stored under
$JAVA_HOME/bin/os_arch
Hi Ioi,
I'd suggest that the next time rules.make gets modified - the default version
of VS should become VS2010, not 2003 as it is now.
0.02,
Ivan
On Aug 27, 2013, at 8:55 AM, Yumin Qi wrote:
> Looks good to me.
>
> Thanks
> Yumin
>
> On 8/26/2013 6:17 PM, Ioi Lam wrote:
>> Please review
Kumar - the makefile changes look good to me.
Tim
On 09/ 7/13 03:50 AM, Staffan Larsen wrote:
This is a welcome change. I've looked at the serviceability test and the
changes look good except:
test/demo/jvmti/DemoRun.java
test/sun/tools/jhat/HatRun.java
- Looks like there are still some -d
I can't be a reviewer for this change but I do want to support it.
I'd be happy to see this rudimentary dependency go away.
Ideally I would like to see later a back port to JDK7.
Ivan
On Sep 7, 2013, at 12:21 AM, Vadim Pakhnushev
wrote:
> Hi all,
>
> Please review the fix for this bug:
> ht
