Re: RFR: Changes to disable and/or remove Solaris 32-bit from JDK8

2013-09-10 Thread Staffan Larsen
In SunCommandLineLauncher.java: 198 if (home.length() 0) { 199 String os_arch = System.getProperty(os.arch); 200 if (SunOS.equals(System.getProperty(os.name))) { 201 exePath = home + File.separator + bin + File.separator + exe;

RFR: JDK-8010185 add --with-override-nashorn to configure

2013-09-10 Thread Magnus Ihse Bursie
When nashorn was added, we should extend the --with-override-X functionality to cover it as well. An attempt to do so was appearantly made, but it did not work. This fix also adds checks for nashorn analogue to the other repos for --with-add/override-source-root. Webrev here:

Re: RFR (M): 8024265: Enable new build on AIX (top level part)

2013-09-10 Thread Volker Simonis
On Mon, Sep 9, 2013 at 4:32 PM, Volker Simonis volker.simo...@gmail.comwrote: Hi Magnus, thanks again for the review. Please see my comments inline: On Mon, Sep 9, 2013 at 12:23 PM, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com wrote: Hi Volker, Some more comments inlined. OK,

Re: RFR (M): 8024265: Enable new build on AIX (top level part)

2013-09-10 Thread Volker Simonis
On Mon, Sep 9, 2013 at 4:32 PM, Volker Simonis volker.simo...@gmail.comwrote: Hi Magnus, thanks again for the review. Please see my comments inline: On Mon, Sep 9, 2013 at 12:23 PM, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com wrote: Hi Volker, Some more comments inlined. OK,

Re: RFR (M): 8024265: Enable new build on AIX (top level part)

2013-09-10 Thread Magnus Ihse Bursie
Sorry, I missed your question. I can't speak for the aix-port repo, but I'm satisfied from the build point of view. /Magnus 10 sep 2013 kl. 14:22 skrev Volker Simonis volker.simo...@gmail.com: On Mon, Sep 9, 2013 at 4:32 PM, Volker Simonis volker.simo...@gmail.com wrote: Hi Magnus,

Re: RFR (M): 8024265: Enable new build on AIX (top level part)

2013-09-10 Thread Volker Simonis
On Tue, Sep 10, 2013 at 3:05 PM, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com wrote: Sorry, I missed your question. I can't speak for the aix-port repo, but I'm satisfied from the build point of view. Thanks. I've added you as reviewer. /Magnus 10 sep 2013 kl. 14:22 skrev Volker

Re: [8]RFR: 8024332: sun/util/resources/en split between rt.jar and localedata.jar

2013-09-10 Thread Alan Bateman
On 06/09/2013 20:01, Naoto Sato wrote: Hello, Please review the fix for the following bug. At the moment, it's not yet reflected in the bug database, but the symptom is that sun.util.resources.en package is split between rt.jar and localedata.jar, which would make it problematic in Jigsaw

Re: [8]RFR: 8024332: sun/util/resources/en split between rt.jar and localedata.jar

2013-09-10 Thread Naoto Sato
Hi Alan, On 09/10/2013 08:44 AM, Alan Bateman wrote: I've looked through the changes (except the old build) and I don't see anything obviously wrong. The only question I have is on the footprint, meaning the number of classes that move from localedata.jar to rt.jar. Do you happen to know the

Re: RFR: Add s390(x) detection to platform.m4

2013-09-10 Thread Omair Majid
On 09/09/2013 01:40 PM, Omair Majid wrote: On 09/05/2013 05:10 AM, Magnus Ihse Bursie wrote: On 2013-09-04 21:26, Omair Majid wrote: Over in Fedora-land, we are trying to build OpenJDK (using zero) on s390(x) [1]. One of the changes needed is updating the platform.m4 file to teach it about

hg: jdk8/build: Added tag jdk8-b106 for changeset 8e7b4d9fb00f

2013-09-10 Thread david . katleman
Changeset: 58f1b6f32b47 Author:cl Date: 2013-09-05 02:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/58f1b6f32b47 Added tag jdk8-b106 for changeset 8e7b4d9fb00f ! .hgtags

hg: jdk8/build/corba: Added tag jdk8-b106 for changeset 2e3a056c84a7

2013-09-10 Thread david . katleman
Changeset: 23fc34133152 Author:cl Date: 2013-09-05 02:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/23fc34133152 Added tag jdk8-b106 for changeset 2e3a056c84a7 ! .hgtags

hg: jdk8/build/jaxp: Added tag jdk8-b106 for changeset d3be8e3b429d

2013-09-10 Thread david . katleman
Changeset: d6a32e3831aa Author:cl Date: 2013-09-05 02:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/d6a32e3831aa Added tag jdk8-b106 for changeset d3be8e3b429d ! .hgtags

hg: jdk8/build/hotspot: 58 new changesets

2013-09-10 Thread david . katleman
Changeset: 3f4392035ec7 Author:cl Date: 2013-09-05 02:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3f4392035ec7 Added tag jdk8-b106 for changeset aed585cafc0d ! .hgtags Changeset: c169f7038414 Author:amurillo Date: 2013-08-30 00:29 -0700 URL:

hg: jdk8/build/jaxws: Added tag jdk8-b106 for changeset 6908370afe83

2013-09-10 Thread david . katleman
Changeset: e3c9328f7563 Author:cl Date: 2013-09-05 02:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/e3c9328f7563 Added tag jdk8-b106 for changeset 6908370afe83 ! .hgtags

hg: jdk8/build/jdk: 2 new changesets

2013-09-10 Thread david . katleman
Changeset: aafc0f332658 Author:cl Date: 2013-09-05 02:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/aafc0f332658 Added tag jdk8-b106 for changeset c817276bd870 ! .hgtags Changeset: eea685b9ccaa Author:amurillo Date: 2013-09-10 05:46 -0700 URL:

hg: jdk8/build/langtools: Added tag jdk8-b106 for changeset fcd768844b99

2013-09-10 Thread david . katleman
Changeset: 3f274927ec18 Author:cl Date: 2013-09-05 02:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/3f274927ec18 Added tag jdk8-b106 for changeset fcd768844b99 ! .hgtags

hg: jdk8/build/nashorn: Added tag jdk8-b106 for changeset bf70cbd2c836

2013-09-10 Thread david . katleman
Changeset: f35e1255024b Author:cl Date: 2013-09-05 02:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/f35e1255024b Added tag jdk8-b106 for changeset bf70cbd2c836 ! .hgtags

Re: RFR: Changes to disable and/or remove Solaris 32-bit from JDK8

2013-09-10 Thread Kumar Srinivasan
Here are the updated changes: The build changes are here: http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/ the delta changes since last reviewed: http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/webrev.delta/index.html The jdk changes are here:

Re: RFR: Changes to disable and/or remove Solaris 32-bit from JDK8

2013-09-10 Thread David Holmes
On 11/09/2013 8:00 AM, Kumar Srinivasan wrote: Here are the updated changes: Looks okay to me. David The build changes are here: http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/ the delta changes since last reviewed:

Re: How to add options to the javac build in the JDK 8 repo?

2013-09-10 Thread David Holmes
Hi Joe, I assume these lint settings will cause the build to fail if someone introduces a new warning. I'm concerned that build breakage could easily be introduced. If that happens is there a simple command-line make flag we can specify to turn this off? Thanks, David On 11/09/2013 1:02

Re: How to add options to the javac build in the JDK 8 repo?

2013-09-10 Thread Joe Darcy
Hi David, On 9/10/2013 8:31 PM, David Holmes wrote: Hi Joe, I assume these lint settings will cause the build to fail if someone introduces a new warning. That is the point actually :-) I'm concerned that build breakage could easily be introduced. If that happens is there a simple