code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

2013-09-20 Thread Daniel D. Daugherty
Greetings, I have the initial support for Full Debug Symbols (FDS) on MacOS X done and ready for review: 7165611 implement Full Debug Symbols on MacOS X hotspot https://bugs.openjdk.java.net/browse/JDK-7165611 Here is the JDK8/HSX-25 webrev URL: OpenJDK: http://cr.openjdk.java.net/~dc

Re: RFR (L) JDK-7195622: CheckUnhandledOops has limited usefulness now

2013-09-20 Thread Lois Foltan
On 9/20/2013 9:16 AM, Stefan Karlsson wrote: On 09/20/2013 02:46 PM, Stefan Karlsson wrote: On 09/19/2013 05:13 PM, Lois Foltan wrote: Please review the following fix: Webrev: http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/ The changes looks good. I forgot this rather benign bu

Re: RFR (L) JDK-7195622: CheckUnhandledOops has limited usefulness now

2013-09-20 Thread Stefan Karlsson
On 09/20/2013 02:46 PM, Stefan Karlsson wrote: On 09/19/2013 05:13 PM, Lois Foltan wrote: Please review the following fix: Webrev: http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/ The changes looks good. I forgot this rather benign bug: http://cr.openjdk.java.net/~hseigel/bug_jdk

Re: RFR (L) JDK-7195622: CheckUnhandledOops has limited usefulness now

2013-09-20 Thread Stefan Karlsson
On 09/19/2013 05:13 PM, Lois Foltan wrote: Please review the following fix: Webrev: http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/ The changes looks good. There are some changes that I don't fully agree with, but I will not block the push because of them. I'm just going to mentio

Re: RFR (L) JDK-7195622: CheckUnhandledOops has limited usefulness now

2013-09-20 Thread Lois Foltan
On 9/19/2013 9:34 PM, Christian Thalinger wrote: On Sep 19, 2013, at 6:06 PM, Lois Foltan > wrote: On 9/19/2013 7:25 PM, Christian Thalinger wrote: On Sep 19, 2013, at 4:22 PM, Lois Foltan wrote: On 9/19/2013 6:27 PM, Christian Thalinger wrote: On Sep 19,

Re: Heads-up, anyone who keeps their Mac software up-to-date

2013-09-20 Thread Staffan Larsen
On 19 sep 2013, at 16:25, David Chase wrote: > 1. Have a copy of XCode 4.6.3 on backup (I think it might fit on a DVD, just > to be extra careful). You can download it from https://developer.apple.com/ if you've lost it. /Staffan

Re: RFR (L) JDK-7195622: CheckUnhandledOops has limited usefulness now

2013-09-20 Thread Magnus Ihse Bursie
On 2013-09-19 16:37, Lois Foltan wrote: Please review the following fix: Webrev: http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/ The build changes part of the fix looks unproblematic. (I have not looked at the rest.) /Magnus