Re: RFR: 8026062 : (s) webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug" and wxfile support

2013-10-10 Thread Vadim Pakhnushev
You probably either supply a list file as a parameter, or pipe with '-' as a parameter. At least file name as a parameter works for me, haven't tried '-' with pipe. Thanks, Vadim On 11.10.2013 4:20, Weijun Wang wrote: On 10/10/13 1:13 PM, Mike Duigou wrote: On Oct 9 2013, at 22:11 , Weijun

Re: RFR: 8026062 : (s) webrev.ksh: fix bug title web scraping, remove teamware, sac, "open bug" and wxfile support

2013-10-10 Thread Weijun Wang
On 10/10/13 1:13 PM, Mike Duigou wrote: On Oct 9 2013, at 22:11 , Weijun Wang wrote: Some of us still use wxfile to generate a single webrev for code changes in multiple repos. Is there another way to do it? Yes, you can pipe a simple file list to webrev to have it use that list of files

Re: JDK7u40: build issue with a french VS2010 Express

2013-10-10 Thread Ludovic HOCHET
Hello, Coming back to this: "But that does not work neither because when one download VS2010 Express from a French territory, one gets the French version EVEN if the English version was explicitly requested (I made it twice, thinking I missed to select the English version)." Sadly I see the same. I

Re: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access

2013-10-10 Thread Tim Bell
On 10/10/13 10:45 AM, Sean Mullan wrote: On 10/10/2013 05:57 AM, Erik Joelsson wrote: Adding makefiles to make/tools is not needed for the new build. Either remove those changes or make a complete port to the old build. I'm not pushing for porting this to the old build at this point since missin

Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac

2013-10-10 Thread Tim Bell
On 10/10/13 04:12 AM, Magnus Ihse Bursie wrote: On 2013-10-10 12:10, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The exist

Re: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access

2013-10-10 Thread Sean Mullan
On 10/10/2013 05:57 AM, Erik Joelsson wrote: Adding makefiles to make/tools is not needed for the new build. Either remove those changes or make a complete port to the old build. I'm not pushing for porting this to the old build at this point since missing this will not cause the old build to sto

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

2013-10-10 Thread Daniel D. Daugherty
Thanks for confirmation. Dan On 10/10/13 3:09 AM, David Holmes wrote: I'm fine with not adding untestable minimal VM support. Thanks, David On 10/10/2013 1:03 AM, Daniel D. Daugherty wrote: Replies also inline... On 10/9/13 6:02 AM, David Holmes wrote: inline ... On 9/10/2013 8:59 AM, D

Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac

2013-10-10 Thread Magnus Ihse Bursie
On 2013-10-10 12:10, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_sctp tests cover this. http://cr.openjdk

hg: jdk8/build: 8023611: Win32 and win64: Remove all the WARNINGS in JDK 8 builds for Windows 2008 and MSVS 2010 SP1

2013-10-10 Thread tim . bell
Changeset: ec48d637778a Author:tbell Date: 2013-10-09 18:51 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/ec48d637778a 8023611: Win32 and win64: Remove all the WARNINGS in JDK 8 builds for Windows 2008 and MSVS 2010 SP1 Reviewed-by: erikj ! common/autoconf/generated-configu

Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac

2013-10-10 Thread Michael McMahon
On 10/10/13 12:01, Alan Bateman wrote: On 10/10/2013 11:10, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_s

Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac

2013-10-10 Thread Alan Bateman
On 10/10/2013 11:10, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_sctp tests cover this. http://cr.openjdk

hg: jdk8/build/jdk: 2 new changesets

2013-10-10 Thread tim . bell
Changeset: 86df2e879eca Author:tbell Date: 2013-10-09 18:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/86df2e879eca 8023611: Win32 and win64: Remove all the WARNINGS in JDK 8 builds for Windows 2008 and MSVS 2010 SP1 Reviewed-by: erikj ! make/common/shared/Compiler-m

Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac

2013-10-10 Thread Chris Hegarty
Thank you for doing this Michael. The changes look good to me, but someone from the build group should cast an eye on the makefile changes. -Chris. On 10/10/2013 11:10 AM, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable c

RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac

2013-10-10 Thread Michael McMahon
Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_sctp tests cover this. http://cr.openjdk.java.net/~michaelm/7076487/webrev.1/ Thanks

Re: RFR: 8026144: Missing mkdir in Images.gmk

2013-10-10 Thread Magnus Ihse Bursie
On 2013-10-10 10:45, Volker Simonis wrote: I just want to add that parallel "mkdir -p " commands can fail on AIX if is on an NFS share. While knowing that AIX is not one of the main OpenJDK platforms I would nevertheless prefer the conceptually cleaner way of having a separate rule for the path

Re: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access

2013-10-10 Thread Erik Joelsson
Adding makefiles to make/tools is not needed for the new build. Either remove those changes or make a complete port to the old build. I'm not pushing for porting this to the old build at this point since missing this will not cause the old build to stop working, it will just diverge the resulti

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

2013-10-10 Thread David Holmes
I'm fine with not adding untestable minimal VM support. Thanks, David On 10/10/2013 1:03 AM, Daniel D. Daugherty wrote: Replies also inline... On 10/9/13 6:02 AM, David Holmes wrote: inline ... On 9/10/2013 8:59 AM, Daniel D. Daugherty wrote: On 10/1/13 8:52 PM, David Holmes wrote: - hots

Re: Trivial RFR: 8026232: Move libnpt from profile compact1 to compact3

2013-10-10 Thread David Holmes
Thanks Alan and Mandy. David On 10/10/2013 5:48 PM, Alan Bateman wrote: On 10/10/2013 01:47, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/8026232/webrev/ libnpt.so is used for debugging and profiling but was mistakenly placed in profile compact1. It should be in compact3 a

Re: RFR: 8026144: Missing mkdir in Images.gmk

2013-10-10 Thread Volker Simonis
On Thu, Oct 10, 2013 at 10:08 AM, Erik Joelsson wrote: > > On 2013-10-10 03:02, David Holmes wrote: > >> On 9/10/2013 11:30 PM, Erik Joelsson wrote: >> >>> I just hit this race when building in jprt. Adding the standard mkdir -p >>> lines should fix it. >>> >>> https://bugs.openjdk.java.net/**brow

Re: RFR: 8026144: Missing mkdir in Images.gmk

2013-10-10 Thread Erik Joelsson
On 2013-10-10 03:02, David Holmes wrote: On 9/10/2013 11:30 PM, Erik Joelsson wrote: I just hit this race when building in jprt. Adding the standard mkdir -p lines should fix it. https://bugs.openjdk.java.net/browse/JDK-8026144 http://cr.openjdk.java.net/~erikj/8026144/webrev.jdk.01/ Hmmm.

Re: Trivial RFR: 8026232: Move libnpt from profile compact1 to compact3

2013-10-10 Thread Alan Bateman
On 10/10/2013 01:47, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/8026232/webrev/ libnpt.so is used for debugging and profiling but was mistakenly placed in profile compact1. It should be in compact3 along with the hprof agent that uses it (other users are in full JRE).

Re: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access

2013-10-10 Thread Magnus Ihse Bursie
On 2013-10-09 15:20, Sean Mullan wrote: Finally do we still use make/tools/Makefile in the new build? No, we don't. If you want to add old build support for this, you would also need to add usage of the tool to the correct old makefile. I don't think it's necessary to add this to the old bu