The webrev shows """ inside the "Bug id" header entry.
Also, the following headers look a little suspicious:
Compare against: ssh://hg.openjdk.java.net/jdk8/tl-gate
Compare against version: -2
I usually compare with -2 when -1 is an mq patch and I also have "-N".
But the "compare against
On Oct 11 2013, at 14:56 , Bradford Wetmore wrote:
> It never worked like it did in Teamware.
Thanks Brad, that's what I thought reading the source. It appeared that it had
never been implemented for mercurial. I have removed support for -l
Here's an updated webrev (generated with itself!):
h
It never worked like it did in Teamware.
Brad
On 10/11/2013 11:33 AM, Mike Duigou wrote:
I should also ask if anyone is using the -l option. I would like to delete it
as well as it offers no particular value for mercurial (that I can tell).
Mike
On Oct 10 2013, at 17:20 , Weijun Wang wrote:
Brad,
Thank you for greet idea. sjavac might be a culprit.
-Dmitry
On 2013-10-11 22:23, Bradford Wetmore wrote:
> Offhand, no idea. Instance lives in sun.security.getInstance, and
> you're finding that class. I haven't tried out sjavac, but given the
> warning build/linux-x86-normal-server-re
Greetings,
I'm ready for code review round 1 of the FDS on MacOS X hotspot changes.
Below is the original code review round 0 invite (slightly edited for
clarity). Working on FDS is like pulling a thread on a sweater... so
there are four additional changed files along with more changes to
many of
Staffan,
Closing the loop on this comment from code review round 0.
I did this:
$ sh ./configure --with-debug-level=slowdebug --disable-zip-debug-info
$ make
with the latest version that I'm about to send out for code review
round 1. And I see this:
$ find build -name '*.dSYM' -print
I should also ask if anyone is using the -l option. I would like to delete it
as well as it offers no particular value for mercurial (that I can tell).
Mike
On Oct 10 2013, at 17:20 , Weijun Wang wrote:
>
>
> On 10/10/13 1:13 PM, Mike Duigou wrote:
>>
>> On Oct 9 2013, at 22:11 , Weijun Wang
Offhand, no idea. Instance lives in sun.security.getInstance, and
you're finding that class. I haven't tried out sjavac, but given the
warning build/linux-x86-normal-server-release/jdk/classes/javac_state,
and that I've never seen this directory, might you be triggering a
sjavac bug?
If you
Bug: https://bugs.openjdk.java.net/browse/JDK-8001933
In the makefiles directory in the jdk repo, there are a lot of files --
important files, and lot of small helper files. Many of them share a
common filename prefix; however, there is a better kind of namespaces to
show hierarchy in file sys
As the submitter, I also agree with this part of the fix and all
comments made here. ;)
Erik, one thing I did not check is whether other .jars in j2re/j2sdk use
a different manifest template than the one you modified. Have you
checked them all?
You do not need to check these .jars, they wil
On 10/11/2013 4:15 AM, David Holmes wrote:
On 11/10/2013 9:02 PM, Alan Bateman wrote:
Looks good. At some point it would be great to have a page somewhere
with the list of things that need to be updated when we move major
versions. There always seems to be something that only remember late in
t
Changeset: acae2e8a46df
Author:ihse
Date: 2013-10-10 14:58 +0200
URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/acae2e8a46df
8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
! makefiles/BuildJaxp.gmk
! makefiles/Makefile
Changeset: 343aeb2033f0
Author:ihse
Date: 2013-10-10 14:58 +0200
URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/343aeb2033f0
8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
! makefiles/BuildLangtools.gmk
! makefiles/Makefile
Changeset: 45399f3ef717
Author:ihse
Date: 2013-10-10 14:58 +0200
URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/45399f3ef717
8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
! makefiles/BuildNashorn.gmk
! makefiles/Makefile
Changeset: 9c60860b1812
Author:ihse
Date: 2013-10-10 15:06 +0200
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9c60860b1812
8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
! makefiles/BuildJdk.gmk
! makefiles/Bundles.gmk
! makefiles/CompileD
Changeset: 602fdd7bb765
Author:ihse
Date: 2013-10-10 14:58 +0200
URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/602fdd7bb765
8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
! makefiles/BuildJaxws.gmk
! makefiles/Makefile
Changeset: 66fc1a749867
Author:ihse
Date: 2013-10-10 14:58 +0200
URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/66fc1a749867
8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
! makefiles/BuildCorba.gmk
! makefiles/Makefile
Changeset: 174a54ce39c4
Author:ihse
Date: 2013-10-10 14:58 +0200
URL: http://hg.openjdk.java.net/jdk8/build/rev/174a54ce39c4
8001931: The new build system whitespace cleanup
Reviewed-by: tbell, simonis, erikj
! NewMakefile.gmk
! common/autoconf/autogen.sh
! common/autoconf/basics.m
Erik:
Please review this small change, updating the specification version in the
manifest of the jar files. Posted diff inline since it's so small. I couldn't
find anywhere else where this would need changing, but if anyone knows of
somewhere, please speak up.
/Erik
diff -r 98d98ec01f07 mak
Hi Everyone,
I get weird error trying to compile latest hotspot-rt on linux-x86,
I suspect something is wrong wit my machine setup, because the same
workspace on linux-x64 compiles fine.
Any idea what is happening?
## Starting jdk
Compiling BUILD_JDK
Note: Some input files use or override a de
On 11/10/2013 9:02 PM, Alan Bateman wrote:
Looks good. At some point it would be great to have a page somewhere
with the list of things that need to be updated when we move major
versions. There always seems to be something that only remember late in
the release.
+1 to both of those. Somehow t
Looks good. At some point it would be great to have a page somewhere
with the list of things that need to be updated when we move major
versions. There always seems to be something that only remember late in
the release.
-Alan
On 11/10/2013 11:50, Erik Joelsson wrote:
Please review this sm
Please review this small change, updating the specification version in the
manifest of the jar files. Posted diff inline since it's so small. I couldn't
find anywhere else where this would need changing, but if anyone knows of
somewhere, please speak up.
/Erik
diff -r 98d98ec01f07 make/tools/m
On 2013-10-10 19:45, Sean Mullan wrote:
On 10/10/2013 05:57 AM, Erik Joelsson wrote:
Adding makefiles to make/tools is not needed for the new build. Either
remove those changes or make a complete port to the old build. I'm not
pushing for porting this to the old build at this point since missin
Yes, both works. Thanks.
--Max
On 10/11/13 2:56 PM, Vadim Pakhnushev wrote:
You probably either supply a list file as a parameter, or pipe with '-'
as a parameter.
At least file name as a parameter works for me, haven't tried '-' with
pipe.
Thanks,
Vadim
On 11.10.2013 4:20, Weijun Wang wrote:
25 matches
Mail list logo
