On 16/10/2013 10:02 AM, David Holmes wrote:
Hi Erik,
Many thanks for jumping on this!
On 16/10/2013 12:30 AM, Erik Joelsson wrote:
Currently the RMI stubs in the jdk are built with the newly built rmic
binary at the end of the build. This patch changes that and instead
builds a bootstrap versi
Hi Volker,
On 16/10/2013 1:29 AM, Volker Simonis wrote:
Hi Erik, Alan,
first of all I think this is a good change because it helps porters to
build a complete JDK even if the newly build rmic wouldn't run.
On the other hand I'm a little bit concerned if this change still
allows it to bootstrap
On 16/10/2013 12:40 AM, Alan Bateman wrote:
On 15/10/2013 15:30, Erik Joelsson wrote:
Currently the RMI stubs in the jdk are built with the newly built rmic
binary at the end of the build. This patch changes that and instead
builds a bootstrap version of the rmic classes, much like bootstrap
jav
Hi Erik,
Many thanks for jumping on this!
On 16/10/2013 12:30 AM, Erik Joelsson wrote:
Currently the RMI stubs in the jdk are built with the newly built rmic
binary at the end of the build. This patch changes that and instead
builds a bootstrap version of the rmic classes, much like bootstrap
j
Erik,
There is already a fix in-flight for this under 8019540 by Erik Joelsson.
http://mail.openjdk.java.net/pipermail/build-dev/2013-October/010584.html
David
On 16/10/2013 1:06 AM, Erik Gahlin wrote:
Hi,
Could you please review this fix for licensee source bundle. This is a
forward port of
On 10/15/13 03:23 PM, Mandy Chung wrote:
On 10/15/2013 11:16 AM, Kumar Srinivasan wrote:
Hello,
Please review the removal of extraneous docs (specifically javaws.1)
no longer need for
Solaris.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8026500
Webrev:
http://cr.openjdk.java.net/~ksrini/8
On 10/15/2013 11:16 AM, Kumar Srinivasan wrote:
Hello,
Please review the removal of extraneous docs (specifically javaws.1)
no longer need for
Solaris.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8026500
Webrev:
http://cr.openjdk.java.net/~ksrini/8026500/webrev/
Looks okay to me.
Mandy
On 10/15/2013 11:51 AM, Tim Bell wrote:
On 10/15/13 10:26 AM, Kumar Srinivasan wrote:
That's it ? This works ? I tried this earlier but it did not work for
me, though
the jprt build completed the tests would stall, maybe I missed
something.
Not quite. There was also a bit of fiddling on the
On 10/15/13 10:26 AM, Kumar Srinivasan wrote:
That's it ? This works ? I tried this earlier but it did not work for
me, though
the jprt build completed the tests would stall, maybe I missed something.
Not quite. There was also a bit of fiddling on the JPRT controller side
in a file called sr
Hello,
Please review the removal of extraneous docs (specifically javaws.1) no
longer need for
Solaris.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8026500
Webrev:
http://cr.openjdk.java.net/~ksrini/8026500/webrev/
Thanks
Kumar
Hi Tim,
I looked at the changes, and it seems to be ok.
That's it ? This works ? I tried this earlier but it did not work for
me, though
the jprt build completed the tests would stall, maybe I missed something.
Thanks
Kumar
Hello
This is a piece of followup work to JDK-8023288 "Remove Sol
Hello
This is a piece of followup work to JDK-8023288 "Remove Solaris 32-bit
from JDK8"
The Solaris 32-bit hotspot build and test targets need to be removed
from the hotspot/make/jprt.properties file so JPRT (our internal
build/test system) will stop trying to build and test them.
The bug
Hi Erik, Alan,
first of all I think this is a good change because it helps porters to
build a complete JDK even if the newly build rmic wouldn't run.
On the other hand I'm a little bit concerned if this change still
allows it to bootstrap with a non-Oracle based bootstrap JDK. I
remember that we
On 10/15/13 8:50 AM, Daniel D. Daugherty wrote:
On 10/15/13 6:21 AM, Magnus Ihse Bursie wrote:
On 2013-10-11 22:27, Daniel D. Daugherty wrote:
Greetings,
I'm ready for code review round 1 of the FDS on MacOS X hotspot
changes.
Below is the original code review round 0 invite (slightly edite
Hi,
Could you please review this fix for licensee source bundle. This is a
forward port of:
https://bugs.openjdk.java.net/browse/JDK-8001697
I removed:
ifndef OPENJDK
ifndef JAVASE_EMBEDDED
and only check for BUILD_JFR. Not sure if it is correct? I tried to
build with:
make newbuild=true
On 2013-10-15 16:40, Alan Bateman wrote:
On 15/10/2013 15:30, Erik Joelsson wrote:
Currently the RMI stubs in the jdk are built with the newly built
rmic binary at the end of the build. This patch changes that and
instead builds a bootstrap version of the rmic classes, much like
bootstrap jav
On 10/15/13 6:21 AM, Magnus Ihse Bursie wrote:
On 2013-10-11 22:27, Daniel D. Daugherty wrote:
Greetings,
I'm ready for code review round 1 of the FDS on MacOS X hotspot changes.
Below is the original code review round 0 invite (slightly edited for
clarity). Working on FDS is like pulling a thr
Thanks!
Dan
On 10/15/13 3:33 AM, Erik Joelsson wrote:
Daniel,
Looks good to me.
/Erik
On 2013-10-14 17:52, Daniel D. Daugherty wrote:
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change that correspond
Nothing like a willing victim^H^H^H^H^H^Htest user of your changes!
Thanks!
Dan
On 10/15/13 12:30 AM, Staffan Larsen wrote:
I've been using this patch while debugging other issues and I now get full
symbols in the debugger without a lot of manual work. So it's a go!
Thanks,
/Staffan
On 11
On 15/10/2013 15:30, Erik Joelsson wrote:
Currently the RMI stubs in the jdk are built with the newly built rmic
binary at the end of the build. This patch changes that and instead
builds a bootstrap version of the rmic classes, much like bootstrap
javac in langtools, which runs on the bootjdk,
On 10/15/13 12:07 AM, David Holmes wrote:
On 15/10/2013 1:18 AM, Daniel D. Daugherty wrote:
Thanks for the re-review!
On 10/13/13 7:57 PM, David Holmes wrote:
Hi Dan,
Only further comment I have, and it may well be deferred for future
work, is that we should be able to abstract away the actu
On 10/15/13 12:05 AM, David Holmes wrote:
On 15/10/2013 1:52 AM, Daniel D. Daugherty wrote:
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change that corresponds
to the DSYMUTIL configure change ??
Yikes!
Currently the RMI stubs in the jdk are built with the newly built rmic
binary at the end of the build. This patch changes that and instead
builds a bootstrap version of the rmic classes, much like bootstrap
javac in langtools, which runs on the bootjdk, but generates classes for
the new jdk. Th
On 2013-10-11 22:27, Daniel D. Daugherty wrote:
Greetings,
I'm ready for code review round 1 of the FDS on MacOS X hotspot changes.
Below is the original code review round 0 invite (slightly edited for
clarity). Working on FDS is like pulling a thread on a sweater... so
there are four additional
On 2013-10-14 11:25, Erik Joelsson wrote:
Please review the following changes, correcting the conditions for
when to build certain parts of the servicability features. Instead of
guarding them with the OPENJDK variable, they need to be conditioned
on the existence of the source itself.
In hot
I like the split and think this looks good.
/Erik
On 2013-10-15 10:57, Magnus Ihse Bursie wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8025715
The file CompileNativeLibraries.gmk is by far the longest (roughly 150
kB) and most unstructured file in the new build system. It ended up
be
Daniel,
Looks good to me.
/Erik
On 2013-10-14 17:52, Daniel D. Daugherty wrote:
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change that corresponds
to the DSYMUTIL configure change ??
Yikes! I'll check
Bug: https://bugs.openjdk.java.net/browse/JDK-8025715
The file CompileNativeLibraries.gmk is by far the longest (roughly 150
kB) and most unstructured file in the new build system. It ended up
being the "default" place to put make logif for all native libraries in
the JDK during the conversion
On 14/10/2013 7:25 PM, Erik Joelsson wrote:
Please review the following changes, correcting the conditions for when
to build certain parts of the servicability features. Instead of
guarding them with the OPENJDK variable, they need to be conditioned on
the existence of the source itself.
In hots
29 matches
Mail list logo
