Ah, ok. I'll pull it in from there then. Thanks!
-DrD-
> This is probably due to the fact that I wanted to let mercurial keep track of
> the origin of the new files, so they were all created by hg cp. Maybe WebRev
> doesn't handle that situation very well.
>
> However, this is pushed to the b
This is probably due to the fact that I wanted to let mercurial keep track of
the origin of the new files, so they were all created by hg cp. Maybe WebRev
doesn't handle that situation very well.
However, this is pushed to the build forest now, so you can extract a proper
patch from mercurial i
> Bug: https://bugs.openjdk.java.net/browse/JDK-8025715
> WebRev:
> http://cr.openjdk.java.net/~ihse/JDK-8025715-split-CompileNativeLibraries/webrev.01
The patch looks backwards... I see a bunch of:
--- old/makefiles/CompileNativeLibraries.gmk
+++ /dev/null
entries and none of the new filena
On 2013-10-17 17:50, Erik Joelsson wrote:
Please review this simple patch extending the recognized make versions
in configure to 4.0, which was recently released and is already
default in Cygwin. I also removed the version check in NewMakefile.gmk
since it seems redundant having already done it
+1
Kumar
On 10/17/2013 9:11 AM, Tim Bell wrote:
Hi Erik:
Please review this simple patch extending the recognized make
versions in configure to 4.0, which was recently released and is
already default in Cygwin. I also removed the version check in
NewMakefile.gmk since it seems redundant hav
Changeset: a5b57fca66da
Author:ihse
Date: 2013-10-16 20:24 +0200
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a5b57fca66da
8025715: Split CompileNativeLibraries.gmk
Reviewed-by: erikj
! makefiles/CompileNativeLibraries.gmk
+ makefiles/lib/Awt2dLibraries.gmk
+ makefiles/lib/Co
Hi Mike:
That's quite a makeover. Looks good to me.
Tim
Reminder:
http://cr.openjdk.java.net/~mduigou/JDK-8026062/2
needs final review.
Mike
On Oct 14 2013, at 11:56 , Mike Duigou wrote:
On Oct 11 2013, at 18:03 , Weijun Wang wrote:
The webrev shows """ inside the "Bug id" header ent
Hi Erik:
Please review this simple patch extending the recognized make versions
in configure to 4.0, which was recently released and is already
default in Cygwin. I also removed the version check in NewMakefile.gmk
since it seems redundant having already done it in configure. They
were also n
Hi Erik:
Looks good to me.
/Tim
Would appreciate a review on this. Thanks!
/Erik
On 2013-10-03 15:36, Erik Joelsson wrote:
Please review this fix for SetupZipArchive. The dependency list ended
up empty if the SUFFIXES parameter wasn't set. This caused src.zip to
not get updated when source
Please review this simple patch extending the recognized make versions
in configure to 4.0, which was recently released and is already default
in Cygwin. I also removed the version check in NewMakefile.gmk since it
seems redundant having already done it in configure. They were also not
in sync.
Would appreciate a review on this. Thanks!
/Erik
On 2013-10-03 15:36, Erik Joelsson wrote:
Please review this fix for SetupZipArchive. The dependency list ended
up empty if the SUFFIXES parameter wasn't set. This caused src.zip to
not get updated when source files were changed.
http://cr.open
On 2013-10-16 20:09, Magnus Ihse Bursie wrote:
When testing with --with-msvcr-dll, it turned out that we do not
handle relative paths like ./myspeciallibs/msvcr100.dll correctly.
This fix also addresses this, by adding -a (rewrite as absolute path)
to all cygpath -u calls.
That late additiona
On 16/10/2013 21:22, Mike Duigou wrote:
Hello all;
With the imminent promotion of JTReg 4.1b07 it's possible to finally consider
completing this changeset!
http://cr.openjdk.java.net/~mduigou/JDK-8015068/2/webrev/
This updated webrev includes handling of the shared library permissions.
Thank
13 matches
Mail list logo
