Re: problem with zip.dll when building 7u

2013-11-07 Thread Pete Brunet
On 11/7/13 6:25 PM, David Holmes wrote: > Hi Peter, > > On 8/11/2013 7:15 AM, Pete Brunet wrote: >> This was when attempting to only build jdk, pointing at an import >> directory from 7u45. I tried again from the top and using the sanity >> target I am seeing a lot of ERRORs referring to componen

Re: Missing webrev features ( was Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed)

2013-11-07 Thread David Holmes
On 7/11/2013 11:26 PM, Magnus Ihse Bursie wrote: On 2013-11-06 03:01, Jonathan Gibbons wrote: Pwrhaps we should only have one copy of the webrev script around. ... and perhaps it should not be tied to a specific source branch. That has always seemed weird to me. I would suggest creating a cod

Re: problem with zip.dll when building 7u

2013-11-07 Thread David Holmes
Hi Peter, On 8/11/2013 7:15 AM, Pete Brunet wrote: This was when attempting to only build jdk, pointing at an import directory from 7u45. I tried again from the top and using the sanity target I am seeing a lot of ERRORs referring to components that I've never seen before in a jdk build, e.g. M

Re: error during jdk7-cpu build

2013-11-07 Thread David Holmes
Hi Mikhail, On 8/11/2013 8:00 AM, mikhail cherkasov wrote: Hi all, I have the following error: c:/jdk/jdk1.6.0_18/bin/java -XX:-PrintVMOptions -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -client -Xmx512m -Xms512m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:C:/ws/jdk7/jdk7u-cpu/

Review request for 8025985: com.sun.management.OSMBeanFactory should not be public

2013-11-07 Thread Mandy Chung
com.sun.management API is an exported API [1] except com.sun.management.OSMBeanFactory class which is an implementation-specific class and it's currently annotated as @jdk.Exported(false) [2]. This patch will eliminate one use of @jdk.Exported(false). This is simply refactoring of the existi

error during jdk7-cpu build

2013-11-07 Thread mikhail cherkasov
Hi all, I have the following error: c:/jdk/jdk1.6.0_18/bin/java -XX:-PrintVMOptions -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput -client -Xmx512m -Xms512m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:C:/ws/jdk7/jdk7u-cpu/build/windows-i586/langtools/dist/bootstrap/lib/javac.jar

Re: Missing webrev features ( was Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed)

2013-11-07 Thread Jonathan Gibbons
On 11/07/2013 05:26 AM, Magnus Ihse Bursie wrote: On 2013-11-06 03:01, Jonathan Gibbons wrote: Pwrhaps we should only have one copy of the webrev script around. ... and perhaps it should not be tied to a specific source branch. That has always seemed weird to me. I would suggest creating a

Re: problem with zip.dll when building 7u

2013-11-07 Thread Pete Brunet
This was when attempting to only build jdk, pointing at an import directory from 7u45. I tried again from the top and using the sanity target I am seeing a lot of ERRORs referring to components that I've never seen before in a jdk build, e.g. Mozilla headers, InstallShield, lzma. ERROR: You do no

problem with zip.dll when building 7u

2013-11-07 Thread Pete Brunet
I am getting the following error when trying to build 7u. I repulled and rebuilt but got the same error. Any ideas? -Pete INFO: ENABLE_FULL_DEBUG_SYMBOLS=1 INFO: ZIP_DEBUGINFO_FILES=1 make[4]: Entering directory `/cygdrive/c/Users/Pete/JDK7u/jdk7u-dev/jdk/make/com/sun/jmx' /usr/bin/mkdir -p ../

Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed

2013-11-07 Thread Tim Bell
Hi Magnus: On 2013-11-05 17:50, Mike Duigou wrote: Thanks for looking into this issue! I tried the patch and it worked correctly for me and the code looks good. I've been using only Major.Minor version numbering for recent updates. This fix seems worthy of being "25.1" Updated webrev wit

Re: Missing webrev features ( was Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed)

2013-11-07 Thread Magnus Ihse Bursie
On 2013-11-06 03:01, Jonathan Gibbons wrote: Pwrhaps we should only have one copy of the webrev script around. ... and perhaps it should not be tied to a specific source branch. That has always seemed weird to me. I would suggest creating a code-tools/webrev repository, and moving webrev.ks

Re: RFR: JDK-8027836 Webrev script breaks for files that has been moved from a directory which now is also removed

2013-11-07 Thread Magnus Ihse Bursie
On 2013-11-05 17:50, Mike Duigou wrote: Thanks for looking into this issue! I tried the patch and it worked correctly for me and the code looks good. I've been using only Major.Minor version numbering for recent updates. This fix seems worthy of being "25.1" Updated webrev with version 25.1:

hg: jdk8/build/jdk: 8027406: JDK demos are missing source files

2013-11-07 Thread erik . joelsson
Changeset: 295a641fc86b Author:erikj Date: 2013-11-07 14:06 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/295a641fc86b 8027406: JDK demos are missing source files Reviewed-by: alexsch, ihse ! makefiles/CompileDemos.gmk

Re: RFR: JDK-8027406 - JDK demos are missing source files

2013-11-07 Thread Magnus Ihse Bursie
On 2013-11-07 11:27, Erik Joelsson wrote: Sure, here it is: http://cr.openjdk.java.net/~erikj/8027406/webrev.jdk.01/ Looks good to me. /Magnus

Re: RFR: JDK-8027406 - JDK demos are missing source files

2013-11-07 Thread Erik Joelsson
On 2013-11-07 11:04, Alexander Scherbatiy wrote: On 11/6/2013 7:29 PM, Erik Joelsson wrote: On 2013-11-06 15:37, Alexander Scherbatiy wrote: On 11/6/2013 3:15 PM, Erik Joelsson wrote: Please review this minor fix for jdk demos MoleculeViewer and WireFrameTest. In JDK-8020060, these were chang

RFR: JDK-8027963: Create unlimited policy jars.

2013-11-07 Thread Erik Joelsson
Here is the next part of fixing things for the JCE team. With this patch, the build will always build both the limited and unlimited set of policy jars, just like the old build did. In an OPENJDK build, the configure option --enable-unlimited-crypto will still be used to choose which one gets i

Re: RFR: 8020779 & 8026988 : Improvements to JTReg executable location handling

2013-11-07 Thread Magnus Ihse Bursie
On 2013-11-06 21:40, Mike Duigou wrote: Hello all; With JDK-8015068 only very recently pushed it's time for the next set of jtreg test/Makfile changes. These changes improve the configure script detection of jtreg and improve the handling of the specification variables in the jdk and langtool

Re: RFR: JDK-8027406 - JDK demos are missing source files

2013-11-07 Thread Alexander Scherbatiy
On 11/6/2013 7:29 PM, Erik Joelsson wrote: On 2013-11-06 15:37, Alexander Scherbatiy wrote: On 11/6/2013 3:15 PM, Erik Joelsson wrote: Please review this minor fix for jdk demos MoleculeViewer and WireFrameTest. In JDK-8020060, these were changed to build differently. This had the side effect

hg: jdk8/build/jdk: 8027698: Platform specific jars are not being signed by the sign-jars target

2013-11-07 Thread erik . joelsson
Changeset: bdcba4854576 Author:erikj Date: 2013-11-07 10:51 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bdcba4854576 8027698: Platform specific jars are not being signed by the sign-jars target Reviewed-by: ihse, tbell, wetmore ! makefiles/SignJars.gmk

Re: RFR: 8020779 & 8026988 : Improvements to JTReg executable location handling

2013-11-07 Thread Mike Duigou
On Nov 7 2013, at 01:24 , Erik Joelsson wrote: > Hello Mike, > > I think this looks good. A couple of comments that don't necessarily call for > any changes. > > The version check is commented out, when is it planned to be activated? I was working on this piece at the same time as a the "mak

Re: RFR: 8020779 & 8026988 : Improvements to JTReg executable location handling

2013-11-07 Thread Erik Joelsson
Hello Mike, I think this looks good. A couple of comments that don't necessarily call for any changes. The version check is commented out, when is it planned to be activated? I see you use 'which' as a fallback in the makefiles. Just be aware that we have had some trouble using the which com

Re: Removal of the old build system, partial and preliminary review (part 2)

2013-11-07 Thread Magnus Ihse Bursie
On 2013-11-01 14:43, Magnus Ihse Bursie wrote: And here is the WebRev: http://cr.openjdk.java.net/~ihse/remove-old-build-part-2/webrev.01 It turned out that this webrev suffered from the same problems as the review in part 3, only it was not as obvious. I have created a new webrev, which now