On 11/08/2013 06:27 AM, Magnus Ihse Bursie wrote:
On 2013-11-08 14:46, Alan Bateman wrote:
On 08/11/2013 13:33, Magnus Ihse Bursie wrote:
I think there are both pros and cons by going through tl. As you
say, it will result in more testing. But it will also likely result
in a bunch of merge i
Good. I will test and push it.
Thanks,
Vladimir
On 11/8/13 9:37 AM, Volker Simonis wrote:
Hi,
this is a webrev which fixes the build on AIX again after the latest
jdk8/mainline version (including 8025715) was integrated into the
ppc-aix-port/stage repository:
http://cr.openjdk.java.net/~simon
Hi,
this is a webrev which fixes the build on AIX again after the latest
jdk8/mainline version (including 8025715) was integrated into the
ppc-aix-port/stage repository:
http://cr.openjdk.java.net/~simonis/webrevs/8028066
It actually redoes the changes from "8024265: PPC64: Enable new build
on A
Changeset: 43168d403243
Author:anthony
Date: 2013-11-08 20:07 +0400
URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/43168d403243
8027912: [macosx] Provide means to force the headful mode on OS X when running
via ssh
Summary: Bypass AquaSession check if AWT_FORCE_HEADFUL env. var
Hi Alex,
This looks good, and thanks for spotting this and fixing it.
Kumar
On 11/8/2013 6:57 AM, Alexander Zuev wrote:
Hello,
please review my fix for the issue JDK-8027900: pack200 option is
broken due to the incorrect makefile definition for its driver
The problem is that in the def
On 11/08/2013 12:22 AM, Magnus Ihse Bursie wrote:
On 2013-11-07 22:39, Jonathan Gibbons wrote:
It's not clear to me whether you mean a new repository within the
standard existing code-tools project, or another repo in a JDK
forest, in a "common" subdirectory.
I meant a new repository within
Thanks you all for the review.
I'll rename AbstractOperatingSystemImpl before I push.
Mandy
On 11/8/2013 5:22 AM, Alan Bateman wrote:
On 08/11/2013 08:40, Jaroslav Bachorik wrote:
AbstractOperatingSystemImpl should be an abstract class as its name
already indicates.
Right, it probably shou
Hello,
please review my fix for the issue JDK-8027900: pack200 option is
broken due to the incorrect makefile definition for its driver
The problem is that in the definition of the pack200 native launcher
we added explicit option "--pack"
This is incorrect because:
1. this option is b
Hello,
please review my fix for the issue JDK-8027900: pack200 option is
broken due to the incorrect makefile definition for its driver
The problem is that in the definition of the pack200 native launcher
we added explicit option "--pack"
This is incorrect because:
1. this option is b
On 2013-11-08 14:46, Alan Bateman wrote:
On 08/11/2013 13:33, Magnus Ihse Bursie wrote:
I think there are both pros and cons by going through tl. As you say,
it will result in more testing. But it will also likely result in a
bunch of merge issues, since changes in the build system is likely
On 08/11/2013 13:33, Magnus Ihse Bursie wrote:
I think there are both pros and cons by going through tl. As you say,
it will result in more testing. But it will also likely result in a
bunch of merge issues, since changes in the build system is likely to
continue arrive in the build forest. I
On 2013-11-08 14:24, Alan Bateman wrote:
On 08/11/2013 11:40, Magnus Ihse Bursie wrote:
Yes. We have a preliminary approval from the release team, on the
condition that SQE does some amount of pre-integration testing. I've
just sent them the binaries, so hopefully it won't take too long.
Grea
On 2013-11-08 13:08, Magnus Ihse Bursie wrote:
For local_policy, when building unlimited crypto, the
default_US_export.policy seems to be included as well. On the other
hand, that seems to have been the case before your change as well.
However, this seems suspicious and I suspect that this is a
On 08/11/2013 11:40, Magnus Ihse Bursie wrote:
Yes. We have a preliminary approval from the release team, on the
condition that SQE does some amount of pre-integration testing. I've
just sent them the binaries, so hopefully it won't take too long.
Great! So are you still okay with the suggest
On 8/11/2013 7:48 PM, mikhail cherkasov wrote:
Hi David,
I'm trying to build jdk7u-cpu as I can see File.java hasn't been changed
for long time, so everyone should have the same error.
Also I attached a full log. May I have some mistake in environment
configuration?
If the file hasn't change
On 2013-11-08 12:29, Alan Bateman wrote:
On 08/11/2013 08:10, Magnus Ihse Bursie wrote:
:
We have verified, using the compare script, that the resulting build
bits do not differ from what was build before this patch was applied.
This comparison is still not finished for a few platforms, but w
On 2013-11-05 18:57, Bradford Wetmore wrote:
I personally find it very
impractical, especially with make adding a tab indent to each recipe
line already, and because we tend to use rather long and descriptive
variable names. I still try to keep lines reasonably short without
forcing breaks that j
On 2013-11-07 11:22, Erik Joelsson wrote:
Here is the next part of fixing things for the JCE team. With this
patch, the build will always build both the limited and unlimited set
of policy jars, just like the old build did. In an OPENJDK build, the
configure option --enable-unlimited-crypto wil
On 08/11/2013 08:10, Magnus Ihse Bursie wrote:
:
We have verified, using the compare script, that the resulting build
bits do not differ from what was build before this patch was applied.
This comparison is still not finished for a few platforms, but we have
tested the majority and found no r
Changeset: c1029b02ca87
Author:ihse
Date: 2013-11-08 09:36 +0100
URL: http://hg.openjdk.java.net/jdk8/build/rev/c1029b02ca87
8027836: Webrev should handle files that has been moved from a directory which
now is removed.
Reviewed-by: mduigou, tbell
! make/scripts/webrev.ksh
On 2013-11-08 01:19, David Holmes wrote:
On 7/11/2013 11:26 PM, Magnus Ihse Bursie wrote:
On 2013-11-06 03:01, Jonathan Gibbons wrote:
Pwrhaps we should only have one copy of the webrev script around.
... and perhaps it should not be tied to a specific source branch. That
has always seemed we
On 2013-11-08 00:40, Mandy Chung wrote:
com.sun.management API is an exported API [1] except
com.sun.management.OSMBeanFactory class which is an
implementation-specific class and it's currently annotated as
@jdk.Exported(false) [2]. This patch will eliminate one use of
@jdk.Exported(false).
On 2013-11-07 22:39, Jonathan Gibbons wrote:
It's not clear to me whether you mean a new repository within the
standard existing code-tools project, or another repo in a JDK forest,
in a "common" subdirectory.
I meant a new repository within the code-tools project, most reasonably
named htt
Reduced complexity in makefiles is always nice to see. Build part looks
good to me.
/Erik
On 2013-11-08 00:40, Mandy Chung wrote:
com.sun.management API is an exported API [1] except
com.sun.management.OSMBeanFactory class which is an
implementation-specific class and it's currently annotated
Bug: https://bugs.openjdk.java.net/browse/JDK-8027566
This is the aggregation of the three previous preliminary reviews posted.
Since there previous webrevs did not result in any suggestions of code
changes, the actual code is basically the same here as in the three
preliminary, with two excep
25 matches
Mail list logo
