Re: RFR(XS): JDK-8034176 Update mapfile for libjfr

2014-02-16 Thread Staffan Larsen
On 17 feb 2014, at 02:30, David Holmes wrote: > On 11/02/2014 10:01 PM, Staffan Larsen wrote: >> >> On 11 feb 2014, at 12:14, Erik Joelsson wrote: >> >>> Looks good, but I can't help but wonder why the mapfile for libjfr is in >>> the open. >> >> Yes, that is unfortunate. It used to be in c

Re: RFR: JDK-8034199 Add 'reconfigure' target for re-creating a configuration

2014-02-16 Thread David Holmes
On 12/02/2014 11:36 PM, Magnus Ihse Bursie wrote: Sometimes we need to re-run configure, due to changes in configure files. Make detects such changes and forces a new run of configure. If configure was run with a long command line, it's tricky to get this right again. However, this can be done a

Re: RFR: JDK-8030350 : (s) Enable additional compiler warnings for GCC

2014-02-16 Thread David Holmes
On 12/02/2014 5:42 AM, Mike Duigou wrote: Hello all; This is a final update to the previously reviewed changeset. I had to make one slight change in hotspot/src/os/bsd/vm/os_bsd.cpp to accommodate a problem which appeared since this process began. I'd say that's a bug in the checking logic.

Re: RFR(XS): JDK-8034176 Update mapfile for libjfr

2014-02-16 Thread David Holmes
On 11/02/2014 10:01 PM, Staffan Larsen wrote: On 11 feb 2014, at 12:14, Erik Joelsson wrote: Looks good, but I can't help but wonder why the mapfile for libjfr is in the open. Yes, that is unfortunate. It used to be in closed source in jdk7, but moved into open with the new build system.

Re: RFR: JDK-8034173: Move JavaApp.icns to proper place in make/data

2014-02-16 Thread David Holmes
Do you still want a platform directory to keep things isolated? David On 11/02/2014 7:41 PM, Erik Joelsson wrote: In an effort to bring some more order to the source, I have started moving files that are either data input for source generation, or source code for a gensrc tool, into a subdirect

Re: RFR: JDK-8034179: Clean up nio genConstants

2014-02-16 Thread David Holmes
Maybe too late but ... On 12/02/2014 7:55 PM, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/8034179/webrev.jdk.02/ * Moved into fs and ch subdirectories. * Cleaned up the logic in GensrcMisc.gmk Given you've moved stuff from src to make/src wouldn't it also make sense to