My understanding is that these changes are needed. From a build
perspective, while making complicated make logic even more complicated,
it's really not that bad imho. So OK from me.
/Erik
On 2014-02-17 17:39, Naoto Sato wrote:
Any other comments? If there is no strong opinion against pushing t
Peter,
Looks good to me.
/Erik
On 2014-02-18 05:22, Pete Brunet wrote:
Please review this change:
http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.00/
for this bug:
https://bugs.openjdk.java.net/browse/JDK-8032443
Some resource compiler defines are need so the JAB DLLs Properties shee
Please review this change:
http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.00/
for this bug:
https://bugs.openjdk.java.net/browse/JDK-8032443
Some resource compiler defines are need so the JAB DLLs Properties sheet
will have the proper information. This change fixes the names that are
di
This seems like it will be helpful.
On Feb 17 2014, at 05:55 , Magnus Ihse Bursie
wrote:
> One issue with configure currently is that it is a bit of a "all or nothing"
> solution. Either you pass, and then you can build anything in the product, or
> you do not pass (since some requirement is
+1
Naoto
On 2/17/2014 6:40 AM, Alan Bateman wrote:
On 17/02/2014 14:36, Erik Joelsson wrote:
Hello,
I found another data file that belongs in make/data.
Bug: https://bugs.openjdk.java.net/browse/JDK-8035067
Webrev: http://cr.openjdk.java.net/~erikj/8035067/webrev.jdk.01/
This looks okay to
Hi Erik
Looks good to me as well.
/Tim
On 02/17/14 07:06 AM, Magnus Ihse Bursie wrote:
Looks good to me.
/Magnus
On 17 feb 2014, at 15:36, Erik Joelsson wrote:
Hello,
I found another data file that belongs in make/data.
Bug: https://bugs.openjdk.java.net/browse/JDK-8035067
Webrev: htt
Any other comments? If there is no strong opinion against pushing this
change, I just want to push it to the repo.
Naoto
On 2/12/14, 4:43 PM, Naoto Sato wrote:
On 2/12/14, 4:07 PM, Masayoshi Okutsu wrote:
The problem in the bug report is that the currency symbol is taken from
the HOST locale
Looks good to me.
/Magnus
> On 17 feb 2014, at 15:36, Erik Joelsson wrote:
>
> Hello,
>
> I found another data file that belongs in make/data.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8035067
> Webrev: http://cr.openjdk.java.net/~erikj/8035067/webrev.jdk.01/
>
> /Erik
On 17/02/2014 14:36, Erik Joelsson wrote:
Hello,
I found another data file that belongs in make/data.
Bug: https://bugs.openjdk.java.net/browse/JDK-8035067
Webrev: http://cr.openjdk.java.net/~erikj/8035067/webrev.jdk.01/
This looks okay to me. Also cc'ing i18n-dev as this is where the
currency
Hello,
I found another data file that belongs in make/data.
Bug: https://bugs.openjdk.java.net/browse/JDK-8035067
Webrev: http://cr.openjdk.java.net/~erikj/8035067/webrev.jdk.01/
/Erik
On 2014-02-17 03:10, David Holmes wrote:
Presumably the right way to do this would be:
"make clean reconfigure ..."
otherwise you could get some kind of weird hybrid build. I'm not sure
that every change in spec.gmk, for example would force a recompile of
everything that depended on something
One issue with configure currently is that it is a bit of a "all or
nothing" solution. Either you pass, and then you can build anything in
the product, or you do not pass (since some requirement is missing) and
then you can build nothing -- not even parts of the build that does not
really requi
So far, we haven't had platform directories in make/data. I don't think
it's needed yet.
/Erik
On 2014-02-17 02:23, David Holmes wrote:
Do you still want a platform directory to keep things isolated?
David
On 11/02/2014 7:41 PM, Erik Joelsson wrote:
In an effort to bring some more order to
On 2014-02-17 03:10, David Holmes wrote:
On 12/02/2014 11:36 PM, Magnus Ihse Bursie wrote:
Sometimes we need to re-run configure, due to changes in configure
files. Make detects such changes and forces a new run of configure.
If configure was run with a long command line, it's tricky to get th
Hello David,
Actually no, that wouldn't fit the model we are aiming for. In make/src
we put source for build tools, that are only used during the build to
generate things for the product. In make/data we put data files that are
input to build tools. We leave template java files in the main sou
Looks good to me.
/Erik
On 2014-02-14 23:26, Mike Duigou wrote:
Hello all;
This is a small cleanup patch with provides better summary help output for
reconfigure and dry-run configurations.
http://cr.openjdk.java.net/~mduigou/JDK-8034979/0/webrev/
I do note that even though no configuration
At least to me this looks good, but better let Magnus and Andrew have
their say too.
/Erik
On 2014-02-14 18:27, Omair Majid wrote:
* Andrew Hughes [2014-02-13 23:59]:
As I said in the previous e-mail, the minimum I'd be happy with is if
the current patch was updated so settings weren't being
Hello,
The change looks good to me too.
Regarding indentation, for the rest of the JDK, we indent rules with
make ifeqs like this:
target: sources
<8 spaces>ifeq (something)
recipe line
<8 spaces>endif
Our reasoning is that it should still look like a recipe when glancing
over it quickly (s
18 matches
Mail list logo
