Re: RFR: JDK-8035725 Must keep microsoft VS_PATH on PATH after toolchain detection

2014-02-25 Thread Bradford Wetmore
On 2/25/2014 6:13 AM, Kumar Srinivasan wrote: Never mind it is indeed the same issue, I found the bug filed by Brad on this. Just FYI, this morning's push addressed my problem. Brad Thanks Kumar On 2/25/2014 6:11 AM, Kumar Srinivasan wrote: Hello Magnus, On our team CI server we are s

Re: RFR: Allow using a system-installed lcms2

2014-02-25 Thread Omair Majid
* Omair Majid [2014-02-21 10:50]: > * Andrew Hughes [2014-02-21 10:36]: > > > I think the "j2" convention is reasonable. > > > > This is where we disagree. I may have agreed if this was new, but we've been > > using libjavalcms.so for the lifetime of 7 and I see no reason to change > > this. >

Re: RFR: JDK-8035730 Configure fails in cygwin if current dir is in /home/user

2014-02-25 Thread Tim Bell
Hi Magnus: With the rewrite in JDK-8035495, we unfortunately lost the ability to run configure on Cygwin in the /home/ directory. (Since this is transcribed with cygpath to not begin with the usual /cygdrive/ prefix.) This fix restores that functionality. Bug: https://bugs.openjdk.java.net/b

Re: RFR: JDK-8035725 Must keep microsoft VS_PATH on PATH after toolchain detection

2014-02-25 Thread Kumar Srinivasan
Never mind it is indeed the same issue, I found the bug filed by Brad on this. Thanks Kumar On 2/25/2014 6:11 AM, Kumar Srinivasan wrote: Hello Magnus, On our team CI server we are seeing these failures on Windows, are they related to this fix ? Or is this something else ? Message snippet inl

Re: RFR: JDK-8035725 Must keep microsoft VS_PATH on PATH after toolchain detection

2014-02-25 Thread Kumar Srinivasan
Hello Magnus, On our team CI server we are seeing these failures on Windows, are they related to this fix ? Or is this something else ? Message snippet inlined below. Thanks Kumar checking Checking for install src... found checking for ant... /devtools/ant-1.7.1/bin/ant checking for JUnit... n

RFR: JDK-8035730 Configure fails in cygwin if current dir is in /home/user

2014-02-25 Thread Magnus Ihse Bursie
With the rewrite in JDK-8035495, we unfortunately lost the ability to run configure on Cygwin in the /home/ directory. (Since this is transcribed with cygpath to not begin with the usual /cygdrive/ prefix.) This fix restores that functionality. Bug: https://bugs.openjdk.java.net/browse/JDK-803

Re: RFR: JDK-8035725 Must keep microsoft VS_PATH on PATH after toolchain detection

2014-02-25 Thread Erik Joelsson
For some reason, Magnus' mail is not showing up in my reader, but I read it at: http://mail.openjdk.java.net/pipermail/build-dev/2014-February/011974.html Change looks good to me. /Erik

RFR: JDK-8035725 Must keep microsoft VS_PATH on PATH after toolchain detection

2014-02-25 Thread Magnus Ihse Bursie
After the toolchain rewrite, we could fail in various ways on Windows builds, e.g. like this: configure: Rewriting OBJDUMP to "/usr/bin/objdump" configure: error: Target CPU mismatch. We are building for x86 but CL is for "directory"; expected "80x86". configure exiting with result code 1 The