Re: How to trim some more fat OpenJDK 8

2014-02-27 Thread David Holmes
On 28/02/2014 5:25 AM, Medi Montaseri wrote: Thanks David, That helped...but unfortunately not clear clear yetalmost there - I don't understand your comment stated as build "images" target -> images/j2re-image vs. images/j2sd-image the word build is both a directory and a verb. target is

Re: JDK-8035944: Build failed wilth configure option --disable-debuginfo-files

2014-02-27 Thread David Holmes
I have closed the bug as "Not an issue". David On 28/02/2014 1:51 AM, Magnus Ihse Bursie wrote: You are building hotspot using the experimental new build in build-infra. It is known not to work. Please use a proper forest instead, e.g jdk8/jdk8 for the JDK 8 master. /Magnus 27 feb 2014 kl.

Re: [OpenJDK 2D-Dev] RFR: JDK-8035821: Move psfont properties files from src/share/classes to src/share/lib

2014-02-27 Thread Phil Race
Hi, Leaving aside jigsaw, and regardless of whether they are modifiable, the question as to whether at runtime they should live in rt.jar or jre/lib is a separate question than where they would live in the source tree and one does not necessarily follow the other. You seem to be touching on the

Re: [OpenJDK 2D-Dev] RFR: JDK-8035821: Move psfont properties files from src/share/classes to src/share/lib

2014-02-27 Thread Mandy Chung
Hi Phil, Is psfont*.properties* file more of a resource file? Is there any reason (or specification) that psfont*.properties has to be in JRE/lib directory? One potential reason might be the startup performance (warm start/cold start) to avoid opening a jar file? They don't look like a user-

hg: jdk8/build/corba: 8035618: Four api/org_omg/CORBA TCK tests fail under plugin only

2014-02-27 Thread david . katleman
Changeset: 0683ee308085 Author:coffeys Date: 2014-02-26 23:04 + URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/0683ee308085 8035618: Four api/org_omg/CORBA TCK tests fail under plugin only Reviewed-by: mchung, chegar ! src/share/classes/com/sun/corba/se/spi/orb/ORB.java

Re: [OpenJDK 2D-Dev] RFR: JDK-8035821: Move psfont properties files from src/share/classes to src/share/lib

2014-02-27 Thread Phil Race
Magnus, I completely understand that the content of the files and the runtime behaviour aren't affected, but logically you'd want to put things together, not spread out across the source tree. Then its much easier for people to understand what uses what. If a jigsaw build somehow can't cope with

RE: How to trim some more fat OpenJDK 8

2014-02-27 Thread Medi Montaseri
Thanks David, That helped...but unfortunately not clear clear yetalmost there - I don't understand your comment stated as > build "images" target -> images/j2re-image vs. images/j2sd-image the word build is both a directory and a verb. target is a keyword in the world of make. arrow is some

Re: Request for approval of JDK-8032443: , Java Access Bridge version strings need to be fixed

2014-02-27 Thread Erik Joelsson
Looks good to me /Erik On 2014-02-27 14:19, Pete Brunet wrote: In response to the review from Magnus I updated the webrev to add the definition of JDK_FTYPE. Please re-review and re-approve. http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.01/ Pete

Re: JDK-8035944: Build failed wilth configure option --disable-debuginfo-files

2014-02-27 Thread Magnus Ihse Bursie
You are building hotspot using the experimental new build in build-infra. It is known not to work. Please use a proper forest instead, e.g jdk8/jdk8 for the JDK 8 master. /Magnus 27 feb 2014 kl. 14:24 skrev Yasumasa Suenaga : > Hi Erik, David, > > I used build-infra/jdk8 repository. > And c

Re: Request for approval of JDK-8032443: , Java Access Bridge version strings need to be fixed

2014-02-27 Thread Magnus Ihse Bursie
Looks good to me! /Magnus 27 feb 2014 kl. 14:19 skrev Pete Brunet : > In response to the review from Magnus I updated the webrev to add the > definition of JDK_FTYPE. Please re-review and re-approve. > http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.01/ > > Pete

Re: RFR: JDK-8035904: Solaris fastdebug builds are failing

2014-02-27 Thread Tim Bell
Hi Erik: JDK-8034199 unfortunately didn't work with a bunch of internal Solaris installations. It seems common for Solaris 10 to not have an updated bash version and the =~ construct used in that patch requires bash 3.x or higher. Here is a rewrite of that part using grep. Looks good to m

RFR: JDK-8035904: Solaris fastdebug builds are failing

2014-02-27 Thread Erik Joelsson
JDK-8034199 unfortunately didn't work with a bunch of internal Solaris installations. It seems common for Solaris 10 to not have an updated bash version and the =~ construct used in that patch requires bash 3.x or higher. Here is a rewrite of that part using grep. Bug: https://bugs.openjdk.ja

Re: JDK-8035944: Build failed wilth configure option --disable-debuginfo-files

2014-02-27 Thread Yasumasa Suenaga
Hi Erik, David, I used build-infra/jdk8 repository. And configure options is "--disable-zip-debug-info" . I tried to build jdk9/dev, it was succeeded with "--disable-zip-debug-info" . David says build-infra is still a work in progress. Should close this issue with "Won't Fix" ? Or should I p

Request for approval of JDK-8032443: ,Java Access Bridge version strings need to be fixed

2014-02-27 Thread Pete Brunet
In response to the review from Magnus I updated the webrev to add the definition of JDK_FTYPE. Please re-review and re-approve. http://cr.openjdk.java.net/~ptbrunet/JDK-8032443/webrev.01/ Pete

Re: JDK-8035944: Build failed wilth configure option --disable-debuginfo-files

2014-02-27 Thread David Holmes
Hi, First note that attachments get stripped so you can't send a patch as an attachment. Can you clarify what options you gave and in which forest please. I do not see a problem using --disable-debug-symbols nor --disable-zip-debug-info in JDK 8. David On 27/02/2014 10:40 PM, Yasumasa

Re: JDK-8035944: Build failed wilth configure option --disable-debuginfo-files

2014-02-27 Thread Erik Joelsson
Adding hotspot-dev as this is a hotspot fix /Erik On 2014-02-27 13:48, Yasumasa Suenaga wrote: Sorry, I forgot to upload webrev. http://cr.openjdk.java.net/~ysuenaga/JDK-8035944/webrev.00/ Please review and sponsoring! Yasumasa On 02/27/2014 09:40 PM, Yasumasa Suenaga wrote: Hi all, I tr

Re: JDK-8035944: Build failed wilth configure option --disable-debuginfo-files

2014-02-27 Thread David Holmes
On 27/02/2014 10:48 PM, Yasumasa Suenaga wrote: Sorry, I forgot to upload webrev. http://cr.openjdk.java.net/~ysuenaga/JDK-8035944/webrev.00/ Please review and sponsoring! Ah so this is build-infra. That is an experimental forest the state of which I am unclear of at the moment. I think Magn

Re: JDK-8035944: Build failed wilth configure option --disable-debuginfo-files

2014-02-27 Thread Yasumasa Suenaga
Sorry, I forgot to upload webrev. http://cr.openjdk.java.net/~ysuenaga/JDK-8035944/webrev.00/ Please review and sponsoring! Yasumasa On 02/27/2014 09:40 PM, Yasumasa Suenaga wrote: Hi all, I tried to build JDK8 with configure option: "--disable-debuginfo-files", however I got error mesasg

Re: JDK-8035944: Build failed wilth configure option --disable-debuginfo-files

2014-02-27 Thread Erik Joelsson
Hello Yasumasa, The mail server removes attachments. You will need to either upload the patch to a public location and link it or, if it's short, paste it inline in the mail. It looks like you made the patch against the build-infra forest. That's a workspace for the build-infra project and p

JDK-8035944: Build failed wilth configure option --disable-debuginfo-files

2014-02-27 Thread Yasumasa Suenaga
Hi all, I tried to build JDK8 with configure option: "--disable-debuginfo-files", however I got error mesasges as following: - ## Starting hotspot Generating source files Building adlc Building libjvm.so Building libjsig.so Building libsaproc.so gmake[2]: *** No rule to make ta

Re: [OpenJDK 2D-Dev] RFR: JDK-8035821: Move psfont properties files from src/share/classes to src/share/lib

2014-02-27 Thread Magnus Ihse Bursie
Phil, First of all, note that this is a change in build only. This change will not affect the source code in question, nor how it is executed. The properties files will end up in the very same location as a result of the build, wether with or without this patch. Hence, there is no need to run a