Re: RFR[9](XS): 8037298: Export HotSpots 'optimized' (i.e. not-product) configuration in the top-level configure/makefile

2014-03-14 Thread Volker Simonis
Hi Magnus, thanks for your detailed comments. I generally agree with your analysis of the problem. However, as you correctly noticed, the 'optimized' configuration is actually a "HotSpot only" concept. It is used to enable extra options/functionality which should not be shipped to the customer.

Re: [PATCH] For OpenJDK 8 and 9 to fix build issue when --with-alsa option is used

2014-03-14 Thread Magnus Ihse Bursie
On 2014-03-05 16:41, Man, Jessica wrote: Could this patch be backported to jdk8 please? Thank you. Regards, Jessica Man, Technology Goldman Sachs International Done, now. Thank you once again for your contribution. /Magnus

Re: RFR: JDK-8037238: JDK 9 images don't rebuild when access bridge jars rebuild

2014-03-14 Thread Magnus Ihse Bursie
On 2014-03-13 09:48, Erik Joelsson wrote: When rebuilding after touching a java source file in AccessBridge, the classes were recompiled but the jars were not rebuilt. This was caused by a bug in the macro CacheFind. The cache in this case contained the directory $(JDK_OUTPUTDIR)/classes. The j

Re: RFR: JDK-8010767: Build fails on OEL6 with 16 cores

2014-03-14 Thread Magnus Ihse Bursie
On 2014-03-14 12:06, Erik Joelsson wrote: Thanks for the comments, here is a new webrev for the root repo: http://cr.openjdk.java.net/~erikj/8010767/webrev.root.02/ Looks great. Thank you! /Magnus

Re: RFR: JDK-8010767: Build fails on OEL6 with 16 cores

2014-03-14 Thread Erik Joelsson
Thanks for the comments, here is a new webrev for the root repo: http://cr.openjdk.java.net/~erikj/8010767/webrev.root.02/ /Erik On 2014-03-14 11:44, Magnus Ihse Bursie wrote: On 2014-03-13 17:08, Erik Joelsson wrote: Hello, When building on large machines, the default Hotspot ergonomics are

Re: RFR: JDK-8010767: Build fails on OEL6 with 16 cores

2014-03-14 Thread Magnus Ihse Bursie
On 2014-03-13 17:08, Erik Joelsson wrote: Hello, When building on large machines, the default Hotspot ergonomics are causing us trouble. Trying to spawn 30 or more jvm instances just does not work with default options. To tackle this, I've split the JAVA_FLAGS variable into one common JAVA_FL

Re: RFR: JDK-8037281: Improve CacheFind and enable on all platforms

2014-03-14 Thread Magnus Ihse Bursie
On 2014-03-13 11:26, Erik Joelsson wrote: Triggered by JDK-8037238 and the CacheFind problems I decided to give it some more love. One reason CacheFind errors are rarely discovered is that it's only enabled on Windows, which is not used much in the build group. I would like to enable it on al

Re: RFR[9](XS): 8037298: Export HotSpots 'optimized' (i.e. not-product) configuration in the top-level configure/makefile

2014-03-14 Thread Magnus Ihse Bursie
On 2014-03-13 16:04, Volker Simonis wrote: Hi, could somebody please review this small change which exports HotSpots 'optimized' (i.e. not-product) configuration in the top-level configure/makefile: http://cr.openjdk.java.net/~simonis/webrevs/8037298/ https://bugs.openjdk.java.net/browse/JDK-80