Re: JDK-8036003: Add variable not to separate debug information.

2014-03-18 Thread Daniel D. Daugherty
On 3/18/14 12:22 PM, Andrew Hughes wrote: - Original Message - On 3/17/14 7:19 PM, Andrew Hughes wrote: - Original Message - On 3/3/14 2:49 PM, Omair Majid wrote: * David Holmes [2014-02-28 18:48]: There are three pieces to all of this: 1. Generating debug symbols in the bi

Re: RFR: JDK-8037483: issue with the crypto / sec zip unzipping in the jdk8 build

2014-03-18 Thread Bradford Wetmore
Looks good. Brad On 3/18/2014 8:04 AM, Tim Bell wrote: Hi Erik: On 2014-03-18 11:42, Erik Joelsson wrote: Please review this very simple fix to unzipping pre built security classes. When building incrementally, unzip will go into interactive mode and ask if it should overwrite files. The fi

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-18 Thread Andrew Hughes
- Original Message - > On 3/17/14 7:19 PM, Andrew Hughes wrote: > > - Original Message - > >> On 3/3/14 2:49 PM, Omair Majid wrote: > >>> * David Holmes [2014-02-28 18:48]: > There are three pieces to all of this: > > 1. Generating debug symbols in the binaries (via

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-18 Thread Daniel D. Daugherty
On 3/17/14 7:19 PM, Andrew Hughes wrote: - Original Message - On 3/3/14 2:49 PM, Omair Majid wrote: * David Holmes [2014-02-28 18:48]: There are three pieces to all of this: 1. Generating debug symbols in the binaries (via gcc -g or whatever) 2. Generating debuginfo files (zipped or

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-18 Thread Andrew Hughes
- Original Message - > On 2014-03-18 02:19, Andrew Hughes wrote: > > Do we need more than just the following three alternatives? > > > > #1. No debugging information at all. > > #2. Debugging information left in the original binaries. > > #3. Debugging information stripped from the binaries

Re: RFR[9](XS): 8037298: Export HotSpots 'optimized' (i.e. not-product) configuration in the top-level configure/makefile

2014-03-18 Thread Volker Simonis
On Tue, Mar 18, 2014 at 11:37 AM, Magnus Ihse Bursie wrote: > On 2014-03-14 17:55, Volker Simonis wrote: >> >> Hi Magnus, >> >> thanks for your detailed comments. >> >> I generally agree with your analysis of the problem. >> >> However, as you correctly noticed, the 'optimized' configuration is >>

Re: RFR: JDK-8037414: Licensee Source Bundles build issue

2014-03-18 Thread Gary Collins
Erik, We will need this fix backported to all 8uX releases as well as 9.. Thanks for getting this done so quickly. Thanks, Gary On Mar 18, 2014, at 4:29 AM, Erik Joelsson wrote: > Hello, > > The file jdk/make/closed/javax/crypto/doc/README.txt is not available to > licensees. The makefiles

Re: RFR: JDK-8037414: Licensee Source Bundles build issue

2014-03-18 Thread Gary Collins
Looks good.. This was one of our other possible fixes as well. Gary On Mar 18, 2014, at 4:29 AM, Erik Joelsson wrote: > Hello, > > The file jdk/make/closed/javax/crypto/doc/README.txt is not available to > licensees. The makefiles currently assumes it's always there as long as we > build cryp

Re: RFR: JDK-8037414: Licensee Source Bundles build issue

2014-03-18 Thread Tim Bell
Hi Erik: On 2014-03-18 12:29, Erik Joelsson wrote: Hello, The file jdk/make/closed/javax/crypto/doc/README.txt is not available to licensees. The makefiles currently assumes it's always there as long as we build crypto and it's not an OpenJDK build. This change also checks that the file is

Re: RFR: JDK-8037483: issue with the crypto / sec zip unzipping in the jdk8 build

2014-03-18 Thread Tim Bell
Hi Erik: On 2014-03-18 11:42, Erik Joelsson wrote: Please review this very simple fix to unzipping pre built security classes. When building incrementally, unzip will go into interactive mode and ask if it should overwrite files. The fix is to add -q -o to the unzip line as is done on all oth

Re: RFR: JDK-8037414: Licensee Source Bundles build issue

2014-03-18 Thread Magnus Ihse Bursie
On 2014-03-18 12:29, Erik Joelsson wrote: Hello, The file jdk/make/closed/javax/crypto/doc/README.txt is not available to licensees. The makefiles currently assumes it's always there as long as we build crypto and it's not an OpenJDK build. This change also checks that the file is actually in

RFR: JDK-8037414: Licensee Source Bundles build issue

2014-03-18 Thread Erik Joelsson
Hello, The file jdk/make/closed/javax/crypto/doc/README.txt is not available to licensees. The makefiles currently assumes it's always there as long as we build crypto and it's not an OpenJDK build. This change also checks that the file is actually in the source too. Bug: https://bugs.openjd

Re: RFR: JDK-8037483: issue with the crypto / sec zip unzipping in the jdk8 build

2014-03-18 Thread Magnus Ihse Bursie
On 2014-03-18 11:42, Erik Joelsson wrote: Please review this very simple fix to unzipping pre built security classes. When building incrementally, unzip will go into interactive mode and ask if it should overwrite files. The fix is to add -q -o to the unzip line as is done on all other invocati

RFR: JDK-8037483: issue with the crypto / sec zip unzipping in the jdk8 build

2014-03-18 Thread Erik Joelsson
Please review this very simple fix to unzipping pre built security classes. When building incrementally, unzip will go into interactive mode and ask if it should overwrite files. The fix is to add -q -o to the unzip line as is done on all other invocations of unzip. Bug: https://bugs.openjdk.j

Re: RFR[9](XS): 8037298: Export HotSpots 'optimized' (i.e. not-product) configuration in the top-level configure/makefile

2014-03-18 Thread Magnus Ihse Bursie
On 2014-03-14 17:55, Volker Simonis wrote: Hi Magnus, thanks for your detailed comments. I generally agree with your analysis of the problem. However, as you correctly noticed, the 'optimized' configuration is actually a "HotSpot only" concept. It is used to enable extra options/functionality

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-18 Thread Magnus Ihse Bursie
On 2014-03-18 10:58, Lindenmaier, Goetz wrote: Hi, it could be done with PPC64_ENDIANNESS check Yes, that's fine. I would further propose to choose a neutral name ENDIANESS and set it for all architectures. Platform specific variables should be avoided in shared files. And it's used in ppc

RE: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-18 Thread Lindenmaier, Goetz
Hi, > it could be done with PPC64_ENDIANNESS check Yes, that's fine. I would further propose to choose a neutral name ENDIANESS and set it for all architectures. Platform specific variables should be avoided in shared files. And it's used in ppc64.make, so that should be fine. Also -DLITTLE_E

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-18 Thread Magnus Ihse Bursie
On 2014-03-18 02:19, Andrew Hughes wrote: Do we need more than just the following three alternatives? #1. No debugging information at all. #2. Debugging information left in the original binaries. #3. Debugging information stripped from the binaries and zipped in separate files. It sounds to me