Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-25 Thread Vladimir Kozlov
I mean build changes in top directory: http://cr.openjdk.java.net/~martin/asmundak/8036767/webrev.01/ Thanks, Vladimir On 3/25/14 4:18 PM, Vladimir Kozlov wrote: I assume jdk changes are reviewed by Magnus. Please, confirm. Changes require a regeneration of generated-configure.sh files. I am

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-25 Thread Vladimir Kozlov
I assume jdk changes are reviewed by Magnus. Please, confirm. Changes require a regeneration of generated-configure.sh files. I am going to push jdk(top) changes into jdk9/hs-comp and will ask gatekeepers to push it up later. JDK control build testing is running in JPRT now. Thanks, Vladimir

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-25 Thread Vladimir Kozlov
I will push changes from webrev.05 into hs-comp/hotspot Where I should push jdk changes (jdk9/dev/ or hs-comp)?: http://cr.openjdk.java.net/~martin/asmundak/8036767/webrev.01/ Thanks, Vladimir On 3/25/14 3:32 AM, David Holmes wrote: Thanks. Build side looks fine to me. David On 25/03/2014 6

Re: RFR: 8033580: Old debug information in IMPORT_JDK is not removed

2014-03-25 Thread Daniel D. Daugherty
I'm fine if you leave your indentation as-is. This can be addressed when the new build system style reaches the HotSpot universe... Dan On 3/25/14 3:41 AM, Erik Helin wrote: Daniel, Erik thanks for the reviews and sorry taking so long to respond. About the indentation: I understand the conve

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-25 Thread David Holmes
Thanks. Build side looks fine to me. David On 25/03/2014 6:09 AM, Alexander Smundak wrote: Done. Uploaded http://cr.openjdk.java.net/~martin/asmundak/8036767/hotspot/webrev.05 On Sun, Mar 23, 2014 at 8:37 PM, David Holmes wrote: On 22/03/2014 10:47 AM, Alexander Smundak wrote: On Fri, Mar

Re: RFR: 8033580: Old debug information in IMPORT_JDK is not removed

2014-03-25 Thread Erik Helin
Daniel, Erik thanks for the reviews and sorry taking so long to respond. About the indentation: I understand the convention used in the new build system and I think it makes a lot of sense, but the file hotspot/make/Makefile clearly does not use this convention :) I would prefer to use the s