Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-27 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > On 27 mar 2014, at 12:47, Erik Joelsson wrote: > > Further testing revealed some more issues. New webrev: > > http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/ > > I had to break out the devkit/sysroot parts from from BASIC_SETUP_PATHS so > that it happen

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-27 Thread Erik Joelsson
Further testing revealed some more issues. New webrev: http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/ I had to break out the devkit/sysroot parts from from BASIC_SETUP_PATHS so that it happened after the early custom hook. /Erik On 2014-03-26 12:36, Magnus Ihse Bursie wrote: On

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-27 Thread Volker Simonis
On Thu, Mar 27, 2014 at 11:30 AM, Erik Joelsson wrote: > > > > > For the approval. Is this for JDK9 only? > No, we want to bring this to jdk8 eventually. > /Erik > > > On 2014-03-27 09:36, Volker Simonis wrote: >> >> On Thu, Mar 27, 2014 at 9:05 AM, Erik Joelsson >> wrote: >>> >>> There are unf

Re: RFR [9] 8038459: (sctp) Remove superflous classes on platforms without an implementation [macosx, aix]

2014-03-27 Thread Erik Joelsson
Looks good to me from a build perspective. /Erik On 2014-03-27 11:46, Chris Hegarty wrote: While hunting around the build recently, when working on another SCTP bug, I noticed a small issue where SCTP classes are being built on some platforms unnecessarily. Webrev: http://cr.openjdk.java.

RFR [9] 8038459: (sctp) Remove superflous classes on platforms without an implementation [macosx, aix]

2014-03-27 Thread Chris Hegarty
While hunting around the build recently, when working on another SCTP bug, I noticed a small issue where SCTP classes are being built on some platforms unnecessarily. Webrev: http://cr.openjdk.java.net/~chegar/8038459/webrev.00/webrev/ Mac OS X and AIX contain only stubs for the SCTP channels

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-27 Thread Erik Joelsson
Oops, sent this unfinished. See answers inline instead: On 2014-03-27 11:30, Erik Joelsson wrote: On 2014-03-27 09:36, Volker Simonis wrote: On Thu, Mar 27, 2014 at 9:05 AM, Erik Joelsson wrote: There are unfortunately legal complications surrounding updating these files. We can initiate the

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-27 Thread Erik Joelsson
For the approval. Is this for JDK9 only? /Erik On 2014-03-27 09:36, Volker Simonis wrote: On Thu, Mar 27, 2014 at 9:05 AM, Erik Joelsson wrote: There are unfortunately legal complications surrounding updating these files. We can initiate the approval dance, but it will take time to go thr

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-27 Thread Volker Simonis
On Thu, Mar 27, 2014 at 9:05 AM, Erik Joelsson wrote: > There are unfortunately legal complications surrounding updating these > files. We can initiate the approval dance, but it will take time to go > through (weeks at least). This is the reason Magnus added the wrapper around > config.guess, so

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2014-03-27 Thread Erik Joelsson
There are unfortunately legal complications surrounding updating these files. We can initiate the approval dance, but it will take time to go through (weeks at least). This is the reason Magnus added the wrapper around config.guess, so that we could get functional updates to it faster. I agree

Re: RFR: JDK-8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

2014-03-27 Thread Magnus Ihse Bursie
Yes, basically. And, optionally, an extra path (for non-toolchain binaries). So setting --with-devkit is, in a way, a convenient way of setting all these three options, in a way that works together and makes sense. That is, more or less, the same behavior we've had all the time, but it's slight