Java compilation and -g

2014-04-11 Thread Erik Joelsson
Hello, While converting the build to the new build-infra makefiles, one thing that annoyed me was the fact that we aren't consistently compiling with or without -g for java code. In the new makefiles we just emulate the same behavior, but I would like to sort it out properly now. Currently

Re: Java compilation and -g

2014-04-11 Thread Chris Hegarty
On 11/04/14 15:40, Erik Joelsson wrote: Hello, While converting the build to the new build-infra makefiles, one thing that annoyed me was the fact that we aren't consistently compiling with or without -g for java code. In the new makefiles we just emulate the same behavior, but I would like to

RFR [9] : get_source.sh should be more friendly to MQ

2014-04-11 Thread Chris Hegarty
Anyone using MQ for their daily development will know about this, forgetting to qpop before sync'ing up. It would be nice it get_source would pop and push patches ( only if you are using MQ ) automatically. If you do not have patch repos, then there is no change. diff --git a/get_source.sh

Re: RFR [9] : get_source.sh should be more friendly to MQ

2014-04-11 Thread Michael McMahon
That's very useful Chris. I wonder is it okay to assume that all patches must be pushed back again after the update? Would it be feasible to remember which (if any) patches had been popped first, and only push the same ones again? Michael On 11/04/14 15:58, Chris Hegarty wrote: Anyone using MQ

Re: RFR [9] : get_source.sh should be more friendly to MQ

2014-04-11 Thread Jonathan Gibbons
Popping all patches beforehand is reasonable, but afterwards, it would be better to reset to the patches that were previously applied than to try and push all of them. What is the behavior if you cannot qpush patches after the pull, because of merge issues? -- Jon On 04/11/2014 07:58 AM,

Re: RFR [9] : get_source.sh should be more friendly to MQ

2014-04-11 Thread Chris Hegarty
On 11/04/14 15:59, Jonathan Gibbons wrote: Popping all patches beforehand is reasonable, but afterwards, it would be better to reset to the patches that were previously applied than to try and push all of them. Michael as requested same. What is the behavior if you cannot qpush patches after

Re: RFR [9] : get_source.sh should be more friendly to MQ

2014-04-11 Thread Chris Hegarty
On 11/04/14 15:59, Michael McMahon wrote: That's very useful Chris. I wonder is it okay to assume that all patches must be pushed back again after the update? Would it be feasible to remember which (if any) patches had been popped first, and only push the same ones again? That would require a

Re: RFR [9] : get_source.sh should be more friendly to MQ

2014-04-11 Thread Jonathan Gibbons
Is it common to use mq in all repos of a forest? I've never used mq that way; it would only have occurred to me to use mq in the repo I'm interested in -- in my case, langtools. But then, I admit I tend not to clone forests more than necessary. configure.sh --with-override-repo-name is your

Re: RFR [9] : get_source.sh should be more friendly to MQ

2014-04-11 Thread Michael McMahon
On 11/04/14 16:19, Chris Hegarty wrote: On 11/04/14 15:59, Michael McMahon wrote: That's very useful Chris. I wonder is it okay to assume that all patches must be pushed back again after the update? Would it be feasible to remember which (if any) patches had been popped first, and only push

Re: RFR [9] : get_source.sh should be more friendly to MQ

2014-04-11 Thread Staffan Larsen
On 11 apr 2014, at 17:19, Jonathan Gibbons jonathan.gibb...@oracle.com wrote: Is it common to use mq in all repos of a forest? For me it is very common to be working on a fix that spans multiple repos (up to 5 different repos at times). So, yes. I like this fix, but I would be very annoyed

Re: Java compilation and -g

2014-04-11 Thread Gary Adams
What is the size difference? On 4/11/14, 10:53 AM, Chris Hegarty wrote: On 11/04/14 15:40, Erik Joelsson wrote: Hello, While converting the build to the new build-infra makefiles, one thing that annoyed me was the fact that we aren't consistently compiling with or without -g for java code. In

Re: RFR [9] : get_source.sh should be more friendly to MQ

2014-04-11 Thread Mike Duigou
Have you looked at using rebase? I've been using sh common/bin/hgforest.sh pull sh common/bin/hgforest.sh rebase sh common/bin/hgforest.sh update rather than get_source.sh as it allows me to skip the qpop/qpush steps. Mike On Apr 11 2014, at 07:58 , Chris Hegarty chris.hega...@oracle.com

Re: RFR [9] : get_source.sh should be more friendly to MQ

2014-04-11 Thread Jonathan Gibbons
Could we do the same with the trees extension? -- Jon On 04/11/2014 10:55 AM, Mike Duigou wrote: Have you looked at using rebase? I've been using sh common/bin/hgforest.sh pull sh common/bin/hgforest.sh rebase sh common/bin/hgforest.sh update rather than get_source.sh as it allows me to skip

Re: RFR [9] : get_source.sh should be more friendly to MQ

2014-04-11 Thread Chris Hegarty
On 11 Apr 2014, at 18:55, Mike Duigou mike.dui...@oracle.com wrote: Have you looked at using rebase? I have not, in any detail. I've been using sh common/bin/hgforest.sh pull sh common/bin/hgforest.sh rebase sh common/bin/hgforest.sh update rather than get_source.sh as it allows me to

Re: RFR [9] : get_source.sh should be more friendly to MQ

2014-04-11 Thread Mike Duigou
On Apr 11 2014, at 12:06 , Chris Hegarty chris.hega...@oracle.com wrote: On 11 Apr 2014, at 18:55, Mike Duigou mike.dui...@oracle.com wrote: Have you looked at using rebase? I have not, in any detail. I've been using sh common/bin/hgforest.sh pull sh common/bin/hgforest.sh rebase

Re: RFR 8030011: Update Hotspot version string output

2014-04-11 Thread alejandro murillo
On 4/10/2014 8:11 PM, David Holmes wrote: On 11/04/2014 1:42 AM, Alejandro E Murillo wrote: Hi David, thanks for the feedback, see below On 4/9/2014 8:38 PM, David Holmes wrote: Hi Alejandro, Given we have to maintain the JDK version information in two places (top level repo and hotspot

RFR: JDK-8038500: (zipfs) Upgrade ZIP provider to be a supported provider

2014-04-11 Thread Xueming Shen
Hi, Please help review this changeset to upgrade the zip filesystem provider implementation from demo to a supported provider. Back in JDK7 we created a demo file system provider for zip/jar files. It is shipped in two forms, one as a binary under lib/ext that works out of the box to support

copy folders instead of sequential hg clones

2014-04-11 Thread Pete Brunet
Since it takes forever to clone on my Win machine, in the case where I want to work on several bugs, is it OK to instead clone the first directory and then cp -ar that to n additional directories? -Pete

Re: RFR: JDK-8038500: (zipfs) Upgrade ZIP provider to be a supported provider

2014-04-11 Thread Mandy Chung
On 4/11/2014 3:42 PM, Xueming Shen wrote: webrev: http://cr.openjdk.java.net/~sherman/8038500/webrev It's good to see the source of the zip provider moved to the jdk repo. You have made some public classes to package-private which is good. I wonder whether a few remaining public classes

Re: copy folders instead of sequential hg clones

2014-04-11 Thread Mike Duigou
You might wish instead to do local clones of the first repo. hg clone http://hg.openjdk.java.net/jdk9/dev first cd first sh get_source.sh (with possibly some magic url) cd .. hg clone first second cd second sh get_source.sh ../first If you need to move repos between local machines or VMs you can

Re: copy folders instead of sequential hg clones

2014-04-11 Thread Jonathan Gibbons
To me, this message raises the questions of why does it take forever? and, how long should it take? I see a wide range of expectations. Some folk can clone fast, and assume that everyone else can as well. And then there's reports like this, that it takes forever. I'm all in favor of doing

Re: copy folders instead of sequential hg clones

2014-04-11 Thread Pete Brunet
Hi Jon, I am on VPN from Austin. It has always taken forever. And downloading programs from the internet when on VPN takes forever. I started looking into this a while back and I don't know if this is the issue but I found that the DNS servers are in Europe when I am on VPN. Right now as