Hi Erik,
This is great news! The dollar escaping stuff was a nightmare.
Thanks,
David
On 3/06/2014 12:09 AM, Erik Joelsson wrote:
Hello Emmanuel,
I remember that piece of make logic being especially tricky to get
working and it seems the weirdness in make has been fixed in make 4.0,
or at lea
Thumbs up from me too.
David
On 2/06/2014 10:54 PM, Erik Joelsson wrote:
Hello,
Please review this small fix to images/bundle build on Macosx. In the
macosx specific j2*-bundle, lib/server/libjsig.dylib is not a symlink to
../libjsig.dylib like on other platforms (or like in j2*-image). This
b
Hi - catching up on my email backlog:
Not sure what glibc version that is, though.
For Linux builds, others on build-dev@openjdk.java.net are more
knowledgeable about glibc used in different JDK releases.
Hmmm - these README-builds.html files do not mention a specific glibc
version:
http
> Looks pretty good. A couple of questions still:
>
> * Where is the AC_SUBST for SDKROOT?
>
> * Could we get the "Checking for Xcode sdk name" output to only print on
> macosx?
Would this be OK instead?
AC_MSG_CHECKING([for sdk name])
AC_MSG_RESULT([$SDKNAME])
Otherwise it might mak
Looks good to me. This has been a constant pain so I am very happy to
see it fixed
-phil.
On 6/2/2014 4:58 AM, Erik Joelsson wrote:
A friendly reminder that this still needs to be reviewed.
/Erik
On 2014-05-23 12:31, Erik Joelsson wrote:
Hello,
This patch attempts to fix a build problem in
>> * Why remove MACOSX_VERSION_MIN=@MACOSX_VERSION_MIN@? I believe we still use
>> this in some closed makefiles. Or is the idea that we instead will force the
>> sdk name to 10.7? If so, then we need to still leave this in until every
>> user (RE) has switched properly.
>>
>> I moved all that
On Jun 2 2014, at 09:23 , David DeHaven wrote:
> * Why remove MACOSX_VERSION_MIN=@MACOSX_VERSION_MIN@? I believe we still use
> this in some closed makefiles. Or is the idea that we instead will force the
> sdk name to 10.7? If so, then we need to still leave this in until every user
> (RE) h
Erik:
Looks good to me as well.
Tim
On 06/02/14 13:02, Daniel D. Daugherty wrote:
Erik,
Thanks for the very fast turn around on this.
I could not think of a good way to test this for unexpected side
effects other than to make the change and watch for fallout. I was
not able to envision a sce
> Hello David,
>
> Looks pretty good. A couple of questions still:
>
> * Where is the AC_SUBST for SDKROOT?
Oops, that should've been after SDKROOT="$SYSROOT" in basics.m4.
> * Could we get the "Checking for Xcode sdk name" output to only print on
> macosx?
Can do.
> * Why remove MACOSX_V
Hi Erik:
Looks good to me.
Tim
A friendly reminder that this still needs to be reviewed.
/Erik
On 2014-05-23 12:31, Erik Joelsson wrote:
Hello,
This patch attempts to fix a build problem in accessbridge. Two
compile jobs are both trying to create the same header file. The fix
is to separ
Le 02/06/2014 16:09, Erik Joelsson a écrit :
> The patch above works for me at least.
Hi Eric,
Thank you very much for the patch, I confirm it works on Debian. I was
starting to lose my sanity with this dollar expansion stuff.
Emmanuel Bourg
Hello Emmanuel,
I remember that piece of make logic being especially tricky to get
working and it seems the weirdness in make has been fixed in make 4.0,
or at least changed. Our dealing with escaping dollars is rather messy
in JDK 8. I have recently worked on this in a JDK 9 project, where I
Erik,
Thanks for the very fast turn around on this.
I could not think of a good way to test this for unexpected side
effects other than to make the change and watch for fallout. I was
not able to envision a scenario where replacing a regular file
with a symlink to a copy of the same file would b
Hello,
Please review this small fix to images/bundle build on Macosx. In the
macosx specific j2*-bundle, lib/server/libjsig.dylib is not a symlink to
../libjsig.dylib like on other platforms (or like in j2*-image). This
behavior dates back to the original macosx port and was intentionally
emu
A friendly reminder that this still needs to be reviewed.
/Erik
On 2014-05-23 12:31, Erik Joelsson wrote:
Hello,
This patch attempts to fix a build problem in accessbridge. Two
compile jobs are both trying to create the same header file. The fix
is to separate the output directories of these
Hello David,
Looks pretty good. A couple of questions still:
* Where is the AC_SUBST for SDKROOT?
* Could we get the "Checking for Xcode sdk name" output to only print on
macosx?
* Why remove MACOSX_VERSION_MIN=@MACOSX_VERSION_MIN@? I believe we still
use this in some closed makefiles. Or i
On 02/06/2014 04:02, David Holmes wrote:
Hi Alan,
This change looks okay to me.
But the bug synopsis and description should clarify that it drops
javax.transaction from compact2 and compact3, as you are moving it to
the full JRE.
Thanks. I'll change the synopsis to "Drop javax.transaction f
17 matches
Mail list logo
