Re: RFR 8047765: Generate blacklist.certs in build

2014-07-01 Thread Wang Weijun
On Jul 2, 2014, at 12:48, David Holmes wrote: > > 73 // Output sorted for eye pleasure. > > ?? "eye pleasure" Well, it's easy for a human to locate one from a sorted output. Or maybe it's because the old one is sorted and I don't want the new one looks ugly. --Max

Re: RFR 8047765: Generate blacklist.certs in build

2014-07-01 Thread David Holmes
Hi Max, On 2/07/2014 1:46 PM, Wang Weijun wrote: Hi All Please review the fix at http://cr.openjdk.java.net/~weijun/8047765/webrev.00/ where the generation of blacklisted.certs is moved from developer-manual to build-auto. I copied the mechanisms from GENDATA_HTML32DTD. Seems like a re

RFR 8047765: Generate blacklist.certs in build

2014-07-01 Thread Wang Weijun
Hi All Please review the fix at http://cr.openjdk.java.net/~weijun/8047765/webrev.00/ where the generation of blacklisted.certs is moved from developer-manual to build-auto. I copied the mechanisms from GENDATA_HTML32DTD. One thing I am not sure about is that if I update the tool a little,

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

2014-07-01 Thread Anthony Petrov
Hi Petr, The fix looks fine to me. Only one question: src/share/classes/java/awt/datatransfer/SystemFlavorMap.java 234 } catch (IOException e) { 235 System.err.println("Warning reading flavor mapping: " + e.getMessage()); Is there a reason to hide the stack trace of the

Re: 8048891: Remove unused JObjC from jdk repository

2014-07-01 Thread Alan Bateman
On 01/07/2014 17:34, Sergey Bylokhov wrote: I have a feeling that if it will be deleted, nobody will do that. But probably nobody use that already. Do you mean JDK-8023110? That seems to have been closed. In any case, I don't think removing it from 9 will preclude doing that (as the source will

Re: 8048891: Remove unused JObjC from jdk repository

2014-07-01 Thread Sergey Bylokhov
On 01.07.2014 20:23, Alan Bateman wrote: On 01/07/2014 17:20, Sergey Bylokhov wrote: Hi, Alan. This source code wasn't removed because there was a decision to move it to the separate project on java.net. Do you plan to do that? I don't but removing it from JDK 9 forest shouldn't preclude anyon

Re: 8048891: Remove unused JObjC from jdk repository

2014-07-01 Thread Alan Bateman
On 01/07/2014 17:20, Sergey Bylokhov wrote: Hi, Alan. This source code wasn't removed because there was a decision to move it to the separate project on java.net. Do you plan to do that? I don't but removing it from JDK 9 forest shouldn't preclude anyone doing that. -Alan.

Re: 8048891: Remove unused JObjC from jdk repository

2014-07-01 Thread Sergey Bylokhov
Hi, Alan. This source code wasn't removed because there was a decision to move it to the separate project on java.net. Do you plan to do that? On 01.07.2014 18:31, Alan Bateman wrote: I posted a note here recently (and to macosx-port-dev) about the unused JObjC source code in the jdk reposit

Re: 8048891: Remove unused JObjC from jdk repository

2014-07-01 Thread pointo1d
Hiya Alan , On 01/07/14 15:31, Alan Bateman wrote: I posted a note here recently (and to macosx-port-dev) about the unused JObjC source code in the jdk repository [1]. I didn't see any replies or objections so I'd like to go ahead and remove this code. As I mentioned, this code has not been

Re: 8048891: Remove unused JObjC from jdk repository

2014-07-01 Thread Mandy Chung
On 7/1/2014 7:31 AM, Alan Bateman wrote: I posted a note here recently (and to macosx-port-dev) about the unused JObjC source code in the jdk repository [1]. I didn't see any replies or objections so I'd like to go ahead and remove this code. As I mentioned, this code has not been built for

8048891: Remove unused JObjC from jdk repository

2014-07-01 Thread Alan Bateman
I posted a note here recently (and to macosx-port-dev) about the unused JObjC source code in the jdk repository [1]. I didn't see any replies or objections so I'd like to go ahead and remove this code. As I mentioned, this code has not been built for sometime and the last reference in the ma

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

2014-07-01 Thread Petr Pchelko
Hello, The changes in the public API have been approved, so let me continue the review process. For your convenience: The bug: https://bugs.openjdk.java.net/browse/JDK-8047336 The fix: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/ Until now we've been discussing an abstract question