Re: RFR: JDK-8055141 Catch linker errors earlier in the JVM build by not allowing unresolved externals

2014-09-18 Thread David Holmes
Looks good and works well! Lets get this one backported too please. :) Thanks, David On 18/09/2014 6:39 PM, Mikael Gerdin wrote: Hi all, As you may know, linking an ELF shared object allows unresolved external symbols at link time. This is sometimes problematic for JVM developers since the JVM

RFR: 8056216 : Remove "sun" directory layer from libawt and common

2014-09-18 Thread Phil Race
https://bugs.openjdk.java.net/browse/JDK-8056216 http://cr.openjdk.java.net/~prr/8056216/ This is all just removing the sequence "sun/" from various pathnames. Aside from the make file changes there are over 600 file moves which I don't think its worth including in the webrev but they are the r

RFR: 8058756: OpenJDK builds fail on Windows - cannot copy freetype.dll

2014-09-18 Thread Phil Race
https://bugs.openjdk.java.net/browse/JDK-8058756 Here's my proposed one-liner fix :- diff -r 07156012ab78 make/copy/Copy-java.desktop.gmk --- a/make/copy/Copy-java.desktop.gmk Thu Sep 18 17:34:44 2014 +0400 +++ b/make/copy/Copy-java.desktop.gmk Thu Sep 18 12:51:40 2014 -0700 @@ -68,6 +68,7 @@

Re: RFR: JDK-8055141 Catch linker errors earlier in the JVM build by not allowing unresolved externals

2014-09-18 Thread Erik Helin
Hi Mikael, thanks for fixing this! Looks good, Reviewed. Erik On 2014-09-18 10:39, Mikael Gerdin wrote: Hi all, As you may know, linking an ELF shared object allows unresolved external symbols at link time. This is sometimes problematic for JVM developers since the JVM does not depend on unre

Re: RFR: JDK-8055141 Catch linker errors earlier in the JVM build by not allowing unresolved externals

2014-09-18 Thread Erik Joelsson
Looks good to me. /Erik On 2014-09-18 10:39, Mikael Gerdin wrote: Hi all, As you may know, linking an ELF shared object allows unresolved external symbols at link time. This is sometimes problematic for JVM developers since the JVM does not depend on unresolved external symbols and all missing

RFR: JDK-8055141 Catch linker errors earlier in the JVM build by not allowing unresolved externals

2014-09-18 Thread Mikael Gerdin
Hi all, As you may know, linking an ELF shared object allows unresolved external symbols at link time. This is sometimes problematic for JVM developers since the JVM does not depend on unresolved external symbols and all missing symbols at build time are due to mistakes, usually missing include