Well, it turns out that I do have to update modules.xml with the
jdk.crypto.ucrypto module info (Thanks to a tip from Mandy). I have sent
the necessary webrev for this to jigsaw alias separately.
Thanks,
Valerie
On 10/15/2014 2:39 PM, Valerie Peng wrote:
The /modules.xml already allows jdk
The /modules.xml already allows jdk.crypto.ucrypto to access
sun.nio.cs, sun.security.action, sun.security.internal.spec,
sun.security.util packages.
The build completes and no module access errors. So, it seems to me that
current content of modules.xml is fine.
Thanks,
Valerie
On 10/15/20
On 15/10/2014 19:46, Valerie Peng wrote:
Hi, build experts,
Could you please review the build-related changes for 8046002: Move
Ucrypto to the open jdk repo?
The rest (src/test) has been reviewed by my peers in security team.
Bug: https://bugs.openjdk.java.net/browse/JDK-8046002
Webrev: http:
Hi, build experts,
Could you please review the build-related changes for 8046002: Move
Ucrypto to the open jdk repo?
The rest (src/test) has been reviewed by my peers in security team.
Bug: https://bugs.openjdk.java.net/browse/JDK-8046002
Webrev: http://cr.openjdk.java.net/~valeriep/8046002/we
Hi Erik:
Please review this change, which splits up GensrcProperties.gmk so
that the sources for each module get generated in the correct
$module-gensrc target.
I replaced the contents of GensrcProperties.gmk with macros for
compiling properties into java files. Then each Gensrc-$module.gmk
Nice catch Mandy, I forgot about that one.
/Erik
On 2014-10-15 18:04, Mandy Chung wrote:
Hi Shanliang,
On 10/15/2014 8:19 AM, shanliang wrote:
Here is the new version:
http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/
Thanks for taking this on. The fix looks okay. I think you should
Here is the new version:
http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/
I add:
./01/jdk9-make/
for updating ./make/CompileJavaModules.gmk
./01/jdk9-jdk-src/ is same to ./00
Thanks,
Shanliang
Erik Joelsson wrote:
Hello,
Removing the excludes would be appreciated. Here is a patch:
On 10/15/2014 9:04 AM, Mandy Chung wrote:
Hi Shanliang,
On 10/15/2014 8:19 AM, shanliang wrote:
Here is the new version:
http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/
Thanks for taking this on. The fix looks okay. I think you should
also take out:
make/common/Modules.gmk
line 45
Hi Shanliang,
On 10/15/2014 8:19 AM, shanliang wrote:
Here is the new version:
http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/
Thanks for taking this on. The fix looks okay. I think you should
also take out:
make/common/Modules.gmk
line 45: JAVA_MODULES_FILTER := jdk.snmp
Mandy
On 15/10/14 17:19, shanliang wrote:
Here is the new version:
http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/
The new version looks fine :-)
-- daniel
I add:
./01/jdk9-make/
for updating ./make/CompileJavaModules.gmk
./01/jdk9-jdk-src/ is same to ./00
Thanks,
Shanliang
Erik Jo
On 15/10/2014 16:19, shanliang wrote:
Here is the new version:
http://cr.openjdk.java.net/~sjiang/JDK-8060692/01/
I add:
./01/jdk9-make/
for updating ./make/CompileJavaModules.gmk
./01/jdk9-jdk-src/ is same to ./00
Thanks,
Shanliang
This looks good.
-Alan
Hello,
Please review this change, which splits up GensrcProperties.gmk so that
the sources for each module get generated in the correct $module-gensrc
target.
I replaced the contents of GensrcProperties.gmk with macros for
compiling properties into java files. Then each Gensrc-$module.gmk fi
Hello,
Removing the excludes would be appreciated. Here is a patch:
diff -r c173ba994245 make/CompileJavaModules.gmk
--- a/make/CompileJavaModules.gmk
+++ b/make/CompileJavaModules.gmk
@@ -247,14 +247,6 @@
# Exclude building of IIOP transport for RMI Connector
java.management_EXCLUDES := com/s
On 15/10/2014 14:35, shanliang wrote:
Hi,
SNMP is not part of OpenJDK and SNMP packages are not compiled in
OpenJDK, so the SNMP sources should be deleted from the OpenJDK
Bug: https://bugs.openjdk.java.net/browse/JDK-8060692
Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8060692/00/
The code
Thanks Erik!
-Pavel
On 15 Oct 2014, at 11:40, Erik Joelsson wrote:
> Hello,
>
> I have managed to come up with this solution for jdk9/dev.
>
> http://cr.openjdk.java.net/~erikj/8044627/webrev.01/
>
> I added a gensrc step for each of the affected modules that simply
> concatenates the files
Hello,
I have managed to come up with this solution for jdk9/dev.
http://cr.openjdk.java.net/~erikj/8044627/webrev.01/
I added a gensrc step for each of the affected modules that simply
concatenates the files into the gensrc output dir. The version found
there will automatically override the
16 matches
Mail list logo
