Re: [9] RFR: 8061382: Separate CLDR locale data from JRE locale data

2014-10-24 Thread Erik Joelsson
Hello Naoto, Just one thing, in Gensrc-java.base.gmk, shouldn't we still just run the targets in GENSRC_JAVA_BASE and let Gensrc-jdk.localedata.classic.gmk deal with GENSRC_JDK_LOCALEDATA_CLASSIC? /Erik On 2014-10-23 22:05, Naoto Sato wrote: I revised the fix according to the suggestions I

Re: RFR (XS) 8061346: Source changes needed to build JDK 9 with Mac OS 9 'Maverics' and clang/Xcode 5.1.1

2014-10-24 Thread Erik Joelsson
On 2014-10-24 02:58, Wang Weijun wrote: On Oct 24, 2014, at 02:12, Tim Bell tim.b...@oracle.com wrote: -macosx_x64_10.7-{product|fastdebug},\ +macosx_x64_10.9-{product|fastdebug},\ You have to remove the old line. Does this mean we cannot setup some

Re: Review request: JDK-8061924 - demos target fails if users CDPATH is incorrectly set

2014-10-24 Thread Erik Joelsson
The proposed change looks good. I will push it to jdk9/dev. /Erik On 2014-10-23 15:01, Dave Pointon wrote: Hi all , Having found and already reported (at https://bugs.openjdk.java.net/browse/JDK-8061924), the above bug, I would be indebted to you if you would be good enough to review the

Re: RFR (XS) 8061346: Source changes needed to build JDK 9 with Mac OS 9 'Maverics' and clang/Xcode 5.1.1

2014-10-24 Thread Tim Bell
On 10/24/14 00:56, Erik Joelsson wrote: On 2014-10-24 02:58, Wang Weijun wrote: On Oct 24, 2014, at 02:12, Tim Bell tim.b...@oracle.com wrote: -macosx_x64_10.7-{product|fastdebug},\ +macosx_x64_10.9-{product|fastdebug},\ You have to remove the old line.

Re: [9] RFR: 8061382: Separate CLDR locale data from JRE locale data

2014-10-24 Thread Naoto Sato
Hi Erik, Yep, that is not needed so I will remove it. Thank you for catching it. Naoto On 10/24/14, 12:28 AM, Erik Joelsson wrote: Hello Naoto, Just one thing, in Gensrc-java.base.gmk, shouldn't we still just run the targets in GENSRC_JAVA_BASE and let Gensrc-jdk.localedata.classic.gmk deal