To enable generating additional javadoc from the CUSTOM_MAKE_DIR
directory please review:
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-custom-javadoc/
Issue:
8062475: Enable hook for custom doc generation
Thanks, Roger
Looking for a review of the following small patch to langtools/test/Makefile.
The script is hard-coded to use JCK 8 when running JCK tests, causing 19
failures; it should be using JCK 9. I assume there aren't any important
processes that depend on this target (e.g., SQE automated runs) or they
TFT insight, Erik ,
In the interests of the prevention of misleading output (and consistency) ,
I'll raise an appropriate defect (via http://bugreport.java.com), provide a
fix, await triage and then submit for approval in the manner to which I've
only recently become acquainted thanx mainly to you
Looks good, thanks!
I usually just post the patch inline if the change is this small.
/Erik
On 2014-10-29 10:58, Volker Simonis wrote:
Hi Erik,
thanks for the review.
On Wed, Oct 29, 2014 at 10:01 AM, Erik Joelsson
wrote:
Hello Volker,
The change looks good, but I would like a comment exp
Hi Erik,
thanks for the review.
On Wed, Oct 29, 2014 at 10:01 AM, Erik Joelsson
wrote:
> Hello Volker,
>
> The change looks good, but I would like a comment explaining why
> install-file isn't used. Otherwise it's quite possible we will break this
> again in future cleanups.
>
I forget that and
We have probably forgotten to put the correct conditionals around some
of the X11 checks so they are executed on Windows. It should be harmless
though. Freetype is however needed, as has been pointed out by others
already.
A note on freetype is to be sure that it's 64bit if you are building
6
Hello Volker,
The change looks good, but I would like a comment explaining why
install-file isn't used. Otherwise it's quite possible we will break
this again in future cleanups.
/Erik
On 2014-10-28 20:18, Volker Simonis wrote:
Hi,
could you please review the following tiny change which fi
