Hi Erik,
Thanks for the comments and recommendations.
Though the new macro is not applicable to 8u40 and I'll need to use the
original form of -include.
Do I need a separate bug/review/webrev for 8u40?
The webrev is updated:
http://cr.openjdk.java.net/~rriggs/webrev-custom-javadoc/
Thanks
On 10/30/2014 7:32 AM, Erik Joelsson wrote:
On 2014-10-30 13:52, David Holmes wrote:
On 30/10/2014 10:42 PM, Erik Joelsson wrote:
I think it would fail in JPRT too, I never ran JPRT with JDK-8062159
unfortunately. I assume very few people run jdk9-dev in JPRT with
embedded platforms.
All ho
Da, Erik,
Looks good to me.
--- Jon
On 10/30/2014 01:27 AM, Erik Joelsson wrote:
Hello Dan,
The change looks good to me. I'm not a user of these tests though so
perhaps best to get a langtools reviewer to look at it too.
/Erik
On 2014-10-29 20:41, Dan Smith wrote:
Looking for a review of
On 2014-10-30 13:52, David Holmes wrote:
On 30/10/2014 10:42 PM, Erik Joelsson wrote:
I think it would fail in JPRT too, I never ran JPRT with JDK-8062159
unfortunately. I assume very few people run jdk9-dev in JPRT with
embedded platforms.
All hotspot integrations are doing it. You need "-te
On 30/10/2014 10:42 PM, Erik Joelsson wrote:
I think it would fail in JPRT too, I never ran JPRT with JDK-8062159
unfortunately. I assume very few people run jdk9-dev in JPRT with
embedded platforms.
All hotspot integrations are doing it. You need "-testset hotspot" on
the jprt submit. It just
I think it would fail in JPRT too, I never ran JPRT with JDK-8062159
unfortunately. I assume very few people run jdk9-dev in JPRT with
embedded platforms.
/Erik
On 2014-10-30 13:31, David Holmes wrote:
Hi Erik,
Seems reasonable. Did this not fail when run through JPRT? Is it
something shell
Hi Erik,
Seems reasonable. Did this not fail when run through JPRT? Is it
something shell specific?
David
On 30/10/2014 9:40 PM, Erik Joelsson wrote:
Hello,
In my fix for "JDK-8062159 Fix Xrender check to work with sysroot", I
added $SYSROOT_CFLAGS to the CFLAGS used when looking for X11 he
Hello,
In my fix for "JDK-8062159 Fix Xrender check to work with sysroot", I
added $SYSROOT_CFLAGS to the CFLAGS used when looking for X11 headers.
Unfortunately, this didn't work with at least one of the cross compile
kits we use. The reason for the failure is in the definition of
SYSROOT_CF
Hello Roger,
I JDK 9 we introduced a macro call that handles custom inclusion instead
of directly doing -include. Look for example in make/common/MakeBase.gmk.
# Hook to include the corresponding custom file, if present.
$(eval $(call IncludeCustomExtension, , common/MakeBase.gmk))
Our defini
Hello Dan,
The change looks good to me. I'm not a user of these tests though so
perhaps best to get a langtools reviewer to look at it too.
/Erik
On 2014-10-29 20:41, Dan Smith wrote:
Looking for a review of the following small patch to langtools/test/Makefile.
The script is hard-coded to
10 matches
Mail list logo
