Re: RFR: 9/8u40 8062475: Enable hook for custom doc generation

2014-10-31 Thread Erik Joelsson
Hello Roger, The same bug should be ok, but there will be some differences in the changes so separate reviews will be needed. Another difference between JDK 8 and JDK 9 is that we have the top level closed repo in JDK 9 and a closed Javadoc.gmk belongs in that repo and not jdk/make/closed.

Re: Suggestion for end of Makefile

2014-10-31 Thread Erik Joelsson
I've filed https://bugs.openjdk.java.net/browse/JDK-8062618 and started working on this. It looks promising, but I will need to run it on a large amount of failed logs from JPRT to make sure the regexps catch the right lines. /Erik On 2014-10-27 09:42, Erik Joelsson wrote: That is an

Re: [9] RFR: 8061382: Separate CLDR locale data from JRE locale data

2014-10-31 Thread Magnus Ihse Bursie
On 2014-10-23 22:05, Naoto Sato wrote: I revised the fix according to the suggestions I got. The main change is to rename the name of the locale data modules. Now we have two as follows: - jdk.localedata.classic: Legacy locale data - jdk.localedata.cldr: CLDR locale data Revised webrev is

Re: Suggestion for end of Makefile

2014-10-31 Thread Magnus Ihse Bursie
On 2014-10-25 00:31, Jonathan Gibbons wrote: Re: JDK builds, The new parallel make is wonderfully fast (thank you) but less great when it comes to figuring out why a build failed, especially when you don't have full access to the build machine, as is the case with build servers, where you

Re: [9] RFR: 8061382: Separate CLDR locale data from JRE locale data

2014-10-31 Thread Erik Joelsson
On 2014-10-31 14:21, Magnus Ihse Bursie wrote: 1) I do not like how gensrc/Gensrc-jdk.localedata.cldr.gmk is included in CreateJars.gmk -- it should not be there. The reason is to get the CLDRVERSION which is defined in that file. I'd like to address that, either by extracting the

Re: RFR: 9/8u40 8062475: Enable hook for custom doc generation

2014-10-31 Thread roger riggs
Hi, Thanks for the recommendations, updated webrevs: JDK 9 webrev: http://cr.openjdk.java.net/~rriggs/webrev-custom-javadoc-jdk9/ JDK 8u webrev: http://cr.openjdk.java.net/~rriggs/webrev-javadoc-custom-jdk8u/ Thanks, Roger On 10/31/2014 5:17 AM, Erik Joelsson wrote: Hello Roger,

Re: RFR: 9/8u40 8062475: Enable hook for custom doc generation

2014-10-31 Thread Erik Joelsson
On 2014-10-31 14:44, roger riggs wrote: Hi, Thanks for the recommendations, updated webrevs: JDK 9 webrev: http://cr.openjdk.java.net/~rriggs/webrev-custom-javadoc-jdk9/ This macro call will look for jdk/make/closed/Javadoc.gmk. It should be: $(eval $(call IncludeCustomExtension, ,

Re: RFR: 9/8u40 8062475: Enable hook for custom doc generation

2014-10-31 Thread roger riggs
Hi, Corrected, updated the webrev. http://cr.openjdk.java.net/~rriggs/webrev-custom-javadoc-jdk9/ Thanks, Roger On 10/31/2014 9:47 AM, Erik Joelsson wrote: On 2014-10-31 14:44, roger riggs wrote: Hi, Thanks for the recommendations, updated webrevs: JDK 9 webrev:

Re: RFR: 9/8u40 8062475: Enable hook for custom doc generation

2014-10-31 Thread Erik Joelsson
Thanks, looks good! /Erik On 2014-10-31 14:50, roger riggs wrote: Hi, Corrected, updated the webrev. http://cr.openjdk.java.net/~rriggs/webrev-custom-javadoc-jdk9/ Thanks, Roger On 10/31/2014 9:47 AM, Erik Joelsson wrote: On 2014-10-31 14:44, roger riggs wrote: Hi, Thanks for the

RFR 8u40: 8062635: Enable custom CompileJavaClasses.gmk

2014-10-31 Thread roger riggs
Please review a change to include CompileJavaClasses.gmk from the CUSTOM_MAKE_DIR. Please verify the change from := to += at line 61, it was overwriting instead of appending. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-custom-compile-java/ Issue:

Re: RFR 8u40: 8062635: Enable custom CompileJavaClasses.gmk

2014-10-31 Thread Erik Joelsson
Looks good. /Erik On 2014-10-31 16:34, roger riggs wrote: Please review a change to include CompileJavaClasses.gmk from the CUSTOM_MAKE_DIR. Please verify the change from := to += at line 61, it was overwriting instead of appending. Webrev:

Re: Building on Windoze (64 bit)

2014-10-31 Thread Dave Pointon
Hi all , FWIW, I've now raised the defect (JI-9016214) complete with fix which, AFAICT, is now awaiting triage. Rgds ,Dave P -- Dave Pointon FIAP MBCS Now I saw, tho' too late, the folly of beginning a work before we count the cost and before we we judge rightly of our strength to go thro'

Re: [9] RFR: 8061382: Separate CLDR locale data from JRE locale data

2014-10-31 Thread Naoto Sato
Thank you, Magnus, Erik for the comments. My comments inline below: On 10/31/14, 6:32 AM, Erik Joelsson wrote: On 2014-10-31 14:21, Magnus Ihse Bursie wrote: 1) I do not like how gensrc/Gensrc-jdk.localedata.cldr.gmk is included in CreateJars.gmk -- it should not be there. The reason is to

Re: RFR: JDK-8062449 Update langtools/test/Makefile to use JCK 9

2014-10-31 Thread Dan Smith
While I'm at it, here are some trivial cleanups: - Silence echoing of the error-handling commands (command still runs, but make doesn't print it out) - Allow the 'JCK_VERBOSE' variable to request -v (JCK doesn't support this with an alias like -v:summary) Jon, if you still approve, I'll push

Re: RFR: JDK-8062449 Update langtools/test/Makefile to use JCK 9

2014-10-31 Thread Jonathan Gibbons
Dan, OK by me. -- Jon On 10/31/2014 11:28 AM, Dan Smith wrote: While I'm at it, here are some trivial cleanups: - Silence echoing of the error-handling commands (command still runs, but make doesn't print it out) - Allow the 'JCK_VERBOSE' variable to request -v (JCK doesn't support this