Daniel,
Your test change looks fine and good to push this change that should
catch if similar regression occurs in the future. I was tempted to
suggest to have a dedicated test for the build-time modification to the
properties file. Maybe a low priority RFE.
Mandy
On 11/20/14 9:25 AM, Dan
On 11/07/2014 12:19 PM, Andrew Haley wrote:
On 11/07/2014 06:10 PM, Christian Thalinger wrote:
On Nov 7, 2014, at 9:55 AM, Andrew Haley wrote:
On 11/07/2014 05:42 PM, Christian Thalinger wrote:
On Nov 7, 2014, at 9:21 AM, Andrew Haley wrote:
The first patch: top-level build machinery ch
> From: Chris Hegarty
> Subject: RFR [JEP 220] Modular Run-Time Images
> Date: 20 November 2014 21:39:14 GMT
> To: jigsaw-dev , jdk9-dev
> , build-dev , Alan
> Bateman , Alex Buckley ,
> Chris Hegarty , Erik Joelsson
> , Jonathan Gibbons ,
> Karen Kinnear , "Jim Laskey (Oracle)"
> , Magnus
Awesome! Glad to see the fix in the build process. It's a relief to
know we don't have to worry about individual properties files.
Daniel, your test looks good to me. That's how jaxp loads
Encodings.properties.
Thanks,
Joe
On 11/20/2014 9:25 AM, Daniel Fuchs wrote:
On 20/11/14 14:36, Erik
On 11/20/14 3:19 AM, Erik Joelsson wrote:
Hello,
Please review this small fix, correcting the source generation from
properties when the properties files are in platform specific source
directories. The bug was introduced by me in JDK-8055191.
Bug: https://bugs.openjdk.java.net/browse/JDK-80
On 20/11/14 14:36, Erik Joelsson wrote:
Here is my proposal for fixing the particular issue of generating the
correct properties files. I'm simply adding LC_ALL=C to the whole
command line instead of just the sort at the end. It seems to require
using "export" to get picked up.
Hi Erik,
Looks
Erik:
Please review this small fix, correcting the source generation from
properties when the properties files are in platform specific source
directories. The bug was introduced by me in JDK-8055191.
Bug: https://bugs.openjdk.java.net/browse/JDK-8065412
Patch inline:
diff --git a/make/gensr
Here is my proposal for fixing the particular issue of generating the
correct properties files. I'm simply adding LC_ALL=C to the whole
command line instead of just the sort at the end. It seems to require
using "export" to get picked up.
Bug: https://bugs.openjdk.java.net/browse/JDK-8065138
P
Hello,
Please review this small fix, correcting the source generation from
properties when the properties files are in platform specific source
directories. The bug was introduced by me in JDK-8055191.
Bug: https://bugs.openjdk.java.net/browse/JDK-8065412
Patch inline:
diff --git a/make/gens
I think it's Import.gmk that isn't working well with non zipped debug
symbols on mac. The .dSYM file is actually a directory and the logic in
Import.gmk probably hasn't been exercised with that much.
/Erik
On 2014-11-20 11:00, David Holmes wrote:
Building 8u on OSX with --disable-zip-debug-in
Building 8u on OSX with --disable-zip-debug-info I see in the log:
make[2]: unlink:
/Users/jprtadm/davidh-test/build/b01/se-macosx-x86_64-ea/jdk/lib/libjsig.dylib.dSYM:
Operation not permitted
Can anyone shed any light on this? I'm not clear on what is being
attempted nor the affects on the
On 11/20/14 10:26 AM, Erik Joelsson wrote:
Hello,
On 2014-11-20 02:20, Martin Buchholz wrote:
Amusingly, the $(SORT) has an LC_ALL=C carefully placed before it, but
the $(SED)s need it too!
Yes, I think that's the correct fix in this case.
On Wed, Nov 19, 2014 at 5:18 PM, Martin Buchholz
wro
Hello,
On 2014-11-20 02:20, Martin Buchholz wrote:
Amusingly, the $(SORT) has an LC_ALL=C carefully placed before it, but
the $(SED)s need it too!
Yes, I think that's the correct fix in this case.
On Wed, Nov 19, 2014 at 5:18 PM, Martin Buchholz wrote:
[+ build-dev]
I think I see the proble
Looks good to me.
/Erik
On 2014-11-18 15:14, Magnus Ihse Bursie wrote:
On 2014-11-18 15:00, Magnus Ihse Bursie wrote:
Warnings in configure tends to just fly by quickly and be buried in
the verbose autoconf output.
We could with a simple trick repeat all those warnings (if any) at
the end o
14 matches
Mail list logo