I think it's a reasonable change to remove the flag as it has most
likely not seen much use (if any) yet. I'm not sure what it does, but I
assume it's something to improve exploit protection the source code. But
if it doesn't work, we can't use it.
We could also consider disabling the flag
Hello Daniel,
Test seems like a great idea. Thanks!
/Erik
On 2014-11-20 18:25, Daniel Fuchs wrote:
On 20/11/14 14:36, Erik Joelsson wrote:
Here is my proposal for fixing the particular issue of generating the
correct properties files. I'm simply adding LC_ALL=C to the whole
command line
On 23/11/14 23:15, Magnus Ihse Bursie wrote:
On 2014-11-20 22:39, Chris Hegarty wrote:
This is a review request for the changes for JEP 220: Modular Run-Time
Images [1].
There are a number of individuals responsible for these changes. Some,
possibly not all, are explicitly listed in the 'To'
On 24/11/14 11:44, Erik Joelsson wrote:
Hello Daniel,
Test seems like a great idea. Thanks!
OK - I have logged JDK-8065748
https://bugs.openjdk.java.net/browse/JDK-8065748
I'll send a patch for review when your fix is in :-)
Thanks!
-- daniel
/Erik
On 2014-11-20 18:25, Daniel Fuchs
Thanks for reviewing these changes Joe.
On 21/11/14 19:55, huizhe wang wrote:
Hi Chris,
The jaxp changes look good as well. Only a couple of debug info in
javax/xml/datatype/FactoryFinder.java and
javax/xml/parsers/FactoryFinder.java may be fixed. They were wrong
originally. You've fixed it in
Hi Erik,
thanks for having a look! I realized that I had forgot to remove one usage
of $HAS_CFLAG_DETECT_UNDEFINED_BEHAVIOR, please see new webrev at:
http://cr.openjdk.java.net/~ehelin/8065648/webrev.01/
On 2014-11-24, Erik Joelsson wrote:
I think it's a reasonable change to remove the flag
Right, it's not a question of our code hitting the check, it's the
compiler crashing on us. We can't have errors in the compiler we use.
Looks good to me. Don't forget to regenerate configure and also push the
closed version.
/Erik
On 2014-11-24 15:07, Erik Helin wrote:
Hi Erik,
thanks
Filed: https://bugs.openjdk.java.net/browse/JDK-8065791
On 11/13/2014 10:59 PM, Steven R. Loomis wrote:
Late to the party, but please note that the README-builds.html *still*
says that ccache is great and you should install it. Doesn't mention
*anything* about ccache being off by default or
On 20/11/2014 8:21 PM, Erik Joelsson wrote:
I think it's Import.gmk that isn't working well with non zipped debug
symbols on mac. The .dSYM file is actually a directory and the logic in
Import.gmk probably hasn't been exercised with that much.
Certainly some issues with Import.gmk eg it
