Re: RFR: JDK-8065911 Introduce EvalDebugWrapper for all Setup* macros

2014-11-25 Thread Magnus Ihse Bursie
On 2014-11-25 18:57, Erik Joelsson wrote: In ZipArchive.gmk, the file starts with comments referring to sjavac that look like they were copied from JavaCompilation.gmk. Which is exactly what is was. :-) Otherwise looks good. I still haven't tried EvalDebugWrapper but it looks really neat.

Re: RFR: JDK-8065911 Introduce EvalDebugWrapper for all Setup* macros

2014-11-25 Thread Erik Joelsson
In ZipArchive.gmk, the file starts with comments referring to sjavac that look like they were copied from JavaCompilation.gmk. Otherwise looks good. I still haven't tried EvalDebugWrapper but it looks really neat. /Erik On 2014-11-25 16:13, Magnus Ihse Bursie wrote: We should generalize the

RFR: JDK-8065913 Various improvements in SetupNativeCompilation

2014-11-25 Thread Magnus Ihse Bursie
This is a bag of fixes that has been developed in the build-infra forest as part of preparatory work for converting the hotspot repo and closed Oracle repos to the new build-infra structure. The fix includes: * Setup proper dependencies for Windows RC files (.res) * Make it easier to supp

RFR: JDK-8065911 Introduce EvalDebugWrapper for all Setup* macros

2014-11-25 Thread Magnus Ihse Bursie
We should generalize the use of EvalDebugWrapper to all our SetupFoo functions. This will allow better debug possibilities of the build system. It will also, as a side effect, allow us to use proper whitespace around the parameters when calling this function. I also broke out the SetupZipArchi