Hi,
Please review http://cr.openjdk.java.net/~sundar/8066146/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8066146
Thanks,
-Sundar
Hello,
Should:
1140 NASHORNAPI2COREAPI := ../../$(JDKJRE2COREAPI)
be?
1140 NASHORNAPI2COREAPI := ../$(JDKJRE2COREAPI)
I assume it's relative to DOCDIR defined on the line above.
/Erik
On 2014-11-28 11:41, A. Sundararajan wrote:
Hi,
Please review
Hi build-dev,
Would appreciate a review of this small patch that addresses JDK-8066138.
The patch removes trailing whitespace in javadoc titles such as Overview (Java
Platform SE 7 )
Link to webrev:
http://cr.openjdk.java.net/~alundblad/8066138/
Link to bug report:
Hi,
Thanks for catching that!
Please review updated http://cr.openjdk.java.net/~sundar/8066146/webrev.01/
Thanks,
-Sundar
Erik Joelsson wrote:
Hello,
Should:
1140 NASHORNAPI2COREAPI := ../../$(JDKJRE2COREAPI)
be?
1140 NASHORNAPI2COREAPI := ../$(JDKJRE2COREAPI)
I assume it's relative to
Looks good to me.
/Erik
On 2014-11-28 12:50, A. Sundararajan wrote:
Hi,
Thanks for catching that!
Please review updated
http://cr.openjdk.java.net/~sundar/8066146/webrev.01/
Thanks,
-Sundar
Erik Joelsson wrote:
Hello,
Should:
1140 NASHORNAPI2COREAPI := ../../$(JDKJRE2COREAPI)
be?
+1
On Nov 28, 2014, at 6:41 AM, A. Sundararajan
sundararajan.athijegannat...@oracle.com wrote:
Hi,
Please review http://cr.openjdk.java.net/~sundar/8066146/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8066146
Thanks,
-Sundar
+1
On 28 Nov 2014, at 12:50, A. Sundararajan
sundararajan.athijegannat...@oracle.com wrote:
Hi,
Thanks for catching that!
Please review updated http://cr.openjdk.java.net/~sundar/8066146/webrev.01/
Thanks,
-Sundar
Erik Joelsson wrote:
Hello,
Should:
1140
On 2014-11-28 11:41, A. Sundararajan wrote:
Hi,
Please review http://cr.openjdk.java.net/~sundar/8066146/webrev.00/
for https://bugs.openjdk.java.net/browse/JDK-8066146
Thanks,
-Sundar
Is it by intention that you do not add $(NASHORNAPI_PKGS) to NON_CORE_PKGS?
/Magnus
Hi Sundar,
On 11/28/2014 2:41 AM, A. Sundararajan wrote:
Hi,
Please review http://cr.openjdk.java.net/~sundar/8066146/webrev.00/
for https://bugs.openjdk.java.net/browse/JDK-8066146
Is jdk.nashorn.api.scripting a supported API? It looks like some
classes are defined for JEP 202 [1] and