Re: RFR: JDK-8066761: Investigate -sourcepath usage when compiling java

2014-12-08 Thread Jonathan Gibbons
On 12/08/2014 06:53 AM, Magnus Ihse Bursie wrote: On 2014-12-08 13:09, Erik Joelsson wrote: Hello, Please review this fix, removing the use of -sourcepath when compiling java sources. For a long time, all java compilation lines have included a -sourcepath parameter. We have now concluded th

Re: RFR: JDK-8066828: configure fails if it's set --with-boot-jdk to use JDK 9 modular image

2014-12-08 Thread Magnus Ihse Bursie
On 2014-12-08 12:09, Erik Joelsson wrote: Hello, Please review this fix to configure, removing the requirement that the bootjdk has an rt.jar. In the modular images change, we already did away with using the rt.jar in the boot jdk. With this fix, it becomes possible to use a modular image as

Re: RFR: JDK-8066752: Remove space after -L on linker lines

2014-12-08 Thread Magnus Ihse Bursie
On 2014-12-08 14:53, Erik Joelsson wrote: Hello, Please review this small patch, removing all instances of space following '-L' on linker lines. With certain versions of XCode on Macosx, this results in an error. Most of these instances were introduced with the modular images change. I chose

Re: RFR: JDK-8066761: Investigate -sourcepath usage when compiling java

2014-12-08 Thread Magnus Ihse Bursie
On 2014-12-08 13:09, Erik Joelsson wrote: Hello, Please review this fix, removing the use of -sourcepath when compiling java sources. For a long time, all java compilation lines have included a -sourcepath parameter. We have now concluded that in some cases it's just wrong and the rest of th

Re: RFR: JDK-8066761: Investigate -sourcepath usage when compiling java

2014-12-08 Thread Alan Bateman
On 08/12/2014 12:09, Erik Joelsson wrote: Hello, Please review this fix, removing the use of -sourcepath when compiling java sources. For a long time, all java compilation lines have included a -sourcepath parameter. We have now concluded that in some cases it's just wrong and the rest of th

RFR: JDK-8066752: Remove space after -L on linker lines

2014-12-08 Thread Erik Joelsson
Hello, Please review this small patch, removing all instances of space following '-L' on linker lines. With certain versions of XCode on Macosx, this results in an error. Most of these instances were introduced with the modular images change. I chose to remove everything I could find, even if

Re: RFR: JDK-8066761: Investigate -sourcepath usage when compiling java

2014-12-08 Thread Joel Borggrén-Franck
Hi Erik, Looks sane to me, but I’m not a build-dev reviewer. cheers /Joel > On 8 dec 2014, at 13:09, Erik Joelsson wrote: > > Hello, > > Please review this fix, removing the use of -sourcepath when compiling java > sources. For a long time, all java compilation lines have included a > -sour

RFR: JDK-8066761: Investigate -sourcepath usage when compiling java

2014-12-08 Thread Erik Joelsson
Hello, Please review this fix, removing the use of -sourcepath when compiling java sources. For a long time, all java compilation lines have included a -sourcepath parameter. We have now concluded that in some cases it's just wrong and the rest of the cases it's just unnecessary. I have tri

Re: How to cross compile OpenJDK for Arm32?

2014-12-08 Thread David Holmes
On 8/12/2014 7:10 PM, ChenLong wrote: Hi Apologize if this is not the right place to ask. I want to try OpenJDK8 on Armv7. Is there a guideline on how to cross compile OpenJDK8 for Armv7? And if not, could someone share some experiences? I went through the README-builds.html and did not find a

RFR: JDK-8066828: configure fails if it's set --with-boot-jdk to use JDK 9 modular image

2014-12-08 Thread Erik Joelsson
Hello, Please review this fix to configure, removing the requirement that the bootjdk has an rt.jar. In the modular images change, we already did away with using the rt.jar in the boot jdk. With this fix, it becomes possible to use a modular image as boot jdk when building JDK 9. Bug: https:

How to cross compile OpenJDK for Arm32?

2014-12-08 Thread ChenLong
Hi Apologize if this is not the right place to ask. I want to try OpenJDK8 on Armv7. Is there a guideline on how to cross compile OpenJDK8 for Armv7? And if not, could someone share some experiences? I went through the README-builds.html and did not find any clues for cross compiling. Thanks Ch