Re: RFR(s): 8067631: hgforest.sh mishandles arguments with spaces

2014-12-16 Thread Stuart Marks
Hi Chris, thanks for the extra testing. s'marks On 12/16/14 9:58 AM, Chris Hegarty wrote: Looks good to me Stuart. I tried the patch on Mac and Linux, both with the OpenJDK set of repos and with Oracle’s additional ones, and all seems ok. -Chris. On 16 Dec 2014, at 17:38, Stuart Marks wrot

Re: RFR(s): 8067631: hgforest.sh mishandles arguments with spaces

2014-12-16 Thread Chris Hegarty
Looks good to me Stuart. I tried the patch on Mac and Linux, both with the OpenJDK set of repos and with Oracle’s additional ones, and all seems ok. -Chris. On 16 Dec 2014, at 17:38, Stuart Marks wrote: > Hi all, > > Please review this change to hgforest.sh, to preserve argument quoting when

RFR(s): 8067631: hgforest.sh mishandles arguments with spaces

2014-12-16 Thread Stuart Marks
Hi all, Please review this change to hgforest.sh, to preserve argument quoting when passing arguments with spaces through to the hg command. Changeset (in the new sandbox repo): http://hg.openjdk.java.net/jdk9/sandbox/rev/886037762070 Bug: https://bugs.openjdk.java.net/browse/JDK-80

Re: RFR: JDK-8067254: No debug symbols in JPRT Windows builds

2014-12-16 Thread Magnus Ihse Bursie
Sorry about that. It was supposed to be a private reply to Erik only, but I hit "reply all" by mistake. /Magnus > 14 dec 2014 kl. 23:12 skrev Tim Bell : > > Agreed or Överens according to google translate :-) > > Tim > > >> On 12/14/14 12:46, Magnus Ihse Bursie wrote: >> Desto större skäl

Re: 8067442: Tests using -Xshare:dump does not work with 'make test'

2014-12-16 Thread David Holmes
On 16/12/2014 7:50 PM, Erik Helin wrote: On 2014-12-16, David Holmes wrote: On 16/12/2014 1:20 AM, Erik Helin wrote: Hi all, this patch changes the dependency for the target `test` in make/Main.gmk >from exploded-image to jimages. This is needed because PRODUCT_HOME in `make test` needs to b

Re: 8067442: Tests using -Xshare:dump does not work with 'make test'

2014-12-16 Thread Erik Helin
On 2014-12-16, David Holmes wrote: > On 16/12/2014 1:20 AM, Erik Helin wrote: > >Hi all, > > > >this patch changes the dependency for the target `test` in make/Main.gmk > >from exploded-image to jimages. This is needed because PRODUCT_HOME in > >`make test` needs to be set to a full JDK image direc