Re: JDK 9 RFR of JDK-8072734: Turn on doclint checking in the build of modules in the jdk repo

2015-03-11 Thread joe darcy
Hi Jon, On 3/11/2015 8:04 PM, Jonathan Gibbons wrote: Joe, This is excellent work. Thank you. It builds on previous excellent work getting doclint into the platform :-) Can I suggest that until we achieve perfection, we keep a status table somewhere listing the current level of goodness

Re: JDK 9 RFR of JDK-8072734: Turn on doclint checking in the build of modules in the jdk repo

2015-03-11 Thread Jonathan Gibbons
Joe, This is excellent work. Can I suggest that until we achieve perfection, we keep a status table somewhere listing the current level of goodness on a per-module basis, meaning, in a more digestible form than crawling through makefiles. -- Jon On 03/11/2015 07:53 PM, joe darcy wrote: Hel

JDK 9 RFR of JDK-8072734: Turn on doclint checking in the build of modules in the jdk repo

2015-03-11 Thread joe darcy
Hello, With package filtering of doclint checking now available (JDK-8071851: Provide filtering of doclint checking based on packages), the time has come to enable a subset of doclint checking in the main build for java.* and javax.* packages. First, there is the simple subtask of doing this

Re: RFR: JDK-8074988: Reduce boilerplate in Setup* macro definitions

2015-03-11 Thread Tim Bell
Erik: (including nashorn-dev since a makefile there is touched) When creating a Setup* macro that takes named parameters, like SetupJavaCompilation, there is a lot of copied boilerplate code that needs to be written. The code, which is essentially copied for all these macro definitions, hand

Re: RFR: 8074910 hgforest.sh needs an option to bring over a smaller set of extra repos

2015-03-11 Thread Chris Hegarty
Thank you Phil, doing something along the lines of this has been on my list for a while now. On 11/03/15 08:55, Erik Joelsson wrote: Hello, Line 187 looks like debug output left about. Perhaps also 219 but I think that echo makes sense to keep. Otherwise looks good to me. +1. -Chris. /Er

Re: RFR: 8074910 hgforest.sh needs an option to bring over a smaller set of extra repos

2015-03-11 Thread Erik Joelsson
Hello, Line 187 looks like debug output left about. Perhaps also 219 but I think that echo makes sense to keep. Otherwise looks good to me. /Erik On 2015-03-10 23:44, Phil Race wrote: Right now to get the extra repos you do sh get_source.sh http://server.whatits.org This gets more than mos