Re: RFR: JDK-8072897: File sawindbg.dll has incorrect file version

2015-03-17 Thread David Holmes
On 18/03/2015 12:36 AM, Tim Bell wrote: Erik: Please review this minor fix for sawindbg.dll. It is currently not having version info added (the RC stuff) which all other dlls have. Here is a minimal fix that basically adds the same values as for jvm.dll except for the filename (FNAME) field. (

Re: [8u-dev] RFR: 8075400: Cannot build hotspot in jdk8u on OSX 10.10 (Yosemite)

2015-03-17 Thread David Holmes
Hi David On 18/03/2015 8:54 AM, David DeHaven wrote: Fairly minor build system bug fix on Mac. In short, the -mmacosx-version-min argument is never being passed to the linker, where it's actually needed to assert the minimum OS version requirement in the final Mach-O binary. This was causing

Windows configure error : LZMAPATH

2015-03-17 Thread Phil Race
I'll admit its been a few weeks since I've build JDK on Windows except via jprt but now I can't get past configure and I don't know why its resolving a variable that I didn't set instead of looking on my path .. checking Checking for install src... not found, cannot build installer checking fo

[8u-dev] RFR: 8075400: Cannot build hotspot in jdk8u on OSX 10.10 (Yosemite)

2015-03-17 Thread David DeHaven
Fairly minor build system bug fix on Mac. In short, the -mmacosx-version-min argument is never being passed to the linker, where it's actually needed to assert the minimum OS version requirement in the final Mach-O binary. This was causing ld to fail when building on 10.10. I've no idea why it's

Re: [OpenJDK 2D-Dev] RFR: 8075277 : JDK is still building X11 related Java files on OSX

2015-03-17 Thread Magnus Ihse Bursie
On 2015-03-17 13:06, Erik Joelsson wrote: Hello Phil, A minor style issue. We would appreciate if the java.desktop_EXCLUDES followed the same style as java.desktop_EXCLUDE_FILES, with 4 spaces indent and a line break at the start and end, like this: java.desktop_EXCLUDES += \ sun/awt/X11

Re: RFR: JDK-8072897: File sawindbg.dll has incorrect file version

2015-03-17 Thread Tim Bell
Erik: Please review this minor fix for sawindbg.dll. It is currently not having version info added (the RC stuff) which all other dlls have. Here is a minimal fix that basically adds the same values as for jvm.dll except for the filename (FNAME) field. (Nmake is confusing) Bug: https://bugs

Re: RFR: JDK-8075176 DISABLED_WARNINGS caused C++ compiler flags to get lost

2015-03-17 Thread Tim Bell
On 03/17/15 06:15, Erik Joelsson wrote: Looks good. Nice to find the root cause of this. /Erik On 2015-03-17 13:58, Magnus Ihse Bursie wrote: It turned out that the fix for JDK-8074796 (Disabling warnings on clang triggers compiler bug for libunpack) did not address the core issue. In fact,

Re: RFR: JDK-8075176 DISABLED_WARNINGS caused C++ compiler flags to get lost

2015-03-17 Thread Tim Bell
Magnus: Looks good to me as well. Tim On 03/17/15 06:15, Erik Joelsson wrote: Looks good. Nice to find the root cause of this. /Erik On 2015-03-17 13:58, Magnus Ihse Bursie wrote: It turned out that the fix for JDK-8074796 (Disabling warnings on clang triggers compiler bug for libunpack) di

RFR: JDK-8072897: File sawindbg.dll has incorrect file version

2015-03-17 Thread Erik Joelsson
Hello, Please review this minor fix for sawindbg.dll. It is currently not having version info added (the RC stuff) which all other dlls have. Here is a minimal fix that basically adds the same values as for jvm.dll except for the filename (FNAME) field. (Nmake is confusing) Bug: https://bug

Re: RFR: JDK-8075176 DISABLED_WARNINGS caused C++ compiler flags to get lost

2015-03-17 Thread Kumar Srinivasan
Hi Magnus, *||make/common/NativeCompilation.gmk* Typo: s/explicitely/explicitly/ I don't quite understand the changes ;) but Mr ErikJ has done the honors. :-) Thanks Kumar On 3/17/2015 5:58 AM, Magnus Ihse Bursie wrote: It turned out that the fix for JDK-8074796 (Disabling warnings on

Re: RFR: JDK-8075176 DISABLED_WARNINGS caused C++ compiler flags to get lost

2015-03-17 Thread Erik Joelsson
Looks good. Nice to find the root cause of this. /Erik On 2015-03-17 13:58, Magnus Ihse Bursie wrote: It turned out that the fix for JDK-8074796 (Disabling warnings on clang triggers compiler bug for libunpack) did not address the core issue. In fact, there was no compiler bug in clang. (Sur

RFR: JDK-8075176 DISABLED_WARNINGS caused C++ compiler flags to get lost

2015-03-17 Thread Magnus Ihse Bursie
It turned out that the fix for JDK-8074796 (Disabling warnings on clang triggers compiler bug for libunpack) did not address the core issue. In fact, there was no compiler bug in clang. (Surprise! :-)) Instead, what happened was that the makefile changes that turned on the warning flags, also

Re: [OpenJDK 2D-Dev] RFR: 8075277 : JDK is still building X11 related Java files on OSX

2015-03-17 Thread Erik Joelsson
Hello Phil, A minor style issue. We would appreciate if the java.desktop_EXCLUDES followed the same style as java.desktop_EXCLUDE_FILES, with 4 spaces indent and a line break at the start and end, like this: java.desktop_EXCLUDES += \ sun/awt/X11 \ sun/java2d/x11 \ sun/java2d/jule