Re: RFR (XS) Enable -Woverloaded-virtual for GCC in the HotSpot build

2015-03-19 Thread Volker Simonis
Hi Mikael, the change looks good (and I think it is really reasonable to have this warning). I've also checked that our ancient gcc 4.1.2 already supports this option:) Regards, Volker On Thu, Mar 19, 2015 at 2:56 PM, Mikael Gerdin wrote: > Hi, > > I recently ran into a compiler warning which

Re: RFR(XS): 8075515: AIX: cleanup xlc options and use -bernotok to detect missing symbols at build time

2015-03-19 Thread Erik Joelsson
Looks good to me. I can push it. /Erik On 2015-03-19 15:17, Volker Simonis wrote: Hi, can somebody please review and sponsor this change (because it requires re-generation of generated-configure.sh): http://cr.openjdk.java.net/~simonis/webrevs/2015/8075515/ https://bugs.openjdk.java.net/brows

Re: RFR (XS) Enable -Woverloaded-virtual for GCC in the HotSpot build

2015-03-19 Thread Erik Joelsson
Looks good to me. /Erik On 2015-03-19 14:58, Mikael Gerdin wrote: Oh, and the bug id is 8075511 https://bugs.openjdk.java.net/browse/JDK-8075511 /Mikael On 2015-03-19 14:56, Mikael Gerdin wrote: Hi, I recently ran into a compiler warning which is enabled by default in Solaris Studio, since

RFR(XS): 8075515: AIX: cleanup xlc options and use -bernotok to detect missing symbols at build time

2015-03-19 Thread Volker Simonis
Hi, can somebody please review and sponsor this change (because it requires re-generation of generated-configure.sh): http://cr.openjdk.java.net/~simonis/webrevs/2015/8075515/ https://bugs.openjdk.java.net/browse/JDK-8075515 This change adds -bernotok (which is xlc's equivalent for gcc's '-z def

Re: RFR: JDK-8075495: Update jtreg bin location in configure

2015-03-19 Thread Alan Bateman
On 19/03/2015 14:04, Magnus Ihse Bursie wrote: The comment above is not needed anymore. How does this work with different versions of JTReg? Do we need to support older versions with the win32 directory still in place? Older versions of jtreg can't be used to run some of the tests today. We

Re: RFR: JDK-8075495: Update jtreg bin location in configure

2015-03-19 Thread Magnus Ihse Bursie
The comment above is not needed anymore. How does this work with different versions of JTReg? Do we need to support older versions with the win32 directory still in place? /Magnus On 2015-03-19 10:56, Erik Joelsson wrote: Jtreg removed the platform specific bin directories. Configure still p

Re: RFR (XS) Enable -Woverloaded-virtual for GCC in the HotSpot build

2015-03-19 Thread Mikael Gerdin
Oh, and the bug id is 8075511 https://bugs.openjdk.java.net/browse/JDK-8075511 /Mikael On 2015-03-19 14:56, Mikael Gerdin wrote: Hi, I recently ran into a compiler warning which is enabled by default in Solaris Studio, since HotSpot builds with warnings-as-errors this failed the build only whe

RFR (XS) Enable -Woverloaded-virtual for GCC in the HotSpot build

2015-03-19 Thread Mikael Gerdin
Hi, I recently ran into a compiler warning which is enabled by default in Solaris Studio, since HotSpot builds with warnings-as-errors this failed the build only when I got to the Solaris build. To catch this issue earlier for me (and a lot of others who use Linux as their preferred developmen

Re: RFR: JDK-8075495: Update jtreg bin location in configure

2015-03-19 Thread Alan Bateman
On 19/03/2015 09:56, Erik Joelsson wrote: Jtreg removed the platform specific bin directories. Configure still picks up the jtreg launcher from win32/bin. This needs to be fixed. This patch is for jdk9. The same patch applies to jdk8u-dev and I would like to fix it there too. Bug: https://bug

RFR: JDK-8075495: Update jtreg bin location in configure

2015-03-19 Thread Erik Joelsson
Jtreg removed the platform specific bin directories. Configure still picks up the jtreg launcher from win32/bin. This needs to be fixed. This patch is for jdk9. The same patch applies to jdk8u-dev and I would like to fix it there too. Bug: https://bugs.openjdk.java.net/browse/JDK-8075495 Patch