RFR: JDK-8077847 Better handling of Windows executable manifest version

2015-04-15 Thread Magnus Ihse Bursie
On windows, many executables have an assembly manifest embedded. This sets among other things the JDK version. Our current handling of this is sub-optimal, using template files that are modified at build time. Instead, a command line option to MT, the manifest processor, can be used. At

Mac OS X build errors missing instancetype + further issues just after building jdk.xml.ws

2015-04-15 Thread Martijn Verburg
Hi all, Mac OS X 10.10.3, latest Xcode (6.3), using GCC 4.8 After getting past the defined(__OPENBSD__) bug I'm running into a host of new errors starting with: /Users/karianna/Documents/workspace/AdoptOpenJDK_projects/jdk9/hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m:26:

Re: RFR: JDK-8077814: Add .DELETE_ON_ERROR to makefiles

2015-04-15 Thread Tim Bell
Erik: On 2015-04-15 11:41, Erik Joelsson wrote: Please review this small change which will improve incremental build reliability. By defining the pseudo target .DELETE_ON_ERROR, make will automatically remove the target of a rule if the recipe fails or is interrupted (typically ctrl-c). By

Re: jdk9 windows build failure

2015-04-15 Thread Phil Race
If RE are currently building with 3.81 then either not all 3.81's are the same or there's something more subtle going on, since I see this failure when cloning the forests directly from RE promoted builds. -phil. On 4/14/15 4:44 PM, David Katleman wrote: We went through this exercise in

Re: Mac OS X build errors missing instancetype + further issues just after building jdk.xml.ws

2015-04-15 Thread David DeHaven
Mac OS X 10.10.3, latest Xcode (6.3), using GCC 4.8 After getting past the defined(__OPENBSD__) bug I'm running into a host of new errors starting with: /Users/karianna/Documents/workspace/AdoptOpenJDK_projects/jdk9/hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m:26:

Re: RFR: JDK-8077824: Introduce DefineNativeToolchain to handle toolchain configurations

2015-04-15 Thread Tim Bell
Erik: The macro SetupNativeCompilation handles various overrides of the compiler and linker used for compilation. There is also a LANG option, which implies that it needs to be told if it's compiling C or C++ when in reality, this is handled automatically. The real purpose of the LANG option

Re: RFR: JDK-8077847 Better handling of Windows executable manifest version

2015-04-15 Thread Tim Bell
On 04/15/15 06:12, Magnus Ihse Bursie wrote: On windows, many executables have an assembly manifest embedded. This sets among other things the JDK version. Our current handling of this is sub-optimal, using template files that are modified at build time. Instead, a command line option to MT,

Re: RFR: JDK-8072023: Investigate and upgrade the minimum supported gnumake for JDK 9, from 3.81 to 4.0

2015-04-15 Thread Tim Bell
Erik: Please review this change to README-builds.html. I have updated all references to the GNU make version to specify that we recommend 4.0 or later on Windows. Cygwin has been shipping with 4.x for a long time now and we have been using it internally since the source code layout change.

Re: RFR: JDK-8072023: Investigate and upgrade the minimum supported gnumake for JDK 9, from 3.81 to 4.0

2015-04-15 Thread David Katleman
The doc change is fine. You need a corresponding autoconf update to verify that 4.0 or later is being used on windows builds, to prevent cryptic errors like Phil was running into. The windows build should fail in configure if it finds a gnumake older than 4.0 Thanks

JDK 9 RFR of JDK-8077912: Turn on doclint checking for more modules

2015-04-15 Thread joe darcy
Hello, Please review the patch below to enable doclint checking on more modules in the JDK 9 build: JDK-8077912: Turn on doclint checking for more modules http://cr.openjdk.java.net/~darcy/8077912.0/ (Some doclint cleanup is needed on java.management and java.transaction before

Re: BSD variables not declared? (jdk8 jdk 9 builds)

2015-04-15 Thread David Holmes
Hi Kim, On 16/04/2015 2:26 PM, Kim Barrett wrote: This might be of interest: https://gcc.gnu.org/gcc-4.4/porting_to.html Preprocessor conditionals always evaluated Also see this: http://lists.boost.org/Archives/boost/2011/08/184657.php — This has come up before. The problem is with code

Re: BSD variables not declared? (jdk8 jdk 9 builds)

2015-04-15 Thread Kim Barrett
On Apr 14, 2015, at 3:42 AM, David Holmes david.hol...@oracle.com wrote: On 14/04/2015 5:24 PM, Magnus Ihse Bursie wrote: On 2015-04-12 17:01, Martijn Verburg wrote: Hi all, On Mac OS X 10.10.2 using gcc 4.8 run make clean images When compiling either jdk8 or jdk9 from scratch I get the

Re: BSD variables not declared? (jdk8 jdk 9 builds)

2015-04-15 Thread Kim Barrett
This might be of interest: https://gcc.gnu.org/gcc-4.4/porting_to.html Preprocessor conditionals always evaluated Also see this: http://lists.boost.org/Archives/boost/2011/08/184657.php — This has come up before. The problem is with code like this: #if !defined(SOMETHING) #elif

RFR: JDK-8072023: Investigate and upgrade the minimum supported gnumake for JDK 9, from 3.81 to 4.0

2015-04-15 Thread Erik Joelsson
Please review this change to README-builds.html. I have updated all references to the GNU make version to specify that we recommend 4.0 or later on Windows. Cygwin has been shipping with 4.x for a long time now and we have been using it internally since the source code layout change. Using

RFR: JDK-8077824: Introduce DefineNativeToolchain to handle toolchain configurations

2015-04-15 Thread Erik Joelsson
The macro SetupNativeCompilation handles various overrides of the compiler and linker used for compilation. There is also a LANG option, which implies that it needs to be told if it's compiling C or C++ when in reality, this is handled automatically. The real purpose of the LANG option is just

RFR: JDK-8077814: Add .DELETE_ON_ERROR to makefiles

2015-04-15 Thread Erik Joelsson
Please review this small change which will improve incremental build reliability. By defining the pseudo target .DELETE_ON_ERROR, make will automatically remove the target of a rule if the recipe fails or is interrupted (typically ctrl-c). By doing this, the target is automatically rebuilt on

Re: RFR: JDK-8077814: Add .DELETE_ON_ERROR to makefiles

2015-04-15 Thread Magnus Ihse Bursie
On 2015-04-15 11:41, Erik Joelsson wrote: Please review this small change which will improve incremental build reliability. By defining the pseudo target .DELETE_ON_ERROR, make will automatically remove the target of a rule if the recipe fails or is interrupted (typically ctrl-c). By doing