On May 22, 10:54am, marti...@google.com (Martin Buchholz) wrote:
-- Subject: Re: RFR 9: 8074818: Resolve disabled warnings for libjava
| I agree it's a good idea to increase safety by replacing calls to *printf
| with calls to *nprintf, BUT when we do so we should also add debugging
| assertions t
The double assignment to i is stupid (a "dead store") - remove one of them.
63 size_t i = 0;
64 for (i = 1; i < len; i++) {
I agree it's a good idea to increase safety by replacing calls to *printf
with calls to *nprintf, BUT when we do so we should also add debugging
assertions that the message fits into the buffer.
-sprintf(errmsg, format, errnum, detail);
+snprintf(errmsg, fmtsize, IOE_FORMAT, errnum, detail
It's a good idea to order include statements by system dependencies, jdk
dependencies, implementation helpers, BUT order of include statements
should never ever matter. If it does, then we have a bug that should be
fixed. Every header file should be independently includable, and C files
should on
On 05/22/2015 08:09 AM, Alan Bateman wrote:
On 22/05/2015 13:55, Chris Hegarty wrote:
:
I think it could be done either way.
Valerie - have you considered not pushing the services configuration
files with this change? With the change then the java.security
configuration is still class nam
I plan to have review comments later today.
On Thu, May 21, 2015 at 2:09 PM, Roger Riggs wrote:
> Please review these native code and build changes to clear compilation
> warnings.
> Most are due to mixing unsigned types with signed types or providing
> the correct type to an invoked function.
>
JDK-8027584 disabled ccache by default, I gather because it doesn't work in
Cygwin, and secondarily because of vague general problems with it.
The documentation (README-builds.html) still unambiguously endorses it,
although doesn't say anything about how to turn it on (configure with
--enable-c
On 22/05/2015 13:55, Chris Hegarty wrote:
:
I think it could be done either way.
Valerie - have you considered not pushing the services configuration
files with this change? With the change then the java.security
configuration is still class names, not provider names, so the fallback
should
Hi Alan,
The change to make the assert about the build numbers in getVersionInfo
should be a different issue.
Perhaps it makes sense to do that as part of the JEP 223: New
Version-String Scheme
that is specific to the Oracle JDK.
Thanks, Roger
On 5/22/2015 2:55 AM, Alan Bateman wrote:
O
On 22.5.2015 14:52, Maurizio Cimadamore wrote:
Excellent work.
I think the comment in CreateSymbols could be made clearer w.r.t. Probe
- i.e. that Probe should be ran on top of the JDK N - i.e.
/bin/java Probe --> classes-8
/bin/java Probe --> classes-7
/bin/java Probe --> classes-7
etc.
Sur
On 22/05/15 07:58, Erik Joelsson wrote:
On 2015-05-22 02:46, Mandy Chung wrote:
I’m including build-dev and we need to ask for Erik and Magnus advice
what’s the best way to work around this.
Erik, Magnus,
Security providers now become service providers. They are
provided from 11 different
Excellent work.
I think the comment in CreateSymbols could be made clearer w.r.t. Probe
- i.e. that Probe should be ran on top of the JDK N - i.e.
/bin/java Probe --> classes-8
/bin/java Probe --> classes-7
/bin/java Probe --> classes-7
etc.
Maurizio
On 22/05/15 13:38, Jan Lahoda wrote:
Hi
Hi,
I've uploaded a new iteration of the patch(es):
top-level repository:
http://cr.openjdk.java.net/~jlahoda/8072480/webrev.01/top-level/
langtools:
http://cr.openjdk.java.net/~jlahoda/8072480/webrev.01/langtools/
(besides full webrevs, there are also webrevs showing the differences
between .0
On 22.5.2015 08:49, Erik Joelsson wrote:
On 2015-05-21 21:59, mark.reinh...@oracle.com wrote:
2015/5/21 12:01 -0700, jan.lah...@oracle.com:
This is a patch adding a new option, -platform, to javac.
Patch for the top-level repository is here:
http://cr.openjdk.java.net/~jlahoda/8072480/webrev.
If you want a script/hack solution, you should be able to do something
like this:
make java.base-java-only JDK_FILTER=package/that/you/changed && make
jimages-only
That's likely the best I can do. If you need a real image, it has to be
linked from scratch each time. If the exploded image is
15 matches
Mail list logo