Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-25 Thread Mandy Chung
> On May 25, 2015, at 3:00 AM, Alan Bateman wrote: > > On 25/05/2015 09:53, Chris Hegarty wrote: >> >> If it is agreed that these files are needed, then I can look at expanding >> the ImageBuilder to do concatenate them. > I agree with Mandy's point that java.security should be change to list

Re: RFR: libdt_socket: Build failed with VS2013 SP4

2015-05-25 Thread Tim Bell
Erik: On 05/25/15 05:11, Magnus Ihse Bursie wrote: On 2015-05-25 12:17, Erik Joelsson wrote: Hello, In Visual Studio 2013 SP4, MS decided to deprecate gethostbyname in favor of getaddrinfo(). We now have two different libraries using this function. In JDK-8077422 I added a workaround for lib

Re: RFR: libdt_socket: Build failed with VS2013 SP4

2015-05-25 Thread Magnus Ihse Bursie
On 2015-05-25 12:17, Erik Joelsson wrote: Hello, In Visual Studio 2013 SP4, MS decided to deprecate gethostbyname in favor of getaddrinfo(). We now have two different libraries using this function. In JDK-8077422 I added a workaround for libhprof. Now we also have the problem in libdt_socket.

Re: RFR: libdt_socket: Build failed with VS2013 SP4

2015-05-25 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 25 maj 2015, at 12:17, Erik Joelsson wrote: > > Hello, > > In Visual Studio 2013 SP4, MS decided to deprecate gethostbyname in favor of > getaddrinfo(). We now have two different libraries using this function. In > JDK-8077422 I added a workaround for libhpr

RFR: libdt_socket: Build failed with VS2013 SP4

2015-05-25 Thread Erik Joelsson
Hello, In Visual Studio 2013 SP4, MS decided to deprecate gethostbyname in favor of getaddrinfo(). We now have two different libraries using this function. In JDK-8077422 I added a workaround for libhprof. Now we also have the problem in libdt_socket. This time I've opted to add the preproces

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-25 Thread Alan Bateman
On 25/05/2015 09:53, Chris Hegarty wrote: If it is agreed that these files are needed, then I can look at expanding the ImageBuilder to do concatenate them. I agree with Mandy's point that java.security should be change to list the provider name rather than the class name. If that happens then

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-25 Thread Chris Hegarty
On 25/05/15 09:42, Erik Joelsson wrote: On 2015-05-22 18:53, Mandy Chung wrote: On 05/22/2015 08:09 AM, Alan Bateman wrote: On 22/05/2015 13:55, Chris Hegarty wrote: : I think it could be done either way. Valerie - have you considered not pushing the services configuration files with thi

Re: Status of ccache

2015-05-25 Thread Chris Hegarty
On 25/05/15 09:38, Erik Joelsson wrote: On 2015-05-22 17:47, Dan Smith wrote: JDK-8027584 disabled ccache by default, I gather because it doesn't work in Cygwin, and secondarily because of vague general problems with it. The documentation (README-builds.html) still unambiguously endorses it, a

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-25 Thread Erik Joelsson
On 2015-05-22 18:53, Mandy Chung wrote: On 05/22/2015 08:09 AM, Alan Bateman wrote: On 22/05/2015 13:55, Chris Hegarty wrote: : I think it could be done either way. Valerie - have you considered not pushing the services configuration files with this change? With the change then the java.

Re: Status of ccache

2015-05-25 Thread Erik Joelsson
On 2015-05-22 17:47, Dan Smith wrote: JDK-8027584 disabled ccache by default, I gather because it doesn't work in Cygwin, and secondarily because of vague general problems with it. The documentation (README-builds.html) still unambiguously endorses it, although doesn't say anything about how

Re: RFR 9: 8074818: Resolve disabled warnings for libjava

2015-05-25 Thread Magnus Ihse Bursie
On 2015-05-22 16:02, Roger Riggs wrote: Hi Alan, The change to make the assert about the build numbers in getVersionInfo should be a different issue. Perhaps it makes sense to do that as part of the JEP 223: New Version-String Scheme that is specific to the Oracle JDK. The current JEP-223 s

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-25 Thread Magnus Ihse Bursie
On 2015-05-22 14:38, Jan Lahoda wrote: Hi, I've uploaded a new iteration of the patch(es): top-level repository: http://cr.openjdk.java.net/~jlahoda/8072480/webrev.01/top-level/ langtools: http://cr.openjdk.java.net/~jlahoda/8072480/webrev.01/langtools/ (besides full webrevs, there are also web

Re: Status of ccache

2015-05-25 Thread Magnus Ihse Bursie
On 2015-05-22 17:47, Dan Smith wrote: JDK-8027584 disabled ccache by default, I gather because it doesn't work in Cygwin, and secondarily because of vague general problems with it. The documentation (README-builds.html) still unambiguously endorses it, although doesn't say anything about how t

Re: make[2]: *** No rule to make target..'/home/*/...needed by jtreg_tests

2015-05-25 Thread Magnus Ihse Bursie
On 2015-05-20 17:15, Erik Joelsson wrote: It seems jdk/test/Makefile is still looking for j2sdk-image as a fallback default, but it has been changed to be just images/jdk. If you run tests from the top level that shouldn't happen. Alternatively you can specify PRODUCT_HOME=/path/to/your/jdk/ima