Re: RFR: JDK-8080679: Include jline in JDK for Java and JavaScript REPLs

Hi Erik, Thanks for the comments. Yes, I copied an existing file, and -DUSE_MMAP seems unnecessary. I'll implement your suggestions. Thanks, Jan On 22.6.2015 10:25, Erik Joelsson wrote: Hello Jan, Build changes look mostly ok. Some notes: * "$(CFLAGS_WARNINGS_ARE_ERRORS)", which should

Re: RFR: JDK-8080679: Include jline in JDK for Java and JavaScript REPLs

Hello Jan, Build changes look mostly ok. Some notes: * "$(CFLAGS_WARNINGS_ARE_ERRORS)", which should not be used anymore. Warnings are already treated as errors globally. * There should not be a need to add "-I$(INCLUDEDIR) -I$(JDK_OUTPUTDIR)/include/$(OPENJDK_TARGET_OS)" to cflags. INCLUDED