Looks okay to me.
Thanks,
David
On 26/06/2015 11:53 PM, Erik Joelsson wrote:
Hello,
Please review this change for the Oracle internal JPRT configuration for
building jdk9. This change flips the switch for JPRT to start using
devkits for building jdk9 on Windows and Macosx, instead of preinstal
Erik:
Please review this change for the Oracle internal JPRT configuration
for building jdk9. This change flips the switch for JPRT to start
using devkits for building jdk9 on Windows and Macosx, instead of
preinstalled versions of Visual Studio and Xcode. The versions of the
compilers stay t
Hello,
Please review this change for the Oracle internal JPRT configuration for
building jdk9. This change flips the switch for JPRT to start using
devkits for building jdk9 on Windows and Macosx, instead of preinstalled
versions of Visual Studio and Xcode. The versions of the compilers stay
Hi Andrew,
we are building nightly on Solaris 11 / SPARC with SS 12u3 (see
http://cr.openjdk.java.net/~simonis/ppc-aix-port/ - you can click on
the traffic lights to download the complete build logs). And I've just
verified that I can build jdk9-dev myself.
Assuming you have the compiler (SS12u3)
Based on additional Jon's feedback, I made some minor tweaks to the
patch. An updated webrev is here:
http://cr.openjdk.java.net/~jlahoda/8072480/webrev.06/langtools/
A delta webrev is available under "Author comments".
Unless there are objections, I'll work on pushing this to jdk9/dev.
Thanks
On 26/06/2015 10:36 PM, Alan Bateman wrote:
On 26/06/2015 13:10, David Holmes wrote:
:
webrev: http://cr.openjdk.java.net/~dholmes/8129850/webrev/
This looks okay to me.
Thanks Alan, and Erik,
David
-Alan
On 26/06/2015 13:10, David Holmes wrote:
:
webrev: http://cr.openjdk.java.net/~dholmes/8129850/webrev/
This looks okay to me.
-Alan
HI Erik,
On 26/06/2015 10:22 PM, Erik Joelsson wrote:
Hello,
Please review this small fix for a build break on Macosx. Note that the
debugsymbols/stripping solution with StripBinaries.gmk is messy and
should ideally be fixed in a better way. For now, this is the simplest
way of fixing this prob
Hello David,
Looks good to me.
/Erik
On 2015-06-26 14:10, David Holmes wrote:
Apologies as the bug report is not public.
When I added cross-platform support for compact profiles under
JDK-8038189. I had to add a check for an empty variable but added it
in the wrong place in CreateJars.gmk w
Hello,
Please review this small fix for a build break on Macosx. Note that the
debugsymbols/stripping solution with StripBinaries.gmk is messy and
should ideally be fixed in a better way. For now, this is the simplest
way of fixing this problem.
In StripBinaries.gmk, all the lib and bin file
Apologies as the bug report is not public.
When I added cross-platform support for compact profiles under
JDK-8038189. I had to add a check for an empty variable but added it in
the wrong place in CreateJars.gmk when creating the resource.jar:
ifneq ($(PROFILE), )
+ ifneq ($(s
Looks good to me too; I like the name choice of the new
Provider/Description pair.
Maurizio
On 25/06/15 22:32, Jonathan Gibbons wrote:
Looks good to me :-)
-- Jon
On 06/24/2015 06:13 AM, Jan Lahoda wrote:
Hello,
After some offline discussions, I've somewhat changed the internal
API for pl
On 06/26/2015 10:29 AM, Erik Joelsson wrote:
> he current devkits basically contain the SS12u3 installation and a
> sysroot from a Solaris 10u10 machine. It should still compile on a pure
> Solaris 11 machine, but it's not tested as often. If you are able to
> construct a sysroot from a Solaris
Hello Andrew,
The current devkits basically contain the SS12u3 installation and a
sysroot from a Solaris 10u10 machine. It should still compile on a pure
Solaris 11 machine, but it's not tested as often. If you are able to
construct a sysroot from a Solaris 10 machine and want to use it, just
On 26/06/15 06:34, David Holmes wrote:
> On 25/06/2015 11:15 PM, Andrew Haley wrote:
>> On 06/25/2015 02:03 PM, Erik Joelsson wrote:
>>> Can you check that you have
>>> $(JDK_TOPDIR)/make/src/classes/build/tools/module in your source tree?
>>
>> Ah yes, that's a problem. Somehow a ton of files is
Hi Alan,
Thanks for the comments! A question inline.
On 25.6.2015 18:38, Alan Bateman wrote:
On 25/06/2015 17:25, Jan Lahoda wrote:
Hello,
Based on the feedback I've received so far, I've uploaded an updated
version of the patch:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev.01/full/
This looks good to me now.
/Erik
On 2015-06-02 18:50, Jan Lahoda wrote:
Hello Eric,
Thanks for the change, this seems definitely better to me. I've folded
your change that into my patch. An updated version (just langtools
this time):
http://cr.openjdk.java.net/~jlahoda/8072480/webrev.04/lan
Hello Jan,
Build changes look good.
/Erik
On 2015-06-25 18:25, Jan Lahoda wrote:
Hello,
Based on the feedback I've received so far, I've uploaded an updated
version of the patch:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev.01/full/
Notable changes:
-avoided the dependency on java.de
18 matches
Mail list logo
