RFR: JDK-8130109: Incremental build of java.base-gensrc broken

2015-06-30 Thread Erik Joelsson
Hello, Please review this small patch which fixes the incremental build of java.base-gensrc. There is a slight mistake in jdk/make/gensrc/GensrcCLDR.gmk where the target file of a rule has the wrong path, so make will always think it needs to be generated. Bug:

Re: RFR: JDK-8130109: Incremental build of java.base-gensrc broken

2015-06-30 Thread Tim Bell
Hi Erik: Please review this small patch which fixes the incremental build of java.base-gensrc. There is a slight mistake in jdk/make/gensrc/GensrcCLDR.gmk where the target file of a rule has the wrong path, so make will always think it needs to be generated. Bug:

Re: RFR: JDK-8130109: Incremental build of java.base-gensrc broken

2015-06-30 Thread Naoto Sato
+1 Naoto On 6/30/15 12:49 AM, Erik Joelsson wrote: Hello, Please review this small patch which fixes the incremental build of java.base-gensrc. There is a slight mistake in jdk/make/gensrc/GensrcCLDR.gmk where the target file of a rule has the wrong path, so make will always think it needs to

Re: [8u60] RFR: 8129926: Sub-packages in jdk.* are present in all Compact Profiles when they should not be

2015-06-30 Thread David Holmes
Thanks Alan! David On 30/06/2015 4:48 PM, Alan Bateman wrote: On 30/06/2015 03:03, David Holmes wrote: : http://cr.openjdk.java.net/~dholmes/8129926/webrev/ *** 205,214 --- 205,216 javax/sound \ javax/swing \ javax/xml/bind \ javax/xml/soap \

Re: [8u60] RFR: 8129926: Sub-packages in jdk.* are present in all Compact Profiles when they should not be

2015-06-30 Thread Alan Bateman
On 30/06/2015 03:03, David Holmes wrote: : http://cr.openjdk.java.net/~dholmes/8129926/webrev/ *** 205,214 --- 205,216 javax/sound \ javax/swing \ javax/xml/bind \ javax/xml/soap \ javax/xml/ws \ + jdk/internal/instrumentation \ +