Hi Erik,
Thank you for the quick review. I have fixed all your comments in this
new webrev, http://cr.openjdk.java.net/~sfriberg/JDK-8061281/webrev.02
Cheers,
Staffan
On 08/12/2015 03:15 AM, Erik Joelsson wrote:
Hello,
On 2015-08-12 01:34, Staffan Friberg wrote:
Hi,
Unfortunately we have
JBS Issue:
https://bugs.openjdk.java.net/browse/JDK-8130929
I need a small change to top level test/Makefile. If closed/test/Makefile is
not present it is simply ignored so this should have no impact on OpenJDK
builds. This change will allow (any) closed source components to be supported
with
Hi,
Please review changes for the bug:
https://bugs.openjdk.java.net/browse/JDK-8133347
This is a subtask of "jjs should use jline"
https://bugs.openjdk.java.net/browse/JDK-8080678
This subtask addresses infrastructure changes (module.xml, makefiles,
security policy) and basic jjs use of j
> On Aug 12, 2015, at 7:55 AM, Kumar Srinivasan
> wrote:
>
> Henry,
>
> Generally looks good here are some comments, on my initial
> pass, I am not fully done with args.c I will look at this some
> more later today or tomorrow.
>
> 4.)
> expectingNoDash is expectingMain right ? if so I would
Henry,
Generally looks good here are some comments, on my initial
pass, I am not fully done with args.c I will look at this some
more later today or tomorrow.
args.c:
1.) Can be folded
45 char *rv;
46
47 rv = (char *) JLI_MemAlloc(len + 1);
char *rv = (char *) JLI_MemAlloc(len +
Hello,
On 2015-08-12 01:34, Staffan Friberg wrote:
Hi,
Unfortunately we have not yet got the new repositories created in
OpenJDK for JEP-230 that was discussed earlier this year [1]. However
I wanted to make sure we are ready to push as soon as those
repositories are created.
These two web
