Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-infra integrations. :) Fortunately, no major code changes in the meantime has affected this patch. (I did need to update the new hotspot/make/lib/Lib-jdk.hotspot.agent.gmk though.) It seems I

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

Hi David, Resurrecting the second part of the build-infra integrations. :) Fortunately, no major code changes in the meantime has affected this patch. (I did need to update the new hotspot/make/lib/Lib-jdk.hotspot.agent.gmk though.) On 2015-11-16 05:33, David Holmes wrote: Hi Magnus, I ha

Re: RFR (S): JDK-8142909 Integration of minor fixes from the build-infra project

I'm trying to resurrect this review. Here is a new version: http://cr.openjdk.java.net/~ihse/JDK-8142909-hotspot-build-infra-integration/webrev.03 I have dropped all the changes related to -g and OPT_CFLAGS. I'm not interested in that kind of large scale operations on the old build system, I j

Re: RFR: JDK-8145008: Add libelf package to Linux devkit

On 2015-12-11 16:00, Erik Joelsson wrote: The devkit used for building OracleJDK on linux needs to add libelf. Here is the patch to the devkit creation makefiles to make that happen. Bug: https://bugs.openjdk.java.net/browse/JDK-8145008 Patch: diff --git a/make/devkit/Tools.gmk b/make/devkit/To

Re: RFR: JDK-8145185: Rename JAB the build tool to JIB

Hi Erik Looks good to me as well. /Tim On 12/11/15 07:43, Magnus Ihse Bursie wrote: Looks good to me. /Magnus 11 dec. 2015 kl. 15:50 skrev Erik Joelsson : Hello, Since the acronym JAB was already taken by Java Access Bridge, we nee dto find a new name for the new build tool. The new name

Re: [urgent] RFR: JDK-8145206: Configure broken on Macosx

Erik: JDK-8036003 broke configure on Macosx: checking what type of native debug symbols to use... zipped configure: error: Unable to find objcopy, cannot enable native debug symbols We can only fail for missing objcopy on platforms that actually use it. Bug: https://bugs.openjdk.java.net/br

[urgent] RFR: JDK-8145206: Configure broken on Macosx

JDK-8036003 broke configure on Macosx: checking what type of native debug symbols to use... zipped configure: error: Unable to find objcopy, cannot enable native debug symbols We can only fail for missing objcopy on platforms that actually use it. Bug: https://bugs.openjdk.java.net/browse/JDK

Re: RFR: JDK-8145185: Rename JAB the build tool to JIB

Looks good to me. /Magnus > 11 dec. 2015 kl. 15:50 skrev Erik Joelsson : > > Hello, > > Since the acronym JAB was already taken by Java Access Bridge, we nee dto > find a new name for the new build tool. The new name will be JIB - The JDK > Integrated Build tool. All references and file name

RFR: 8145132: Initial updates for ios x86_64 mobile/dev builds.

Here's the initial upload of changes that provides support for the ios and android ports for the mobile/dev repos. While there have been some preliminary reviews of the code, there is still more work required before we will look for more thorough reviews and an integration to mobile/jdk9 repos.

RFR: JDK-8145008: Add libelf package to Linux devkit

The devkit used for building OracleJDK on linux needs to add libelf. Here is the patch to the devkit creation makefiles to make that happen. Bug: https://bugs.openjdk.java.net/browse/JDK-8145008 Patch: diff --git a/make/devkit/Tools.gmk b/make/devkit/Tools.gmk --- a/make/devkit/Tools.gmk +++ b/m

RFR: JDK-8145185: Rename JAB the build tool to JIB

Hello, Since the acronym JAB was already taken by Java Access Bridge, we nee dto find a new name for the new build tool. The new name will be JIB - The JDK Integrated Build tool. All references and file names associated with JAB in the JDK 9 repos need to be changed to JIB. Bug: https://bugs

Re: RFR: 8073139 PPC64: User-visible arch directory and os.arch value on ppc64le cause issues with Java tooling

Hi Sasha, David, I've just verified that your patch still works for linux/ppc64. I've built and smoke-tested both linux/ppc64 and ppc64le and everything looks good. So from my side this is ready to push. Thanks for finally getting this ready! Volker On Fri, Dec 11, 2015 at 5:47 AM, David Holmes

Re: RFR: JDK-8145115: make JAVAC_FLAGS=-g no longer works

On Fri, 2015-12-11 at 14:10 +0100, Magnus Ihse Bursie wrote: > On 2015-12-10 16:02, Severin Gehwolf wrote: > > Yes, pretty please :) This is a long standing issue (not just java > > class debug info, but debug info in general). See > > JDK-8036003 with review thread: > > http://mail.openjdk.java.ne

Re: RFR: JDK-8144312: Remove limitations on the default number of jobs in the build

On 11/12/2015 11:16 PM, Magnus Ihse Bursie wrote: On 2015-12-03 03:11, Roger Riggs wrote: Hi, It would be useful to figure out the number of cpus available when in a container. Some comments have added to: 8140793 getAvailableProcessors may inc

Re: RFR: JDK-8144312: Remove limitations on the default number of jobs in the build

On 2015-12-03 03:11, Roger Riggs wrote: Hi, It would be useful to figure out the number of cpus available when in a container. Some comments have added to: 8140793 getAvailableProcessors may incorrectly report the number of cpus in Docker co

Re: RFR: JDK-8145115: make JAVAC_FLAGS=-g no longer works

On 2015-12-10 16:02, Severin Gehwolf wrote: Yes, pretty please :) This is a long standing issue (not just java class debug info, but debug info in general). See JDK-8036003 with review thread: http://mail.openjdk.java.net/pipermail/build-dev/2015-December/016155.html Once JDK-8036003 is fixed we

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

Hi Magnus, Thank you for reviewing! I like the new way of passing a help text for deprecation. Just a note, in the help text you called the new option "--with-debug-symbols" instead of "--with-native-debug-symbols", which is kind of unhelpful. ;-) You can just fix this, no need to upload a ne

Re: RFR: JDK-8145115: make JAVAC_FLAGS=-g no longer works

On 2015-12-10 15:49, Erik Joelsson wrote: I looked closer at your actual command lines and managed to reproduce. The problem is JAVAC_FLAGS=-g. We have unfortunately used that name for a local variable in make/CompileJavaModules.gmk. Fix is pretty simple, just rename that local variable. In the

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

On 2015-12-11 00:47, Yasumasa Suenaga wrote: Hi build folks, Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.06/ I like the new way of passing a help text for deprecation. Just a note, in the help text you called the new option "--with-debug-symbols" instead of