Re: RFR: JDK-8144312: Remove limitations on the default number of jobs in the build

On 15/12/2015 1:27 PM, Martin Buchholz wrote: My current mental model is configured cpus >= online cpus >= allowed cpus In a traditional system they are all the same. I experimented and saw that cpusets are indeed turned on in some systems used for testing at Google. I.e. allowed cpus is a stric

Re: RFR 8142398: IllegalAccessException Class sun.usagetracker.UsageTrackerClient$4 (module java.base) can not access a member of class java.lang.management.ManagementFactory (module java.management)

On 14/12/2015 16:55, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8138677 Webrev: http://cr.openjdk.java.net/~jbachorik/8138677/webrev.00 The problem is that the class UsageTrackerClient is accessing RuntimeMXBean.getInputArgum

Re: RFR 8142398: IllegalAccessException Class sun.usagetracker.UsageTrackerClient$4 (module java.base) can not access a member of class java.lang.management.ManagementFactory (module java.management)

> On Dec 14, 2015, at 8:55 AM, Jaroslav Bachorik > wrote: > > Please, review the following change > > Issue : https://bugs.openjdk.java.net/browse/JDK-8138677 > Webrev: http://cr.openjdk.java.net/~jbachorik/8138677/webrev.00 > > The problem is that the class UsageTrackerClient is accessing >

Re: RFR 8142398: IllegalAccessException Class sun.usagetracker.UsageTrackerClient$4 (module java.base) can not access a member of class java.lang.management.ManagementFactory (module java.management)

Hi Jaroslav, This movement of functionality seems okay to me. And good to see the JDK 6 code removed :) Thanks, David On 15/12/2015 2:55 AM, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8138677 Webrev: http://cr.openjdk.java.n

Re: Re: RFR: JDK-8144312: Remove limitations on the default number of jobs in the build

My current mental model is configured cpus >= online cpus >= allowed cpus In a traditional system they are all the same. I experimented and saw that cpusets are indeed turned on in some systems used for testing at Google. I.e. allowed cpus is a strict subset of online cpus. It seems likely that t

RFR 8142398: IllegalAccessException Class sun.usagetracker.UsageTrackerClient$4 (module java.base) can not access a member of class java.lang.management.ManagementFactory (module java.management)

Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8138677 Webrev: http://cr.openjdk.java.net/~jbachorik/8138677/webrev.00 The problem is that the class UsageTrackerClient is accessing RuntimeMXBean.getInputArguments() method via reflection to avoid static dep

Re: Re: RFR: JDK-8144312: Remove limitations on the default number of jobs in the build

Hi David, On 2015-12-11 14:21, David Holmes wrote: On 11/12/2015 11:16 PM, Magnus Ihse Bursie wrote: On 2015-12-03 03:11, Roger Riggs wrote: Hi, It would be useful to figure out the number of cpus available when in a container. Some comments have added to: 8140793

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

On 12/14/15 07:34, David Holmes wrote: On 14/12/2015 6:30 PM, Magnus Ihse Bursie wrote: On 2015-12-14 09:12, David Holmes wrote: Hi Magnus, On 12/12/2015 8:24 AM, Magnus Ihse Bursie wrote: On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-inf

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

On 14/12/2015 6:30 PM, Magnus Ihse Bursie wrote: On 2015-12-14 09:12, David Holmes wrote: Hi Magnus, On 12/12/2015 8:24 AM, Magnus Ihse Bursie wrote: On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-infra integrations. :) Fortunately, no majo

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

Looks good to me. /Erik On 2015-12-11 23:24, Magnus Ihse Bursie wrote: On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-infra integrations. :) Fortunately, no major code changes in the meantime has affected this patch. (I did need to update

Re: RFR (S): JDK-8142909 Integration of minor fixes from the build-infra project

Looks good to me. /Erik On 2015-12-11 21:20, Magnus Ihse Bursie wrote: I'm trying to resurrect this review. Here is a new version: http://cr.openjdk.java.net/~ihse/JDK-8142909-hotspot-build-infra-integration/webrev.03 I have dropped all the changes related to -g and OPT_CFLAGS. I'm not in

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

On 2015-12-14 09:12, David Holmes wrote: Hi Magnus, On 12/12/2015 8:24 AM, Magnus Ihse Bursie wrote: On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-infra integrations. :) Fortunately, no major code changes in the meantime has affected this p

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

Hi Magnus, On 12/12/2015 8:24 AM, Magnus Ihse Bursie wrote: On 2015-12-11 22:43, Magnus Ihse Bursie wrote: Hi David, Resurrecting the second part of the build-infra integrations. :) Fortunately, no major code changes in the meantime has affected this patch. (I did need to update the new hotspo