I am not a reviewer, but
If you want the range of IFS to be short, how about
for mirror in $(IFS=" ," echo ${jib_server_mirrors}); do
assuming you really only want IFS set for the expansion of the values for
mirror. Then you don't have to remember to save and restore it, either.
Erik:
Looks good to me as well.
/Tim
Right, new webrev: http://cr.openjdk.java.net/~erikj/8146002/webrev.03/
/Erik
On 2015-12-22 17:43, Magnus Ihse Bursie wrote:
Nice. Just one thing more: please save and restore the old value of
IFS. Things can behave strange when modifying IFS so it's go
Right, new webrev: http://cr.openjdk.java.net/~erikj/8146002/webrev.03/
/Erik
On 2015-12-22 17:43, Magnus Ihse Bursie wrote:
Nice. Just one thing more: please save and restore the old value of IFS. Things
can behave strange when modifying IFS so it's good to have it changed for as
short a per
Looks good to me.
/Magnus
> 21 dec. 2015 kl. 21:18 skrev Bob Vandette :
>
> http://cr.openjdk.java.net/~bobv/8145936/webrev.00/
>
> Please review the following fixes that were required to complete the
> initial bringup of the iOS ARM64 Zero Java runtime in the JDK 9 Mobile/dev
> forest.
>
>
Nice. Just one thing more: please save and restore the old value of IFS. Things
can behave strange when modifying IFS so it's good to have it changed for as
short a period as possible.
/Magnus
> 22 dec. 2015 kl. 15:33 skrev Erik Joelsson :
>
> Thanks for fast review!
>
> Added IFS and verifi
Thank you!
On 2015-12-22 18:39, Jaroslav Bachorik wrote:
> Hi,
>
> looks good, modulo the problems you are mentioning (docs will need
> update to refer to correct locations; the same might be true for the
> textual output from scripts). I believe the tests are still passing.
>
> Supposing the r
Hi,
looks good, modulo the problems you are mentioning (docs will need
update to refer to correct locations; the same might be true for the
textual output from scripts). I believe the tests are still passing.
Supposing the remaining problems are covered by CR you can consider this
reviewed.
Hi,
looks good, modulo the problems you are mentioning (docs will need
update to refer to correct locations; the same might be true for the
textual output from scripts). I believe the tests are still passing.
Supposing the remaining problems are covered by CR you can consider this
reviewed.
Thanks for fast review!
Added IFS and verified that it accepts any combination of space and
comma as separator.
Webrev: http://cr.openjdk.java.net/~erikj/8146002/webrev.02/
/Erik
On 2015-12-22 15:23, Magnus Ihse Bursie wrote:
If you set IFS=' ,' before looping over the jib_mirrors variable,
If you set IFS=' ,' before looping over the jib_mirrors variable, you will
allow a comma-separated list as well as a space separated, which makes it
possible to set using environment variables in a reasonable way. I think. :) I
always have to look up the details on IFS.
Otherwise it's looking
Hello,
If we are to rely on Jib, the whole process needs redundancy in download
locations. For the main downloads, this is already in place, but the
weak link is the initial bootstrapping of the tool itself. I propose to
add support in common/bin/jib.sh for checking a list of mirrors to
downl
On 2015-12-21 12:00, Erik Joelsson wrote:
Hello,
With Jib support in JDK 9, it would be nice to start using it in JPRT
instead of having JPRT having to track dependencies and
configurations. This change enables Jib in JPRT and disables all the
JPRT functionality for tracking dependencies (bui
On 2015-12-22 08:46, Erik Joelsson wrote:
Hello Dmitry,
Nice to see this happen!
make/lib/Lib-jdk.hotspot.agent.gmk:
Missing a "/libsaproc" here:
SA_SRC += $(SA_TOPDIR)/share/native
$(SA_TOPDIR)/$(OPENJDK_TARGET_OS)/native/libsaproc
Otherwise it looks good.
Looks good to me too.
/Magnus
13 matches
Mail list logo
