Re: RFR: JDK-8147950: Change JPRT to use new platforms for Linux, Windows and Macosx

2016-01-21 Thread Mikael Vidstedt
Looks good. Cheers, Mikael On 2016-01-21 06:42, Erik Joelsson wrote: We changed official build platforms a while back, but we still haven't completely changed what we use in JPRT. We are not quite ready to stop using the old build platforms yet. I would like to make a change to jprt.properti

Re: RFR: JDK-8147950: Change JPRT to use new platforms for Linux, Windows and Macosx

2016-01-21 Thread Tim Bell
Erik: We changed official build platforms a while back, but we still haven't completely changed what we use in JPRT. We are not quite ready to stop using the old build platforms yet. I would like to make a change to jprt.properties that enables us to use both for a time. Bug: https://bugs.op

RFR: JDK-8147950: Change JPRT to use new platforms for Linux, Windows and Macosx

2016-01-21 Thread Erik Joelsson
We changed official build platforms a while back, but we still haven't completely changed what we use in JPRT. We are not quite ready to stop using the old build platforms yet. I would like to make a change to jprt.properties that enables us to use both for a time. Bug: https://bugs.openjdk.ja

Re: RFR: JDK-8147795 Build system support for BSD

2016-01-21 Thread dalibor topic
On 20.01.2016 22:17, Magnus Ihse Bursie wrote: A reflection, though: If the requirement for such a port is that a company provides continuous testing and support, then I believe it's unlikely that any BSD port will ever reach the mainline, due to the community based nature of the BSD projects.

Re: RFR: JDK-8147934: Remove --with-sdk-name from macosx jib profile

2016-01-21 Thread Magnus Ihse Bursie
On 2016-01-21 11:52, Erik Joelsson wrote: The --with-sdk-name in the macosx profile is not needed, and will be ignored. Configure complains: WARNING: Both SYSROOT and --with-sdk-name are set, only SYSROOT will be used The devkit already enforces the correct sdk name through setting sysroot.

Re: RFR: JDK-8147933: Configure check for number of cpus ignores HT on Macosx

2016-01-21 Thread Erik Joelsson
Oops, too fast. diff -r f36cf7e8ba68 common/autoconf/build-performance.m4 --- a/common/autoconf/build-performance.m4 +++ b/common/autoconf/build-performance.m4 @@ -37,9 +37,9 @@ # Looks like a Solaris system NUM_CORES=`LC_MESSAGES=C /usr/sbin/psrinfo -v | grep -c on-line` FOUND_COR

Re: RFR: JDK-8147933: Configure check for number of cpus ignores HT on Macosx

2016-01-21 Thread Magnus Ihse Bursie
On 2016-01-21 12:11, Erik Joelsson wrote: Oops, too fast. That's better. :-) LGTM. /Magnus diff -r f36cf7e8ba68 common/autoconf/build-performance.m4 --- a/common/autoconf/build-performance.m4 +++ b/common/autoconf/build-performance.m4 @@ -37,9 +37,9 @@ # Looks like a Solaris system

Re: RFR: JDK-8147933: Configure check for number of cpus ignores HT on Macosx

2016-01-21 Thread Magnus Ihse Bursie
On 2016-01-21 11:45, Erik Joelsson wrote: On all other platforms except Macosx, the logic for detecting number of cpus includes hyperthreading in their count. We do see some speedup from setting the make -j flag to a number that includes HT so we should do the same on macosx. I chose to fix t

RFR: JDK-8147934: Remove --with-sdk-name from macosx jib profile

2016-01-21 Thread Erik Joelsson
The --with-sdk-name in the macosx profile is not needed, and will be ignored. Configure complains: WARNING: Both SYSROOT and --with-sdk-name are set, only SYSROOT will be used The devkit already enforces the correct sdk name through setting sysroot. Bug: https://bugs.openjdk.java.net/browse/JD

Re: RFR: JDK-8147930: Langtools test Makefile still requires special make in Cygwin

2016-01-21 Thread Magnus Ihse Bursie
On 2016-01-21 11:19, Erik Joelsson wrote: The langtools test Makefile doesn't work in Cygwin with the default make. It still expects the specially built gnu make which handles ':' in path names and particularly in rule declarations. The cause of the failure is JCK_HOME, which on Windows defaul

RFR: JDK-8147933: Configure check for number of cpus ignores HT on Macosx

2016-01-21 Thread Erik Joelsson
On all other platforms except Macosx, the logic for detecting number of cpus includes hyperthreading in their count. We do see some speedup from setting the make -j flag to a number that includes HT so we should do the same on macosx. I chose to fix this by querying sysctl for hardware informa

RFR: JDK-8147930: Langtools test Makefile still requires special make in Cygwin

2016-01-21 Thread Erik Joelsson
The langtools test Makefile doesn't work in Cygwin with the default make. It still expects the specially built gnu make which handles ':' in path names and particularly in rule declarations. The cause of the failure is JCK_HOME, which on Windows defaults to a string starting with "J:/". Bug:

Re: RFR: JDK-8147795 Build system support for BSD

2016-01-21 Thread Thomas Stüfe
Hi Magnus, for what it is worth, I like your effort and think this is valuable. Looking through your changes, it looks like the current BSD support (non-apply) is broken in a number of places and I think if we keep it, we should fix it. Disclaimer: I am neither a "R"eviewer nor a BSD expert. Beca

Re: Configure(still?) broken on OS X

2016-01-21 Thread Magnus Ihse Bursie
On 2016-01-19 23:40, David DeHaven wrote: Thanks, looks like this does the trick: ./configure --with-freetype=/opt/X11 This came up a while back, probably on another list... XQuartz had to change the install location due to 10.11 not allowing installation to /usr/X11, so our configure script

Re: ServerImpl misplaced null check

2016-01-21 Thread David Holmes
Hi Scott, cc'ing net-dev as this is not a build issue. David On 21/01/2016 4:18 AM, Scott Palmer wrote: I was searching for a way to set TCP_NODELAY for an Endpoint using the default HTTP server and after finally tracking down the existence of the “sun.net.httpserver.nodelay” system property