Re: RFR: JDK-8149479: Fix compare.sh to have a clean baseline with COMPARE_BUILD

2016-02-09 Thread Tim Bell
Erik: Please review these fixes for compare.sh and the COMPARE_BUILD flag for make. The rather new feature COMPARE_BUILD, which builds twice, applying some kind of change between them, is really neat. Especially when run through JPRT to check all platforms at once. The problem is that compa

Re: RFR: JDK-8145789: Switch JDK 9 to use Jib in JPRT

2016-02-09 Thread Erik Joelsson
This never made it in because of various issues. Those have now been resolved, so reposting this, updated to latest jdk9/dev. Webrev: http://cr.openjdk.java.net/~erikj/8145789/webrev.top.02/ /Erik On 2015-12-21 12:00, Erik Joelsson wrote: Hello, With Jib support in JDK 9, it would be nice to

RFR: JDK-8149479: Fix compare.sh to have a clean baseline with COMPARE_BUILD

2016-02-09 Thread Erik Joelsson
Hello, Please review these fixes for compare.sh and the COMPARE_BUILD flag for make. The rather new feature COMPARE_BUILD, which builds twice, applying some kind of change between them, is really neat. Especially when run through JPRT to check all platforms at once. The problem is that compa

Re: RFR: JDK-8149466: configure failed after JDK-8148351

2016-02-09 Thread Yasumasa Suenaga
Hi Magnus, Thanks, I've understood. I closed JDK-8149466 as "Not an issue" . Yasumasa On 2016/02/09 23:33, Magnus Ihse Bursie wrote: > On 2016-02-09 15:29, Yasumasa Suenaga wrote: >> Hi Magnus, >> >>> If this is not possible, then you can specify your compiler explicitely >>> using "configure

Re: RFR: JDK-8149466: configure failed after JDK-8148351

2016-02-09 Thread Magnus Ihse Bursie
On 2016-02-09 15:29, Yasumasa Suenaga wrote: > Hi Magnus, > >> If this is not possible, then you can specify your compiler explicitely >> using "configure CC=/usr/bin/gcc CXX=/usr/bin/g++" or whatever. > I could avoid it with these options. > > Error message says that we can avoid this error with -

Re: RFR: JDK-8149466: configure failed after JDK-8148351

2016-02-09 Thread Yasumasa Suenaga
Hi Magnus, > If this is not possible, then you can specify your compiler explicitely > using "configure CC=/usr/bin/gcc CXX=/usr/bin/g++" or whatever. I could avoid it with these options. Error message says that we can avoid this error with --enable-ccache. However, I could not avoid with it. T

Re: RFR: JDK-8149466: configure failed after JDK-8148351

2016-02-09 Thread Magnus Ihse Bursie
On 2016-02-09 14:43, Yasumasa Suenaga wrote: > Hi all, > > After JDK-8148351, configure script failed as below: > > > configure: Using default toolchain gcc (GNU Compiler Collection) > checking for gcc... /usr/lib64/ccache/gcc > checking resolved symbolic links for CC... /usr/bin/ccache

RFR: JDK-8149466: configure failed after JDK-8148351

2016-02-09 Thread Yasumasa Suenaga
Hi all, After JDK-8148351, configure script failed as below: configure: Using default toolchain gcc (GNU Compiler Collection) checking for gcc... /usr/lib64/ccache/gcc checking resolved symbolic links for CC... /usr/bin/ccache configure: Please use --enable-ccache instead of providin

Re: RFR(XS) : 8144695 : --disable-warnings-as-errors does not work for HotSpot build

2016-02-09 Thread Igor Ignatyev
Kim, Magnus, Thank you for review. — Igor > On Feb 9, 2016, at 12:54 PM, Magnus Ihse Bursie > wrote: > > On 2016-02-08 20:37, Kim Barrett wrote: >>> On Feb 7, 2016, at 4:22 PM, Igor Ignatyev wrote: >>> >>> Hi Kim, >>> >>> could you please take a look at the updated webrev: >>> http://cr.o

Re: question on jigsaw build

2016-02-09 Thread Chris Hegarty
Magnus, Thank you for your reply. On 09/02/16 09:57, Magnus Ihse Bursie wrote: On 2016-01-25 13:43, Maurizio Cimadamore wrote: Hi, the current build system in JDK 9 has a way to recover all the source dirs for a given module, by doing something like this: $(call ALL_SRC_DIRS,$(mod)) That is,

Re: question on jigsaw build

2016-02-09 Thread Magnus Ihse Bursie
On 2016-01-25 13:43, Maurizio Cimadamore wrote: Hi, the current build system in JDK 9 has a way to recover all the source dirs for a given module, by doing something like this: $(call ALL_SRC_DIRS,$(mod)) That is, the build system exports a function that can be passed a module name and will

Re: RFR(XS) : 8144695 : --disable-warnings-as-errors does not work for HotSpot build

2016-02-09 Thread Magnus Ihse Bursie
On 2016-02-08 20:37, Kim Barrett wrote: On Feb 7, 2016, at 4:22 PM, Igor Ignatyev wrote: Hi Kim, could you please take a look at the updated webrev: http://cr.openjdk.java.net/~iignatyev/8144695/webrev.03 I agree that “+w” isn’t related to WARNINGS_ARE_ERRORS, so it was moved to CFLAGS_WARN