Hi,
This one was discussed back to Feb, and have been waiting for the devkit
clearance
from the build-dev, which has just been resolved [1]. So here is webrev again.
http://cr.openjdk.java.net/~sherman/8031767/webrev
thanks!
Sherman
[1] https://bugs.openjdk.java.net/browse/JDK-8149545
btw,
(adding core-libs)
On 2016-03-23 12:13, Erik Joelsson wrote:
In the gensrc step for java.base, we generate a couple of java classes
with the purpose of extracting native constants from the system. We
currently do this by compiling a C program that when run, generates
the java source file. The
Looks fine.
Mandy
> On Mar 23, 2016, at 1:59 AM, Sundararajan Athijegannathan
> wrote:
>
> Hi,
>
> Please review http://cr.openjdk.java.net/~sundar/8152268/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8152268
>
> Thanks,
> -Sundar
+1
On 23.03.16 13:48, Erik Joelsson wrote:
Build changes are still good.
/Erik
On 2016-03-23 11:46, Alexander Scherbatiy wrote:
On 23/03/16 13:56, Rajeev Chamyal wrote:
Hello Alexandr,
I have updated the webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8145173/webrev.06/
In the gensrc step for java.base, we generate a couple of java classes
with the purpose of extracting native constants from the system. We
currently do this by compiling a C program that when run, generates the
java source file. The problem with this approach is that when cross
compiling, we ca
Build changes are still good.
/Erik
On 2016-03-23 11:46, Alexander Scherbatiy wrote:
On 23/03/16 13:56, Rajeev Chamyal wrote:
Hello Alexandr,
I have updated the webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8145173/webrev.06/
The fix looks good to me.
Thanks,
A
On 23/03/16 13:56, Rajeev Chamyal wrote:
Hello Alexandr,
I have updated the webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8145173/webrev.06/
The fix looks good to me.
Thanks,
Alexandr.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexandr Scherbatiy
On 22/03/16 22:57, Kim Barrett wrote:
>> On Mar 16, 2016, at 6:12 AM, Andrew Haley wrote:
>
> The change got pushed before I had a chance to look at the revised
> version, but I wanted to get back to this part of the discussion.
Great!
> I agree that Node::operator new invokes UB. It's also ra
Hello Alexandr,
I have updated the webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8145173/webrev.06/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexandr Scherbatiy
Sent: 22 March 2016 20:15
To: Rajeev Chamyal; Sergey Bylokhov; [email protected];
buil
+1
Am 2016-03-23 um 09:59 schrieb Sundararajan Athijegannathan:
Hi,
Please review http://cr.openjdk.java.net/~sundar/8152268/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8152268
Thanks,
-Sundar
On 23/03/2016 08:59, Sundararajan Athijegannathan wrote:
Hi,
Please review http://cr.openjdk.java.net/~sundar/8152268/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8152268
This looks okay, similar to what we had to do with appletviewer.
-Alan.
Hi,
Please review http://cr.openjdk.java.net/~sundar/8152268/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8152268
Thanks,
-Sundar
12 matches
Mail list logo
